From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 403552F39AB for ; Tue, 11 Aug 2026 02:32:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786415532; cv=none; b=Chw4IA51NL814Zz+6lHIFj7iZt9u9jWh41QZS8vIIMfl/2L8FKGC+KzL9e8pPiR1e841p9SFM4fJU1YQvwFzVkt/5Rw34bPM8Iug+ggaO9eidFC6UIiR4C41+E0BuGQawiwJw+cNli6CCpe0E8xGLTcF3c+ioLyPn/RBSmDrUXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786415532; c=relaxed/simple; bh=MGToxY2eDxoM6n9czlVuDmQRwlhCvJ/pAfN2DdTuhA8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ki5VgtmQeqPldUEhqGbNDMQka78yHy+TT3FaY7m/bBjB4lMScw8VZgusC0dcckf+sI45+FPr0npZTXrwJbzgOKAwso6XpBmOD0RpyARZgRcmYIjA4Bz2DHjp+fxKtHRPW0zJ1bUKpZbs4OY29UA9Cvp0Wa4+NjbFMwHknaFU7uw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hwqGvKLX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bu2PwZML; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hwqGvKLX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bu2PwZML" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67AMpuhI3047704 for ; Tue, 11 Aug 2026 02:32:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= C7bWfU9OcPL3SCb4TRXGcsCsHePl/fLg8SdLe4htIgc=; b=hwqGvKLX5Ord9dO9 aA+WLQfBJgNa7NxXJILgQpxOv+PevzHAxiMt4y/SBLtlaM0Ad2+B0qT4SzPiEIXx mIeaDEE9HK6eS8Iqrd8cNtE5f0SRvz+2X3+Bu8XmBljoqV0a1Dph/Ubl3dT/d/Nc PgZXfY7xY4Qu74nxQKc1c+UWkklXbJcpE8ZwQwzlCdsZELU6r+DsH+BSfdqPhG8D Wg5f2H7wSFZpTobVoXWjaB4hqlLQ7/ea2dd52EKBxeqEQLV5u98JMBx70eT7ZW10 pigRsD7A2Ok/9e+Ds+ILt099S/VDU6pX9vEmh58L50SUy6cFn1/WFOim0k2wTUvG DTfzpA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fyjk221mn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 11 Aug 2026 02:32:08 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38e6d253330so632213a91.1 for ; Mon, 10 Aug 2026 19:32:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786415528; x=1787020328; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=C7bWfU9OcPL3SCb4TRXGcsCsHePl/fLg8SdLe4htIgc=; b=bu2PwZML8nS3b9fWS2oeZW6X8NtGPHKBg9yBaAqIjkLSQ9YvLbeKWNhnV1hmpyu7ro oab4JlkhpPxW7u+41GbJB5Sni3GSFHbDeEIpiysU4fEhAGrI8MbeI3OyZ9HwBcYfnRCC gaZFB22039gRytYYX6sJQFWb8LSBXedtuvlRUO6XQr35BfK7BbTxVQTX19FqPS83/UjM Ts+I06p5mIxQi4Zbw6pu8SthJOQqcvjTRjcon3UvNT8Ut4WWtp19mG/7YBPBatYIe3RP NglS3RImSxR70rjDzSB5WeIQjcSlot/NNFCqPnMuhFTmAs6P67Q4vPfs6Ho2toquOQ5g BJkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786415528; x=1787020328; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=C7bWfU9OcPL3SCb4TRXGcsCsHePl/fLg8SdLe4htIgc=; b=S0JckbJbw209e447XsKaeMsyJ1kI9xoF2OUBlyQleaghIw1E28yfCTJZzwCKz9sj+T icPCoqJhvaZQhsEzx7i8akLnqz1i+T+iIu/pT3HwgCJ02njtJiZhm2oOVlRJukMVgtMl BcxygmsW3358qzR/vOyyYrkgTuhnqkf5gBoqbri/fbxXJWnWQ89eD0Ys1qDaG5++Jn0u WqfkXJJfj1+3eylvkcqOgiF7vlbPpe/zuoTxeVNspi3HaP7X7pmNO0D+VYAieH1IcTy9 GEOWuWg52DMkQjXhtPp7wEmjp/9n/JQo5XopG/e9eavC4a8037uIbfjkjbkvd+WLhhGh XBrg== X-Forwarded-Encrypted: i=1; AHgh+RpBiqh76Oxvjsn4QF8LwXi2MIutG1ymOe94k7bnGQsl7YYo3/qbm5OML29IgBxrAinOzCHclF1fauvtPhY=@vger.kernel.org X-Gm-Message-State: AOJu0YxpLcS5QF9uervj+jMqLFFjoGA+nVKgY9fePjGnqCiu2e8mbTa4 Q8Cfh16ZDtvQxoVVL9Ac+wW2l9EeqU9sBph2UoZ/aH03kL666qsACisTBuOcCpyb7X3jP5feX0v /S7NtJlDUuUUL1iWKq7V14d4vvkz25NSmy5AwX3PD7gnk9F2P3dcIywLgefNHfxW6NBc= X-Gm-Gg: AR+sD138KRTwWkFhcUtH+2yRvsLsDBjzD7OeEmRk2DkewBmiCtXfaeuEI0U+y236W9p vG6/9koLswrbPbnaj7Z787NOC5o5e8bGC6ZGM1H2IDJM1lhLbDMXYJIl7lEuUWYIk5+7UPJ7PzO 4nPBY70RfcyUicc6eMaEDjAOU7vtel3JdRf/qdlLFraowJGz8R4LyCHOX0ye4hi9e1OZ2oHbGWC zxnDnideWvZLKhEzdp6XlOPAWTQuQN3WgcIGWwmiJ4sgAkowkd/6zajeRJv+98j/hWFXND4nMpf Isb+//bNE/+1uBKi/qJfdTqEI5JhEztUyuqlFNx8nwRmvOWu/xbNrdr0Y24NzgX92Gvv+eWkkoo oj+XZQNC3m4MuELlbIFDSkIEH4UKvQVjvNo5OHQW0LGM4M6IgwFr8CooONMgCAT64KBgG6WNi X-Received: by 2002:a17:90b:1d10:b0:38e:c232:9d2c with SMTP id 98e67ed59e1d1-392d611213fmr857756a91.2.1786415528058; Mon, 10 Aug 2026 19:32:08 -0700 (PDT) X-Received: by 2002:a17:90b:1d10:b0:38e:c232:9d2c with SMTP id 98e67ed59e1d1-392d611213fmr857741a91.2.1786415527554; Mon, 10 Aug 2026 19:32:07 -0700 (PDT) Received: from [10.133.33.43] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392d51be07dsm1581789a91.6.2026.08.10.19.32.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2026 19:32:07 -0700 (PDT) Message-ID: <73f642ac-6be7-4287-89d6-d6afd9655efa@oss.qualcomm.com> Date: Tue, 11 Aug 2026 10:32:04 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] wifi: ath12k: clear dangling channel pointers on error paths To: Linkai Gong , jjohnson@kernel.org Cc: vasanthakumar.thiagarajan@oss.qualcomm.com, rameshkumar.sundaram@oss.qualcomm.com, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260811020523.387433-1-gonglinkai@kylinos.cn> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260811020523.387433-1-gonglinkai@kylinos.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODExMDAxOCBTYWx0ZWRfXyGTnQtYUfAS0 XYyXNVAeWefDg6LluQiYJcl7BPCeAFii48a3e81lvsDmZwWLHCJyT3n+Oi+oI+N5ZcRGTJXWWq7 iuUPoukjuihkyBBt/ASTqTEIEywpli4= X-Proofpoint-GUID: xLnZF61NkyfIMv8Nu-iTIdPgvQf4Eis5 X-Proofpoint-ORIG-GUID: xLnZF61NkyfIMv8Nu-iTIdPgvQf4Eis5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODExMDAxOCBTYWx0ZWRfX4oLW7N+5DbaZ fIf8KnqkPreIeIULAbGOenm3b3rPwVPgxd4eyfAuyBAWzBN5YrUwa8XepU78hJbeshbgNJc3m9Z lWVZy/naz02TLQO5sKwLRvEFm0kvSXtduc8lk52/eiNQEam1IseJ9qs2wi6d6omiGxKnPVv1ydL g5FSXO1nHP86/Lc0hJ+pEnRwpKQ5TTFlsh0zVIw9HRKwVxr1rcQ9g7erF0iVFGFFqfRFp8cCv++ fYvLHI4DbIQ1JwG85lePHpfqRRt+enKAeYt/4h+2RyyN5OjldCA40voIGlcV2sZG5vnBafToZCu UPgNNHZ7mm1JqtFZEzeAc2H3ItrEXkJqGnW7gYUTAD7wUv0hBpFsFuVxgKBLC0IqWVwT+8ec16P 9ZEdyeNX7sqfuhfvHGWstgYlza+uoY199/y0S+kEi/TOe/0VqucEaZGyrh2kEpSKhzAk7JqRHAf G8POgKbPmzmuxzPyWUQ== X-Authority-Analysis: v=2.4 cv=eJ4jSnp1 c=1 sm=1 tr=0 ts=6a7a89a8 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=CpnD9HFvDKrr3bQfTTUA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_06,2026-08-10_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608110018 On 8/11/2026 10:05 AM, Linkai Gong wrote: > On failure, ath12k_mac_setup_channels_rates() frees band channel > arrays but leaves the pointers set, or clears the wrong band after a > copy-paste typo (6 GHz free paired with a 2 GHz NULL). Clear the > matching sbands[].channels pointer after each kfree(). > > Compile tested only. > > Signed-off-by: Linkai Gong Reviewed-by: Baochen Qiang