From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 167DE14A09C for ; Mon, 13 Jan 2025 03:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736738889; cv=none; b=iyzK2K6/ALF/kAXh/D1RMr3aFxWr8dFm7pk48kgrlPcMbYjVl5XhtXqkxDNMjUU0WukwpNT8WdBK9Im3Yqq3LVmqAxJAmWLRYK4qqHE1mNIe2V/wBuVP+pIiXEJHpD98LFtNgThj/AicOIA488ZFjdOwXyt886JUjy6gKjWkU5g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736738889; c=relaxed/simple; bh=r5vxfRwDPvOeWxy3wA2vUhJSwptRpvu9EIqzKdaHhZo=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=RcREoBB0ZrIgukHoXGKAsdXMv2d3Enuxh3iWdqC4ZwrLoEVZxsJPjrJ5HsNH+P5Gi26sDn6cr+3VS7Tm5fOsXAIxxks2BEzILbhNixeVdZG1a9bVoITAeYmcRw5wi1Vz71W1rJw4Iudg2nJBhos8WfWIc8h5PsT6HlD6UzERRZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XVprcYM0; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XVprcYM0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736738887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LilDh//MVrOggcKgFAIVX9hjkBC7FGeecRxQ+QFzAA0=; b=XVprcYM0Mk/HQhS4AzyVykio20wqYxgKzoJ1oPMLkT+UzJr+A1N58xvoJhb4PLDCTne0GW ykU+bsvm5fUt3fnzAm55zgANSZVHl7kH3M/FBgDuXbfBDLZLf/PUr4vhye3UtX/KCUA9sC ChJDQEGH2I3fKO+2qRBzuJkk3+ZX9uE= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-p-Ja_W0DNtCbju5y7lFn2g-1; Sun, 12 Jan 2025 22:28:05 -0500 X-MC-Unique: p-Ja_W0DNtCbju5y7lFn2g-1 X-Mimecast-MFC-AGG-ID: p-Ja_W0DNtCbju5y7lFn2g Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6d8f8f69fb5so78363336d6.1 for ; Sun, 12 Jan 2025 19:28:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736738885; x=1737343685; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LilDh//MVrOggcKgFAIVX9hjkBC7FGeecRxQ+QFzAA0=; b=mo5TWzM3r9FAxHgt2zhWK/YR1AtHya0IdUdpVG90Y09lnaBepmmc2B+U/oDwqFPm0Y 2OP0q7meS6KG1OgJJb54EzyGoLF2kmiXMKTo/E/mp/eUOMIoIPzsWvcq2JJIYE59QReH 5v4cps9fMwzvrrNfEw3UpdM2cCBo0R9enEQk3ym7Qj2K3OpWHtNvRnyL09aFctNM/zKX By/pBiWNON2MPGjJ8Z019E/+Q7MuNcDbgxal2aUY7Gfa4X6lu2zg0ksGNjTSzgKqpoZ4 qSkRHbhgPr6GVlQ+/fzTThOaV8JWHfgqaNxDtxdMrRJIK9vlM8l9uYGw/C79u9htwd/q w2Kg== X-Forwarded-Encrypted: i=1; AJvYcCWor8Vhk1xJ5gaRG8TuNJHxNd+z06xof1YKlWn3hzt3EBu2C0PfuNxOIAzkhPKhuDXJhNhbPPupl1pcvHk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw167hu5w7GwjeeuoayxiuTkWwDlnypmGEKPFm0Bx1M2pNmDIuL dVr8OtPd3eo86aCBwdLaTl3f1pP2W/gdUyL+BH1aNTGrhog7GaQfepNrQmGurOBth8fKC5K9UM7 4YCiCg+f8VLZqeaoxv2EO2nesz/JHeKYzj+q+SbU3L2hty/EPjjV6mZorq01FSw== X-Gm-Gg: ASbGncsqYY7aK+q1dUmPKGPY5MCHZEy05wRtJVXzrc6uCjtNFRwPVtOm/UroxaeHTzv stHcSPvevGUyi1/GkMSPvgqGTE7AotYSeojyVE4vU0dQSQPMhW7Mnh4MJBGbHCovhTJ7RFhGNvH qeBzYSawn15tuDECGLlzc/pK2rFKHCJRvee0zoS5+S2+k399G3GLLefOv+r0KY/bw1dMYBvkrdb tMqi8GmWNeiJ6glCwlHnSfy8/SmwGBlS1SAcQaDa3HL34WTjQW/W0v/mTBRFBqva/4wZvVdpY/s eJt8sS/VGqWWfRO7J0jNskWk X-Received: by 2002:a05:6214:2588:b0:6d8:94f4:d2a8 with SMTP id 6a1803df08f44-6dfba9f7ceemr114228466d6.9.1736738885174; Sun, 12 Jan 2025 19:28:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IGtZw3gENgfeq8B4ufOwroddyqNCJWcTVE2jQSy3/wpbK9MQdlxDUeJ2k0z9ksfmthJIv9bRA== X-Received: by 2002:a05:6214:2588:b0:6d8:94f4:d2a8 with SMTP id 6a1803df08f44-6dfba9f7ceemr114228306d6.9.1736738884935; Sun, 12 Jan 2025 19:28:04 -0800 (PST) Received: from ?IPV6:2601:188:ca00:a00:f844:fad5:7984:7bd7? ([2601:188:ca00:a00:f844:fad5:7984:7bd7]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dfade89079sm36553596d6.97.2025.01.12.19.28.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jan 2025 19:28:04 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <73fc5150-ecfe-4dbc-8188-acb818c1cfa2@redhat.com> Date: Sun, 12 Jan 2025 22:28:01 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] locking/rtmutex: Use struct keyword in kernel-doc comment To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng References: <20250111063040.910763-1-rdunlap@infradead.org> Content-Language: en-US In-Reply-To: <20250111063040.910763-1-rdunlap@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/11/25 1:30 AM, Randy Dunlap wrote: > Add the "struct" keyword to prevent a kernel-doc warning: > > rtmutex_common.h:67: warning: cannot understand function prototype: 'struct rt_wake_q_head ' > > Signed-off-by: Randy Dunlap > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Will Deacon > Cc: Waiman Long > Cc: Boqun Feng > --- > kernel/locking/rtmutex_common.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- linux-next-20250108.orig/kernel/locking/rtmutex_common.h > +++ linux-next-20250108/kernel/locking/rtmutex_common.h > @@ -59,8 +59,8 @@ struct rt_mutex_waiter { > }; > > /** > - * rt_wake_q_head - Wrapper around regular wake_q_head to support > - * "sleeping" spinlocks on RT > + * struct rt_wake_q_head - Wrapper around regular wake_q_head to support > + * "sleeping" spinlocks on RT > * @head: The regular wake_q_head for sleeping lock variants > * @rtlock_task: Task pointer for RT lock (spin/rwlock) wakeups > */ > Acked-by: Waiman Long