From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751976AbdBBUUG (ORCPT ); Thu, 2 Feb 2017 15:20:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51152 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751298AbdBBUUF (ORCPT ); Thu, 2 Feb 2017 15:20:05 -0500 Subject: Re: [dm-devel] linux-next: Tree for Feb 2 (drivers/md/dm.c) To: Christoph Hellwig , Mike Snitzer References: <20170202182117.73e354f1@canb.auug.org.au> <8a8224e7-4c90-7fa7-9960-fc04fe658014@infradead.org> <20170202182916.GA26910@redhat.com> <20170202184409.GA27869@infradead.org> Cc: Randy Dunlap , Stephen Rothwell , linux-kernel@vger.kernel.org, dm , linux-next@vger.kernel.org, Alasdair G Kergon From: Paolo Bonzini Message-ID: <73fe1d1f-e0ef-f79c-9997-2573f5687d70@redhat.com> Date: Thu, 2 Feb 2017 12:19:57 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170202184409.GA27869@infradead.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 02 Feb 2017 20:20:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/2017 10:44, Christoph Hellwig wrote: > ec8013bedd ("dm: do not forward ioctls from logical volumes to the > underlying device"), > > The trivial fix would be to add a select of the SCSI_REQUEST symbol > to dm, but my gut feeling teels me the call is simply wrong, and > should be removed and instead all ioctls on DM devices that don't > map to a full underlying devices should be rejected. I would certainly be fine with that. It would not be surprising if something broke, but a middle ground could be to allow all ioctls if you have CAP_SYS_RAWIO and none if you don't. Paolo