Re: [PATCH net] dt-bindings: net: ethernet-controller: Add informative text about RGMII delays

[Andrew Lunn <andrew@lunn.ch>]

> > +# In practice, very few PCBs make use of extra long clock lines. Hence
> > +# any RGMII phy mode other than 'rgmii-id' is probably wrong, and is
> > +# unlikely to be accepted during review.
> 
> Maybe add "without details provided in the commit description."

I was thinking about that. And i would actually prefer a comment in
the DT explicitly saying the PCB adds delays.

> > +# If the PHY is to perform fine tuning, the properties
> > +# 'rx-internal-delay-ps' and 'tx-internal-delay-ps' in the PHY node
> > +# should be used. When the PHY is implementing delays, these
> > +# properties should have a value near to 2000ps.
> 
> ... according to the phy-mode used (as they're documented to be
> dependent on that.)
> 
> I'm wondering whether they should be dependent on which rgmii-* mode
> is being used, as delays << 2ns could be used to finely adjust the
> PCB delays if the PHY supports that. I haven't looked closely enough
> at PHY datasheets to know whether that's possible or not though.

Yes, i was trying to express that with the 'When the PHY is
implementing delays'. If the PHY is not adding delays, 'rgmii', small
fine tuning delays are O.K. And some PHYs do support this, they cover
the full range from 0ps to > 2000ps in steps.

	Andrew