From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932848AbcIBQAP (ORCPT ); Fri, 2 Sep 2016 12:00:15 -0400 Received: from mail-by2nam01on0060.outbound.protection.outlook.com ([104.47.34.60]:15088 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932466AbcIBQAE (ORCPT ); Fri, 2 Sep 2016 12:00:04 -0400 X-Greylist: delayed 6261 seconds by postgrey-1.27 at vger.kernel.org; Fri, 02 Sep 2016 12:00:03 EDT Authentication-Results: spf=pass (sender IP is 63.163.107.225) smtp.mailfrom=sandisk.com; rjwysocki.net; dkim=none (message not signed) header.d=none;rjwysocki.net; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: 0ac94371-607ff7000000f08d-8f-57c9a027cf3e Subject: Re: [PATCH] trivial treewide: Convert dev_set_uevent_suppress argument to bool To: Joe Perches , Jens Axboe , "Rafael J. Wysocki" , Len Brown , Sebastian Ott , Peter Oberparleiter , Miklos Szeredi , Jiri Kosina References: <699402ce4c488995b4ddabff0f3b262851cf56ac.1472760613.git.joe@perches.com> <1472777516.4176.149.camel@perches.com> <1472830862.6758.7.camel@perches.com> CC: Martin Schwidefsky , Heiko Carstens , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" From: Bart Van Assche Message-ID: <7405780b-3dcd-3c6a-9268-3fac6f3a7b3f@sandisk.com> Date: Fri, 2 Sep 2016 08:59:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <1472830862.6758.7.camel@perches.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJIsWRmVeSWpSXmKPExsXCddJ5ka7WgpPhBp8em1msvtvPZnHswksW i9n3H7NY7Hz4ls1i+b5+Rou9t7Qt9uw9yWJxedccNosJC5uZLZ7t3shs0fD9O7PFmdOXWC0+ n2tjtzjVdZjR4v3+y0wO/B4HHx1i87h8ttRj06pONo8HhzazeHxZdY3ZY8vVdhaPFdMuMnl8 3iQXwBHFZZOSmpNZllqkb5fAlbFi1Q32gp+cFS/utLA0MP5h72Lk5JAQMJH4+XsGcxcjF4eQ wFImiRM7/7FAONsZJTZ/X8sEUzWr/SsbVBWjxOIdR8ESwgKREgtOzQHrEBHYwCQxr7URqv0s k8T/39NYQRxmgVnMEt173zKCtLAJGEl8ez+TBcTmFbCTmLLrIZjNIqAi0X5gC1iNqECYxLS7 b9khagQlTs58AlbDCdS7uf0N0LUcQEPtJR5sLQMJMwvIS2x/OwfsCQmBGWwSz96sZwZJCAmo S5xcMp9pAqPwLCSjZiG0z0LSvoCReRWjWG5mTnFuemqBoYlecWJeSmZxtl5yfu4mRkiEFu5g fH3b+xCjAAejEg/vjbqT4UKsiWXFlbmHGCU4mJVEeLXmA4V4UxIrq1KL8uOLSnNSiw8xSnOw KInzXoz+GCYkkJ5YkpqdmlqQWgSTZeLglGpg7FvMtujxDjuVBw/unX0VvLr5/OH5U1We6txo mPJaKyWJkVeHi/kWp1rtrj3mC893OpvqnBNU33H62OKZs60mHTt9tOR2yec1zGIn3FctzE2t 8n7s5hQu8kDHwMtkUaUCY1ydtscdzSNCT5NXmKhmHZ/Jf2HbRw0Ze4FfN6R2fDe8aTnnc9iU QiWW4oxEQy3mouJEAOa068nMAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPLMWRmVeSWpSXmKPExsXCtZEjRff7wpPhBle38VusvtvPZnHswksW i9n3H7NY7Hz4ls1i+b5+Rou9t7Qt9uw9yWJxedccNosJC5uZLZ7t3shs0fD9O7PFmdOXWC0+ n2tjtzjVdZjR4v3+y0wO/B4HHx1i87h8ttRj06pONo8HhzazeHxZdY3ZY8vVdhaPFdMuMnl8 3iQXwBHFZZOSmpNZllqkb5fAlbFi1Q32gp+cFS/utLA0MP5h72Lk5JAQMJGY1f6VrYuRi0NI YDGjxLIzu5lBEsICkRILTs1hAbFFBDYwSTSvk4UoOssk8f/3NFYQh1lgFrPEjM93GEGq2ASM JL69nwnWwStgJzFl10Mwm0VARaL9wBawGlGBMIlpd9+yQ9QISpyc+QSshhOod3P7G7DNzAK2 Enfm7oay5SW2v53DPIGRbxaSlllIymYhKVvAyLyKUSw3M6c4Nz2zwNBIrzgxLyWzOFsvOT93 EyM4SjijdjBen2h+iJGJg1OqgbHyQ7Lpa4+67pD3jGcLTn02lrju8sDUlPW/pbhz59NqzY1v vX+a6peyz3LMmXDziXCd5vJ1RzMOiMc+Kva/2i3MsrycQbj9pcSUJvMjPNYpT2LYfy9MfeY7 t/Hhm3NVnIpfr9pv3twaJfL1T+by9Edrdryw3xfZbNmzOWlGKNvBfTPefwl3rVFiKc5INNRi LipOBAC5/PPiQgIAAA== X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.225;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(377454003)(199003)(189002)(377424004)(24454002)(51444003)(31696002)(81156014)(5660300001)(65956001)(36756003)(7696003)(93886004)(65806001)(2950100001)(23746002)(5001770100001)(77096005)(8936002)(2906002)(81166006)(64126003)(53416004)(87936001)(68736007)(4001350100001)(31686004)(4326007)(106466001)(76176999)(97736004)(47776003)(230700001)(11100500001)(86362001)(626004)(83506001)(33646002)(65826007)(50986999)(356003)(586003)(7416002)(305945005)(8676002)(92566002)(2270400002)(69596002)(50466002)(54356999)(189998001)(7846002);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2PR02MB401;H:milsmgep14.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11OLC004;1:8AeR8cpSdAn58vYUC6iFEm6owA28REuP4k6fozJYgVT7lWPFRfAL17fK5y4Dbm5Pfh/6+fpHzCQNRqvp9e0sEwEO3CnJErkxMp9jFgoVOXS/Asb7OtxEWg3ENz+t39KqcWdykoq5ufKldpsvKdTutvaZubYuffYS6caO+xAtLUTEHVUJZv5JpW4T8PF6+hmfuxTJjScw9Lp88pimOSxAgLVwBg2bZuIxEa1WA9axJCPeOg+DTeO/sHgQmUhqwynozzyb79oZ//Rv8m8ud9/LCbwksF8VpgeQVlxfw7rFxgfKrx+6huM9Ex/12zZFPsQf0L73eNJhw51k9BpJyiGC4i4Rqjs1QB0ljUNIRkLB7MDj3zdHHd6nv7rNaN6JyiYpg1FFm7M5PA+e8uf1LdZKSReHz042R3W8XcSL/9omjFnieNpWkqCICAZ3MpjmkzTUzcbk31OYbkarATVBeWPcou/ek8oSi0lR81k5O9USTCWJclrcPx+7DNnbf/CEIAHCF4ovLc7m32bQbF7P1nBenw== X-MS-Office365-Filtering-Correlation-Id: cf8b3f72-97b4-4681-72fb-08d3d34a3140 X-Microsoft-Exchange-Diagnostics: 1;BL2PR02MB401;2:bCawODEEnMHPCeu0OamGmjTiw7VoFbo97ccYK7AEFjsiEjAafWyV2Vvin/Ka/DvciAqog9/j2o52gV4yUA7ZGCIJ0ZCbT+iEFaag2o6oCeAI+kGSOJ/jw1jHNEOkVu3VSnYONeeIH1NVtUgKAuW0x0XUkkBFe8p3pzEJkKMVw0Cv6m8DiVjOukL6l9JOZIN8;3:8Kk48KZ2JfgaUencV6FuiKU30tgnF43LFba6gf7XVW6Ks28MsQXxHLbQB1WRwRA2QfD0Ox00M3LRrXQN0lf5cuzieRoj+GjTnEBOl1hXdZupE2CyZ4pLbXY2gPbA8AAJSzMs/ie/9P0KxG7ivSdLax0EVno27OdFlkjxdpwYTfRdiEHbW+b/mTYitFpRm3S3KAdDdKxTww+9EgIPUnoHVkLd17z3B9O7fGJqRm5nhGMv8elSPeDlJ4nhE+mRs9/rX4y/sVWjIbgNjdNYynsFug==;25:zM8RCJXUQ+gd3BvviHTBR/PLDouUue2tm9qm+ciOguHZdYTHUOVcuo10QF0guStXGXGUQXHx4UxemD0iKOC6XlpX+4Do2pStcBzpVFQ3HmeT2FsFXML/Fd7kLcnqXt+EoBpeoB4qKqVQAK91r0cP0X/1zSFxzMiVMY0iw0zWNAbtuOW5afek9e0TYIXgA4U3EoRB6Fm/8Sef+3aaekwJPZJuIBY33+BCuP26Eizi3Jlh1nufqFoveFRH0ZdtBhaJ9McrvQ2tp0pSKE5KbqVn6um5QXY4AkFByFnSGN2ZAoqwq84l9x47/9L51Mah566sX2KF7/RWuH8D1SJ0z/reGE9nzQrB6AU3+5SsTum6PeRL2qURKXz9yoBOOtvnV9tO0SQXubOgWjFdLVccLE6vxFO7N9ioOgyEb2+AgpzG3r4= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BL2PR02MB401; X-Microsoft-Exchange-Diagnostics: 1;BL2PR02MB401;31:Bw+/LKemf1/6Z7Jj58gYrOtF9faFbmWtcQK8NbJfIw0Q1sq6Vi0RdGkDtiZsttzSeuPsFSwncbNXymLqkvnbVTIAw8sFL7QS5hmOMbiy6DuWlySVb1VIG8n0eVrGNhs+OJPnBaaFh80BqVIYtde+Y4F0SttKiDIc+/i1QCrnz7w+k7hntsFrBP1k06LzS84PpLRNIP+l2fpPCBguZZbbwmqjdch1AjOHNu1XdTxZcNU=;20:mnroEA00yVj5q/n+U3pXW+oCfO2tuxY+9HTCfsibkl7pJb+eo/mvd7q5D1WlRcOukQvoEEOnUJzX5Jlo/pHxHR+eE22yp/Szk33dZCSI95tVZ74n2HaSAobtFY32wW2JUWAlEw1IU9S85cN/FeKQJfQ0Qgjik7cGdXpRX1l9bMTKXwAVuSNENKSn301AN3fKc3xqKSpfwzdDrrNl8SDqrr0RplP+xosEzojw28BAU11Cnt9l8/MnSy+4Qf+SiSo5yZN/adBKKZoVjsdCXmoX2fUx2+KYSxVYtVeV2swhEUImQIicXWgXN2jxKh6rM0JOUVcXJ1QW+lyWoUBVc675r+y5ZOKYFfI4sOnykpfHH065JYglm5KN/Szz6/L6kXuB2u4nyJf9AAXG+nsDP+8BVBI+gQ/onnRjzTlJtn+goYfCic+Uw8W5+PwiY1jksV9c6DSmciPmJZOsfyk9Rfc688Eae6SGiMNYAbZEw9SVtWRLDmfpi782GXQShxxUOuHp X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(13018025)(13016025)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:BL2PR02MB401;BCL:0;PCL:0;RULEID:;SRVR:BL2PR02MB401; X-Microsoft-Exchange-Diagnostics: 1;BL2PR02MB401;4:jVs9pdKLVKtZ/oT/FIoC4jPj/3btgMR8wnpqqWn7ON8RliSXp+nqk5sKqXbY3NEaSuqNJUoqQ8MxDUxuU5/JaTZIDhL5pcgabZQWJfgl6GzT36hBxHl32qZwcqPXE9/Jk4OjG6lSEtTZOj6/08TR3mXfaBYTK4Cdiw2+BPyhzLR9qf7e0b7yynKd5shk130lnRYr1ZMyHLfp4O5gGHfvTOSc4d++SozMOsitdKphtvGpx8CS770N2Eb6DFV8Lh3i0upJnUV5kdqiZj2BzFe9spx2XoP9qu19wqUqTFOt6tmWxRFgsg4T5rOft4XC2YupPq+fMpgd6XqEgP30KRMJUelJpJ68dR0GepGy+g6G0mnH5/bV99H/JUhDF86CZRy/AWIbqg1pZMKDIEW06/fIQWowCaCRGkJYJ2ybI+UnJ4BfTXJd+hkFbrCvBfuwaRO3 X-Forefront-PRVS: 00531FAC2C X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BL2PR02MB401;23:M7lHmJGiMSQpH2Uww4k+/hSJ7tdynH5DJVvz5P?= =?Windows-1252?Q?er4dSD8/FMM90zHNThWpf2pJ8TRf+dOqJJA/4xCCVxbI05lVOxFEIL5c?= =?Windows-1252?Q?arJ4seQu0Up60VnR7VHbBYXGAttLfj2u/7DnOqZ3Y4d+5VCh43YrdFns?= =?Windows-1252?Q?2JU6sH+2xkFg1HhUcvJ1CT8fsDB2AwBj4sOdZ43XLiG40tLSj7MS3vdp?= =?Windows-1252?Q?9smfk5WcXlsqcFzuYlPdbVNgJKMEatj8YzijyQ9uMZOdAhlZp3Du1+yz?= =?Windows-1252?Q?qz8lvI2mEgl3fzcbJYwpAQ7Jfh/0vAm4hawiBafthBGlMODnbLIMdhyR?= =?Windows-1252?Q?liDegRgH68ws4mj04R5DEdwceTDkEOMUyiEmACUbUyP9enZHOJ0BsyE4?= =?Windows-1252?Q?2a5xehCUjqyPkziA53YFnhA5OQ5+fnLbcetn1qlwkYJHBHxZ3YZMXoqH?= =?Windows-1252?Q?0kDS9w3OQGYbuA3+5ALyKQhFi4wAtpjfOl8nxo9E0gcZ6gHm5cvPT++d?= =?Windows-1252?Q?x1wWirpC9UNj53LKtvHSh6tD5gqQtwDRhUDWgAVwygFUbXW8jnk+bGc4?= =?Windows-1252?Q?VoFwk4RqQUwX8LL6Y0LCLUrIqLgCA1cXNo3UmZNxqsNrEAnfucbxKXCB?= =?Windows-1252?Q?zIKhh0cL38DHNwxOEdl1jPkY5pfSxOQ1TYDrLTuDBO3nZkdsIxJ2h/n6?= =?Windows-1252?Q?KRdX+431pLvFoAuEgoxMT3EQe9/nefDBv58ZxZZRP32RzGZDp96WJ+E0?= =?Windows-1252?Q?9QRt+fxlUYHvtAz9/fC1zYeygYZI02TqCxBUelVYyEVwqjl9KHwGuch3?= =?Windows-1252?Q?BGGqCshRMxTExDEIZ6AYwGz/KfvxwN8F8SqsZriLxtGTS68iFH8TjTTn?= =?Windows-1252?Q?B1x0jjRy4Bk98gmxtvcAo+b8CXMJM1G8nOoyChdwQ38QV8TtxpkNq7Xn?= =?Windows-1252?Q?t2W5BEK37M+rAzTpa+Om0AvD7L1sTUIN4NWVjGmWUBIVkVYyQkDQ/Grz?= =?Windows-1252?Q?LWNU5iJXBepEGKN+hybkqsKt/z46FicCEdlIuzg31Pew2L7qemXoVXAv?= =?Windows-1252?Q?SkRinDw5l6UcaCLL/73AYwrVbO3NrILHNzb/0CE0G4vSDndEkTYPcKt3?= =?Windows-1252?Q?o0nt4oV9Ru1u1C1Rp1dzgbfkthdKt0fRRptEWFhvveqg0F5TP4iGGnWI?= =?Windows-1252?Q?ou1FAQ0jDXEzmmw/mb67QhDAVPjYCTmWbC7maGIcc5ZWjjJX7/Vt1tbg?= =?Windows-1252?Q?gYAGu3MtdEIOxoHL+GSz9RI9EobLXiTZ1ePG0nvBCSws0P6YalPAjpBe?= =?Windows-1252?Q?niF3pywGzDjRxLTtszSVDlNS2hRsP7npwVEAk5E3JuBu/t79eaDH14Mk?= =?Windows-1252?Q?d7CGd94U8yUO9AFNur2maywa9h4fVPAigrgh280wK3XSjle/K0y7mSXp?= =?Windows-1252?Q?Yf00uYDH0vhZKAp6tT?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR02MB401;6:1z3fYZk8OfVEivWlXTMRVA96iOAvtLhAZ5HS7UPsIRQHg3tMwQW3FWcwxjmOw1wGn3YWr7tHoxI0WbENeCm3PtaHMda4ssxBdy0pxKvYfbxOe0R81M7APCWvi7xgxzvNVbfN8WF147KQKienv+bpfD8p0k87OlXYRq6FYAmLfJXYVakHMOtr0K/Y8aw8AXZVUmLLbvQ+8BgcMuCwxWwp+KSe451kenz+GY37Oj+I+tz4iBMA7d8wCLhzaVVtLelxv+PGrvmUjgzaWp877qUTqFtDa6zr69I0CRC7s/MMjMzk78p2vnZZSY+eYilpl8nLXi+H1GtEsdtGCW3gci2vYA==;5:A2bXCThCLu6CPM7rv9IUZbMIkFtjGhRQQCkgTHlk2t+3PjR2QCMBIFR4ROFjmlBHXfE4kdjfFWfMpgg6e4fX26YeVcTyvSQFPh22c2/dN2yz8w1ai8j77CSRUawe1Jl6WoGxXh8JX3YF4vQ+dzKgYA==;24:gHU8vrJt8JPqq5PKkTY1aR/r+r/i3MXlhyns11GxXUuJBimxwERsfdo5ukzrwjLbdi1sdoYGzCG2tp2n2DJI+jdXZyo74baE0DPUkdwF8XY=;7:hFXAszBcimLomBwn23XpeBXHIEQ+iT6V+ZfIYF4fulD0DhdPTuSuSTkwhpSOpGRZbUYyUXH/wrvF74/rkhg2ZidgE1zPdZZgKAcFLMu6f4H8I2docYICmA0WiH9vecGSNTWVYk7EFJPBa6rII2vuYHdSO+rZvYLaLVPRGdmWczzRgZdhyhkCWWALYg8i14T5gDvsDBoBI8hewWlD1m8qA0B3kYhMxGo8bT6BXXm8slr1dxrwpA4BbLru+ks4Kiog SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BL2PR02MB401;20:N1/XyKpje3BrqLyIa7uCSMBdif8FJlqdvohEku2/4A3ds9lnX2wtst9f4Y8RJt8y6GgVF9nxFCUycAEPf5+I6Z/dYn+k/4kKDI8RiAfnMtrzswg2Yr9n0sOLog+XDHha775pwuPmaM7oz3WoXujYzUzVq7uVBo57bBYiadnsfTmMXLClkHQa8pQLxcBsW6oWdhz6Pm+I56U7EhLMy0nBI/w1QLLxmSxa9+K6XlbDjTpp8qRlxZovuLQZKsoqMhiQ X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2016 15:59:58.0964 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.225];Helo=[milsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR02MB401 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/02/2016 08:41 AM, Joe Perches wrote: > On Fri, 2016-09-02 at 13:41 +0000, Bart Van Assche wrote: >> On 09/01/16 17:51, Joe Perches wrote: >>> On Fri, 2016-09-02 at 00:47 +0000, Bart Van Assche wrote: >>>> On 09/01/16 13:11, Joe Perches wrote: >>>>> Assigning an int to a bitfield:1 can lose precision. >>>>> Change the caller argument uses from 1/0 to true/false. >>>> Can you clarify how assigning 0 or 1 to a one-bit bitfield can cause a >>>> loss of precision? >>> There are no existing defects. >>> Using 1/0 is not a loss of precision, it's just >>> changing to use bool avoids potential errors and >>> promotes consistency. >>> Other uses of this function already use true/false. >> In the patch description you refer to loss of precision. However, your >> patch does not address any loss of precision issues. So I think that the >> patch description is misleading and could be made more clear. > > I tend towards terse being better than verbose. > The original patch description says > > "no change to objects" > > What would you suggest? Hello Joe, How about the following: dev_set_uevent_suppress() expects a boolean as second argument. Make this clear by passing true/false instead of 1/0 as the second argument. Bart.