From: Chao Yu <yuchao0@huawei.com>
To: Daeho Jeong <daeho43@gmail.com>, <linux-kernel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>,
<kernel-team@android.com>
Cc: Sungjong Seo <sj1557.seo@samsung.com>,
Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH v3 1/2] f2fs: introduce checkpoint=merge mount option
Date: Mon, 18 Jan 2021 16:51:03 +0800 [thread overview]
Message-ID: <74067d6f-45f8-3c08-1829-828a1aebddee@huawei.com> (raw)
In-Reply-To: <20210116010041.3754050-1-daeho43@gmail.com>
On 2021/1/16 9:00, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> We've added a new mount option "checkpoint=merge", which creates a
> kernel daemon and makes it to merge concurrent checkpoint requests as
> much as possible to eliminate redundant checkpoint issues. Plus, we
> can eliminate the sluggish issue caused by slow checkpoint operation
> when the checkpoint is done in a process context in a cgroup having
> low i/o budget and cpu shares, and The below verification result
> explains this.
Could you please summary and add below info into commit message and f2fs.rst?
"Actually, the default I/O priority of kernel thread is "4". So, we're
going to raise this
priority by one, because we want to give one higher priority for
checkpointing thread
than other normal threads. This is the same way to give a I/O priority
to the jbd2 journaling
thread of ext4 filesystem."
Otherwise this patch looks good to me.
Thanks,
prev parent reply other threads:[~2021-01-18 8:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 1:00 Daeho Jeong
2021-01-18 8:51 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74067d6f-45f8-3c08-1829-828a1aebddee@huawei.com \
--to=yuchao0@huawei.com \
--cc=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®