mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: akpm@linux-foundation.org
Cc: baolin.wang@linux.alibaba.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/5] mm: compaction: Remove redundant VM_BUG_ON() in compact_zone()
Date: Tue, 10 Jan 2023 21:36:18 +0800	[thread overview]
Message-ID: <740a2396d9b98154dba76e326cba5e798b640ead.1673342761.git.baolin.wang@linux.alibaba.com> (raw)
In-Reply-To: <cover.1673342761.git.baolin.wang@linux.alibaba.com>

The compaction_suitable() will never return values other than COMPACT_SUCCESS,
COMPACT_SKIPPED and COMPACT_CONTINUE, so after validation of COMPACT_SUCCESS
and COMPACT_SKIPPED, we will never hit other unexpected case. Thus remove
the redundant VM_BUG_ON() validation for the return values of compaction_suitable().

Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
---
 mm/compaction.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index 62a61de44658..5e6f5e35748d 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -2313,9 +2313,6 @@ compact_zone(struct compact_control *cc, struct capture_control *capc)
 	if (ret == COMPACT_SUCCESS || ret == COMPACT_SKIPPED)
 		return ret;
 
-	/* huh, compaction_suitable is returning something unexpected */
-	VM_BUG_ON(ret != COMPACT_CONTINUE);
-
 	/*
 	 * Clear pageblock skip if there were failures recently and compaction
 	 * is about to be retried after being deferred.
-- 
2.27.0


  reply	other threads:[~2023-01-10 13:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-10 13:36 [PATCH 0/5] Some small improvements for compaction Baolin Wang
2023-01-10 13:36 ` Baolin Wang [this message]
2023-01-10 13:37   ` [PATCH 1/5] mm: compaction: Remove redundant VM_BUG_ON() in compact_zone() Matthew Wilcox
2023-01-10 23:25     ` Andrew Morton
2023-01-10 23:37       ` Matthew Wilcox
2023-01-11  6:40         ` Baolin Wang
2023-01-11 21:51           ` Andrew Morton
2023-01-10 13:36 ` [PATCH 2/5] mm: compaction: Move list validation into compact_zone() Baolin Wang
2023-01-10 13:36 ` [PATCH 3/5] mm: compaction: Count the migration scanned pages events for proactive compaction Baolin Wang
2023-01-10 13:36 ` [PATCH 4/5] mm: compaction: Add missing kcompactd wakeup trace event Baolin Wang
2023-01-10 13:36 ` [PATCH 5/5] mm: compaction: Avoid fragmentation score calculation for empty zones Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=740a2396d9b98154dba76e326cba5e798b640ead.1673342761.git.baolin.wang@linux.alibaba.com \
    --to=baolin.wang@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®