From: Dan Carpenter <dan.carpenter@linaro.org>
To: Aaron Conole <aconole@redhat.com>
Cc: William Tu <u9012063@gmail.com>,
dev@openvswitch.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [ovs-dev] [PATCH net] net: ovs: prevent underflow in queue_userspace_packet()
Date: Mon, 27 Jan 2025 11:08:51 +0300 [thread overview]
Message-ID: <740fcd03-9c02-4911-8165-a912a97a6556@stanley.mountain> (raw)
In-Reply-To: <f7th65nhggd.fsf@redhat.com>
On Fri, Jan 24, 2025 at 07:42:26PM -0500, Aaron Conole wrote:
> Dan Carpenter <dan.carpenter@linaro.org> writes:
>
> > If "hlen" less than "cutlen" then when we call upcall_msg_size()
> > the "hlen - cutlen" parameter will be a very high positive
> > number.
> >
> > Later in the function we use "skb->len - cutlen" but this change
> > addresses that potential underflow since skb->len is always going to
> > be greater than or equal to hlen.
> >
> > Fixes: f2a4d086ed4c ("openvswitch: Add packet truncation support.")
> > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> > ---
> > From code review not testing.
>
> I think it's pretty difficult to trigger this case. 'cutlen' will only
> be set by a TRUNC action attribute, which does a length check there.
>
Ah. Yes. You're right. I assumed that since we neede to do a upper
bounds check on skb->len then probably the lower bounds needed to be
checked too but that's not correct. My bad. No need to do anything
here because the code is fine as-is.
net/openvswitch/actions.c
1402 case OVS_ACTION_ATTR_TRUNC: {
1403 struct ovs_action_trunc *trunc = nla_data(a);
1404
1405 if (skb->len > trunc->max_len)
1406 OVS_CB(skb)->cutlen = skb->len - trunc->max_len;
1407 break;
1408 }
regards,
dan carpenter
prev parent reply other threads:[~2025-01-27 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 14:49 Dan Carpenter
2025-01-25 0:42 ` [ovs-dev] " Aaron Conole
2025-01-27 8:08 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=740fcd03-9c02-4911-8165-a912a97a6556@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®