Re: [PATCH v2] hwmom/applesmc: add imacpro

[Guenter Roeck <linux@roeck-us.net>]

Hi Aditya,

On 1/29/25 10:22, Aditya Garg wrote:
> Hi Guenter
> 
> Sorry to barge in like that but I have some issues with this here.
> 

No worries. Thanks for stepping in.

> 1. The iMacPro1,1 is a T2 Mac and the applesmc driver does not support T2 Macs upstream, thus making no point of adding this. We at t2linux have downstream patches to support T2 Macs, but we do not aim to upstream them since we wish to use a separate, and better driver for the SMC on T2 Macs.
> 
> 2. The person who submitted the patch took it from the t2linux project, of which I am a part of, but didn't care to even credit the original author of the patch. I’m not sure how legal it is to redistribute the code in his own name and removing the original author’s name without taking permission from the author as per the GPL2 license, but I think the author should be credited. In fact the original patch was Signed-off-by the original author.
> 
> For reference, the original patch, which we never intended to be sent upstream, is given over here:
> 
> https://github.com/t2linux/linux-t2-patches/blob/main/3007-applesmc-Add-iMacPro-to-applesmc_whitelist.patch
> 

FWIW, that patch looks much better than this patch.

I am a bit confused, though: You are saying above that the patch is pointless.
Is that because context patches adding support for T2 are missing ?

Also, what about the patch at [1] ? It also adds t2 specific functionality,
and it seems to match another patch from the t2linux project.
Is that also missing some context ?

> I leave the fate of this to you now.
> 

Thanks for letting me know. I dropped the patch. I'll also wait for your feedback
about the patch at [1] before looking into it further.

Thanks,
Guenter

---
[1] https://patchwork.kernel.org/project/linux-hwmon/patch/20250120183343.3494-1-evepolonium@gmail.com/