From: bot+bpf-ci@kernel.org
To: malin89@huawei.com,ast@kernel.org,daniel@iogearbox.net,bpf@vger.kernel.org
Cc: andrii@kernel.org,john.fastabend@gmail.com,martin.lau@linux.dev,eddyz87@gmail.com,memxor@gmail.com,song@kernel.org,yonghong.song@linux.dev,jolsa@kernel.org,zhuyifei@google.com,shuah@kernel.org,linux-kselftest@vger.kernel.org,linux-kernel@vger.kernel.org,ameryhung@gmail.com,malin89@huawei.com,cuirongzhen@huawei.com,tanjingguo@huawei.com,cenxianlong@huawei.com,chenzhe@huawei.com,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,clm@meta.com,ihor.solodrai@linux.dev
Subject: Re: [PATCH v3 2/2] selftests/bpf: Cover tail-call cgroup storage prog-array checks
Date: Thu, 4 Jun 2026 01:50:17 +0000 (UTC) [thread overview]
Message-ID: <74147fc81dc525aa48190b5390b1fd7a1b64ff882402ca93eb4f1dadce6a3528@mail.kernel.org> (raw)
In-Reply-To: <20260604005729.1992632-2-malin89@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1717 bytes --]
> diff --git a/tools/testing/selftests/bpf/prog_tests/tailcalls.c b/tools/testing/selftests/bpf/prog_tests/tailcalls.c
> index 7d534fde0af9..f8c4b569da95 100644
> --- a/tools/testing/selftests/bpf/prog_tests/tailcalls.c
> +++ b/tools/testing/selftests/bpf/prog_tests/tailcalls.c
[ ... ]
> @@ -1777,6 +1928,14 @@ void test_tailcalls(void)
> test_tailcall_freplace();
> if (test__start_subtest("tailcall_bpf2bpf_freplace"))
> test_tailcall_bpf2bpf_freplace();
> + if (test__start_subtest("tailcall_cgrp_storage"))
> + test_tailcall_cgrp_storage();
> + if (test__start_subtest("tailcall_cgrp_storage_diff_storage"))
> + test_tailcall_cgrp_storage_diff_storage();
> + if (test__start_subtest("tailcall_cgrp_storage_no_storage"))
> + test_tailcall_cgrp_storage_no_storage();
> + if (test__start_subtest("tailcall_cgrp_storage_no_storage_bridge"))
> + test_tailcall_cgrp_storage_no_storage_bridge();
> if (test__start_subtest("tailcall_failure"))
> test_tailcall_failure();
> if (test__start_subtest("tailcall_sleepable"))
> test_tailcall_sleepable();
In the v2 review Leon Hwang asked that these new subtests be placed at the
tail of test_tailcalls():
https://lore.kernel.org/bpf/20260603150213.68746-1-leon.hwang@linux.dev/
"These new ones should stay at the tail of test_tailcalls()."
Here they are still registered ahead of tailcall_failure and
tailcall_sleepable rather than at the end. Was the intent to move them
after the existing subtests?
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/26923843925
next prev parent reply other threads:[~2026-06-04 1:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 0:57 [PATCH v3 1/2] bpf: Tighten cgroup storage cookie checks for prog arrays Lin Ma
2026-06-04 0:57 ` [PATCH v3 2/2] selftests/bpf: Cover tail-call cgroup storage prog-array checks Lin Ma
2026-06-04 1:50 ` bot+bpf-ci [this message]
2026-06-04 1:50 ` [PATCH v3 1/2] bpf: Tighten cgroup storage cookie checks for prog arrays bot+bpf-ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74147fc81dc525aa48190b5390b1fd7a1b64ff882402ca93eb4f1dadce6a3528@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cenxianlong@huawei.com \
--cc=chenzhe@huawei.com \
--cc=clm@meta.com \
--cc=cuirongzhen@huawei.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=malin89@huawei.com \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=tanjingguo@huawei.com \
--cc=yonghong.song@linux.dev \
--cc=zhuyifei@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®