mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH] serial: Remove duplicated macro definition of port type
Date: Mon, 11 May 2020 08:40:37 +0200	[thread overview]
Message-ID: <74173351-9d43-07fc-30c4-3c5aab72dcd0@suse.cz> (raw)
In-Reply-To: <1588853015-28392-1-git-send-email-yangtiezhu@loongson.cn>

On 07. 05. 20, 14:03, Tiezhu Yang wrote:
> There exists the same macro definition of port type from 0 to 13
> in include/uapi/linux/serial.h, remove these duplicated code in
> include/uapi/linux/serial_core.h which includes the former header.
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

Acked-by: Jiri Slaby <jslaby@suse.cz>

> ---
>  include/uapi/linux/serial_core.h | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/include/uapi/linux/serial_core.h b/include/uapi/linux/serial_core.h
> index 8ec3dd7..851b982 100644
> --- a/include/uapi/linux/serial_core.h
> +++ b/include/uapi/linux/serial_core.h
> @@ -26,20 +26,6 @@
>  /*
>   * The type definitions.  These are from Ted Ts'o's serial.h
>   */
> -#define PORT_UNKNOWN	0
> -#define PORT_8250	1
> -#define PORT_16450	2
> -#define PORT_16550	3
> -#define PORT_16550A	4
> -#define PORT_CIRRUS	5
> -#define PORT_16650	6
> -#define PORT_16650V2	7
> -#define PORT_16750	8
> -#define PORT_STARTECH	9
> -#define PORT_16C950	10
> -#define PORT_16654	11
> -#define PORT_16850	12
> -#define PORT_RSA	13
>  #define PORT_NS16550A	14
>  #define PORT_XSCALE	15
>  #define PORT_RM9000	16	/* PMC-Sierra RM9xxx internal UART */
> 

thanks,
-- 
js
suse labs

  reply	other threads:[~2020-05-11  6:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07 12:03 Tiezhu Yang
2020-05-11  6:40 ` Jiri Slaby [this message]
2020-07-06  9:01   ` Tiezhu Yang
2020-07-06 12:03     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74173351-9d43-07fc-30c4-3c5aab72dcd0@suse.cz \
    --to=jslaby@suse.cz \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lixuefeng@loongson.cn \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®