mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Eric Dumazet <edumazet@google.com>, Kees Cook <kees@kernel.org>,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ref_tracker: use %p instead of %px in debugfs dentry name
Date: Tue, 05 Aug 2025 16:39:50 -0400	[thread overview]
Message-ID: <741ba76709df27536a278412d00ddb1d52a25cdb.camel@kernel.org> (raw)
In-Reply-To: <20250731071355.2da07d06@kernel.org>

On Thu, 2025-07-31 at 07:13 -0700, Jakub Kicinski wrote:
> On Thu, 31 Jul 2025 07:57:05 -0400 Jeff Layton wrote:
> > As Kees points out, this is a kernel address leak, and debugging is
> > not a sufficiently good reason to expose the real kernel address.
> > 
> > Fixes: 65b584f53611 ("ref_tracker: automatically register a file in debugfs for a ref_tracker_dir")
> > Reported-by: Kees Cook <kees@kernel.org>
> > Closes: https://lore.kernel.org/netdev/202507301603.62E553F93@keescook/
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> > I trust that Kees is right here, so let's go ahead and fix this. I gave
> > this a quick build and boot this morning and it did the right thing.
> 
> Assuming Andrew will take this one since you haven't cced netdev@ ..

Ahh yeah, it wasn't net/ specific so I didn't think to add netdev.
Andrew, would you mind picking this one up?

Thanks,
-- 
Jeff Layton <jlayton@kernel.org>

  reply	other threads:[~2025-08-05 20:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-31 11:57 Jeff Layton
2025-07-31 14:13 ` Jakub Kicinski
2025-08-05 20:39   ` Jeff Layton [this message]
2025-07-31 16:32 ` Kees Cook
2025-07-31 19:01   ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=741ba76709df27536a278412d00ddb1d52a25cdb.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=edumazet@google.com \
    --cc=kees@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®