From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94F6234889F for ; Tue, 16 Jun 2026 15:26:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781623580; cv=none; b=se1e1AgAxsLZXweLr6kPseI+juea6B6Zp2qybU81vuEMmrRyncXnNtq7ImeJgUCmU74pmgykP25XR58uyz/en1N8FepXEFxCLE6Hn+NALr4nXziLPfAuAtDQlrynqxfr4LE11ovoILQ2Hw5dJbK+EPieOp7UCYd1RBqC6UcYDio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781623580; c=relaxed/simple; bh=c70ejIA1HHPGti0LlpJc+AUieY8UjrbXfOG5k/75a0U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g0EY1IBb86NDWPv64yWvjpI6Fo5Jng2QPIz0xAuO4L9gCxyNzECDpj2Msxiw63ViYm2YbCXvc6k1a2Ue7DseE1UAWiatBOK9YVJ/NX1Fdoi12p5mIZfWkOzuZRodpVQakvqjx1BSWTDYyCDslz3CpBZ6PkEPnEoLKYNuyKg324E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I3YzBpy4; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I3YzBpy4" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-30bc871ecdfso4674eec.1 for ; Tue, 16 Jun 2026 08:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781623579; x=1782228379; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=f7vROs9UN075gs/8U/5ZvrOcUcap23dqy0WHrqzNyCg=; b=I3YzBpy48d+HYg6vJjd8ZuRQG7xCwP1LDIp+1hVpLCKoks2h1JkouCUFCc8HYzWlPn ljfSdQqPpXbeOL0t/qxgFkOQxFsRQgCXhXs0c1yt5UH+1c/3utBogIv/MOT/RBG//gIg s3BcN/c8zcVEzf70jLocFlPWs9laboRdMr8ViFH2NYVwwowNXrua4OpBDSlzKZy+2vB0 C5C/fcv2Kflc2+KuDWTgVIjdOYpSJqlsD9+OYxG5GBw7nmFeZ/3oGmnPseeep08o83IQ de0tSLhncIHmRNsm6EFiSwPM0pt4e4hzjJkG/VLl1FXI1xKHd8rPcJDxkobN0pHqzB/i lQsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781623579; x=1782228379; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f7vROs9UN075gs/8U/5ZvrOcUcap23dqy0WHrqzNyCg=; b=VmANQbg92KLZw0aOQbhQldFM3A/xDJJqwuN5+uXExdrB+TTGFFLDZLsM5PPEn7t8dc YO68SYSctfVzquoeCek1brgqhjSjwWX2ruOAlIImA6tfnhA3wIoBjrIeq+a0s8Ey9XKY wV4xMDIo+q2oLXAlUFj8RmPvPbpQ2JcLDprDgvwOPELcbVaIXfQ7PG6YITYl7+XMSff5 rNBp12R1UdJ+qU37ZmZbXFYpjV1ObEjvWNFMpg4YP8mpwyIm7mqfdpEgsf07K69JA8MP i+MTPP1kK1eMIsNvFNQjGopMuTKvZoEMj94sYtjwPOnezt+wILiZDpcNNVDP8SLDuYc2 GJMA== X-Forwarded-Encrypted: i=1; AFNElJ/TAACzTV6A/+wwfjff/WWlwz6sBy8xgwsEVf2SBjPQxHqPC/SrhVDtw55MYpwEbYXD250NTJFiBQ0ZDFg=@vger.kernel.org X-Gm-Message-State: AOJu0YxAhOdCu08BqlgIajkobZ3lHklWuj8KMQ30R3Wt0jdVZaKFAoIS 5Z99QzeQ43w3Ym6Az4u43A0MrIB34R+hANnFEep6kh+v9zmXLQgGpMBf X-Gm-Gg: Acq92OHvDoCE6p4c7v08oM4+H7POdwmZ7ovYTvxwoK/A/Z/xZB5MYVMlfNA9pMIynjt o/BiPdtTUeyKpGTKvWMBDgn8uYQ7oamoKBLu8faeE8qifcAZcAabfSybNC+bXWLVWTUuVMIkYA+ UtV1x+hCyRVVFvzJIHdJho6h2BgGGx2AhuYOniq+TJsiVl/uuBfahV8XzdS5q3cmf5JD4aW28dh ZglEfGHgoshWBDCihR7yPIUA0OkWpr7L5vo90K/b3KlFvvjaRVBsegvma/J4gSWPhhxyg50nrSS 9NYfdt+42+FrK5WVjWDHMeD0Dha28O4E5VIo/VY6BJDMbBhvoOLaCqbWrsSeRsyUySQpB5u+OK/ kT3pi2s5UL5Wk0/qTK8b7XuzJ9kX4L76N8veYsaA3hL2JB1/Ync3wCArbYv8vuyQ27fDjefXaSe Jg9o86wRq8RrkOeDAlAO6oHgfcIx+KkSM= X-Received: by 2002:a05:7300:7b95:b0:2d9:6373:ad24 with SMTP id 5a478bee46e88-30ba5f7020emr2626182eec.26.1781623576725; Tue, 16 Jun 2026 08:26:16 -0700 (PDT) Received: from geday ([189.115.92.220]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e5d0357sm18116553eec.11.2026.06.16.08.26.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 08:26:16 -0700 (PDT) Date: Tue, 16 Jun 2026 12:26:10 -0300 From: Geraldo Nascimento To: Shawn Lin , Dragan Simic Cc: linux-rockchip@lists.infradead.org, Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Geraldo Nascimento Subject: [PATCH v7 3/3] PCI: rockchip: drive at 2.5 GT/s, error other speeds Message-ID: <7421df7a7b7778ee99363cccfdfabbfa8aa6ab5e.1781622998.git.geraldogabriel@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Configure the core to be driven at 2.5 GT/s Link Speed and ignore any other speed with a warning. Also drop the 5.0 GT/s Link Speed defines from Rockchip PCIe header. The reason is that Shawn Lin from Rockchip has reiterated that there may be danger of "catastrophic failure" in using their PCIe with 5.0 GT/s speeds. While Rockchip has done so informally without issuing a proper errata, and the particulars are thus unknown, this may cause data loss or worse. This change is corroborated by RK3399 official datasheet [1], which states maximum link speed for this platform is 2.5 GT/s. [1] https://opensource.rock-chips.com/images/d/d7/Rockchip_RK3399_Datasheet_V2.1-20200323.pdf Fixes: 956cd99b35a8 ("PCI: rockchip: Separate common code from RC driver") Link: https://lore.kernel.org/all/ffd05070-9879-4468-94e3-b88968b4c21b@rock-chips.com/ Cc: stable@vger.kernel.org Reported-by: Dragan Simic Reported-by: Shawn Lin Signed-off-by: Geraldo Nascimento --- drivers/pci/controller/pcie-rockchip.c | 14 ++++++-------- drivers/pci/controller/pcie-rockchip.h | 3 --- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip.c b/drivers/pci/controller/pcie-rockchip.c index 0f88da3788054..456dcfd676ed7 100644 --- a/drivers/pci/controller/pcie-rockchip.c +++ b/drivers/pci/controller/pcie-rockchip.c @@ -66,8 +66,10 @@ int rockchip_pcie_parse_dt(struct rockchip_pcie *rockchip) } rockchip->link_gen = of_pci_get_max_link_speed(node); - if (rockchip->link_gen < 0 || rockchip->link_gen > 2) - rockchip->link_gen = 2; + if (rockchip->link_gen < 0 || rockchip->link_gen >= 2) { + rockchip->link_gen = 1; + dev_warn(dev, "invalid max-link-speed, limited to 2.5 GT/s\n"); + } for (i = 0; i < ROCKCHIP_NUM_PM_RSTS; i++) rockchip->pm_rsts[i].id = rockchip_pci_pm_rsts[i]; @@ -147,12 +149,8 @@ int rockchip_pcie_init_port(struct rockchip_pcie *rockchip) goto err_exit_phy; } - if (rockchip->link_gen == 2) - rockchip_pcie_write(rockchip, PCIE_CLIENT_GEN_SEL_2, - PCIE_CLIENT_CONFIG); - else - rockchip_pcie_write(rockchip, PCIE_CLIENT_GEN_SEL_1, - PCIE_CLIENT_CONFIG); + rockchip_pcie_write(rockchip, PCIE_CLIENT_GEN_SEL_1, + PCIE_CLIENT_CONFIG); regs = PCIE_CLIENT_ARI_ENABLE | PCIE_CLIENT_CONF_LANE_NUM(rockchip->lanes); diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/controller/pcie-rockchip.h index 3e82a69b9c006..b5da15601b585 100644 --- a/drivers/pci/controller/pcie-rockchip.h +++ b/drivers/pci/controller/pcie-rockchip.h @@ -42,7 +42,6 @@ #define PCIE_CLIENT_MODE_RC HWORD_SET_BIT(0x0040) #define PCIE_CLIENT_MODE_EP HWORD_CLR_BIT(0x0040) #define PCIE_CLIENT_GEN_SEL_1 HWORD_CLR_BIT(0x0080) -#define PCIE_CLIENT_GEN_SEL_2 HWORD_SET_BIT(0x0080) #define PCIE_CLIENT_LEGACY_INT_CTRL (PCIE_CLIENT_BASE + 0x0c) #define PCIE_CLIENT_INT_IN_ASSERT HWORD_SET_BIT(0x0002) #define PCIE_CLIENT_INT_IN_DEASSERT HWORD_CLR_BIT(0x0002) @@ -197,8 +196,6 @@ (((x) & PCIE_CORE_PL_CONF_LS_MASK) == PCIE_CORE_PL_CONF_LS_READY) #define PCIE_LINK_UP(x) \ (((x) & PCIE_CLIENT_LINK_STATUS_MASK) == PCIE_CLIENT_LINK_STATUS_UP) -#define PCIE_LINK_IS_GEN2(x) \ - (((x) & PCIE_CORE_PL_CONF_SPEED_MASK) == PCIE_CORE_PL_CONF_SPEED_5G) #define RC_REGION_0_ADDR_TRANS_H 0x00000000 #define RC_REGION_0_ADDR_TRANS_L 0x00000000 -- 2.54.0