From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CA30C61D97 for ; Fri, 24 Nov 2023 10:40:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345598AbjKXKkY (ORCPT ); Fri, 24 Nov 2023 05:40:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345599AbjKXKkV (ORCPT ); Fri, 24 Nov 2023 05:40:21 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54EDC1AE for ; Fri, 24 Nov 2023 02:40:28 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0480C433C7; Fri, 24 Nov 2023 10:40:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700822428; bh=y+1TDiBAnMt4VxdCKGR5QS2biqH47tvAiQJ9i4yez2Y=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=p/qa+RJdm7WokbrVvywi9obaB050hb9y0zng38ZwWloP45PRz9232CjxOYzodFL8L gRibElH+QG/dcvyBOrWEQED3vZjkhgtvRO5jbcTTOzHXl8kJR/SHt51HgicJgDeK6t FnC5SWQYnR15tJhpZFgGipbCieJveCjAfpWuZzbnyF8RPh5dDt99LCC65nIFbYNSp6 FiGYFMdrKwQ+xpUTiO5gbQVwNBlfKEcl39Y3h01GRO/KwBKd71tFV3ohenFQK4m8d0 RyxAnwN1W8Rv+7n6JjcXMwcWRNcuP1XBOes1rA1hxsvmlCZYCapgbcKHVP/vT17+SO ojiNCUBS7DoLg== Message-ID: <74226af80ecee1c3544c1bcf66565514.mripard@kernel.org> Date: Fri, 24 Nov 2023 10:40:25 +0000 From: "Maxime Ripard" To: "Dmitry Osipenko" Subject: Re: [PATCH v18 05/26] drm/shmem-helper: Remove obsoleted is_iomem test In-Reply-To: <20231029230205.93277-6-dmitry.osipenko@collabora.com> References: <20231029230205.93277-6-dmitry.osipenko@collabora.com> Cc: dri-devel@lists.freedesktop.org, kernel@collabora.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, "Boris Brezillon" , "Chia-I Wu" , =?utf-8?b?Q2hyaXN0aWFuIEvDtm5pZw==?= , "Daniel Vetter" , "David Airlie" , "Emma Anholt" , "Gerd Hoffmann" , "Gurchetan Singh" , "Maarten Lankhorst" , "Maxime Ripard" , "Melissa Wen" , "Qiang Yu" , "Steven Price" , "Thomas Zimmermann" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Oct 2023 02:01:44 +0300, Dmitry Osipenko wrote: > Everything that uses the mapped buffer should be agnostic to is_iomem. > The only reason for the is_iomem test is that we're setting shmem->vaddr > to the returned map->vaddr. Now that the shmem->vaddr code is gone, remove > the obsoleted is_iomem test to clean up the code. >=20 >=20 > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime