From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755152AbbKCQqS (ORCPT ); Tue, 3 Nov 2015 11:46:18 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:50063 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751984AbbKCQqO convert rfc822-to-8bit (ORCPT ); Tue, 3 Nov 2015 11:46:14 -0500 From: Arnd Bergmann To: Michael =?ISO-8859-1?Q?B=FCsch?= Cc: netdev@vger.kernel.org, Kalle Valo , linux-kernel@vger.kernel.org, zajec5@gmail.com, Nicolas Ferre , Alexandre Belloni , Jean-Christophe Plagniol-Villard Subject: Re: [PATCH] ssb: mark ssb_bus_register as __maybe_unused Date: Tue, 03 Nov 2015 17:42:26 +0100 Message-ID: <7423389.1hNz9LlOCE@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151103172721.04533081@wiggum> References: <5928552.0ccybX7Zly@wuerfel> <20151103172721.04533081@wiggum> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" X-Provags-ID: V03:K0:p4Bc79jtTa4z/0Gt5/WfHgbhOGDuenEwu9T4bWRvpLYeTfQbdB6 bePzlKxg3brm18fy2NIvaPROdwCd3oD/X7K4+StiGXGN8IJT+pj1ZuYD4vIm/EtEqwZX2OE JECHhDpBlCiRRVfvHtcrVjQo58810tR213TRbrFKQ9JIkwIOI5AA+aHhnMoZ3nstZwCMT7B ljeytehJ8e7e5tk0a0Z4g== X-UI-Out-Filterresults: notjunk:1;V01:K0:ZfyX85768Ko=:QHdNogfeedGD0qnTk8gGmJ OqXnNH5IaYNdxTTkoqXxpdniAoixr6BrZDZT5xKISeWLf2zPsZbYALiXdj5p3GD4sVbY3Yflf f/nVd31emx/9GBE63rmHDORqL2t54xoVhj/c6FYS7iEOx3KS4Y3CqdNYOAsIVepz0Krnkl7Fl G8IPexQfJIZQ7FAoyc3tsd8YsWv5avMfA2QOAonxPZKGvEOVcp5paTS0pvUFqykmefUVxndd/ IBECWm1Gl/Qi92BnkGesqRVdIvxEF1nBIjSZJzQUYc2eUWeAcIptS2qRy2jD+Aj2AETj+wgHN WSz4deHAUHluI3AzNHjOWXYop9sRYtHQ72sZiybadUo0iPMF5upVXovtr4BlPNNHWvf+oGdQd v1sOtcZ1sY2jJC7tsGwsCOqui0bv/V3CRPi/fMKciEmW249In8vAxGuOdcuTQzR8/Rb7miyXj eteuKBQ9j8PFf94jJxl3hwW8JA6A8Z2CpaONY1ecAlZ10u3bOwBndowqq+J6Kdyl/AtHMYgKh OiaVinpo1dAbIi5t45Oa4vPdyFhseVK7+pb38CAiOJyJzKz/Rvh5c8uFd5WPHma8jC2UW7q+w tWyVe5QabDUQYwk3k1klrbJ0wB4/CjfXeX8KlK+4ISJVB+t+Eq06saqjiZ6WyuvW5BAz24l7F a8aw7UONn6az+Dlle+JRZY0LsWoT9dyuOpvpSbS6lcYvNBvguhtL+xjyE33h8EE0wmz7Tbu7s eOtC0o6NLteszawu Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 03 November 2015 17:27:21 Michael Büsch wrote: > On Tue, 03 Nov 2015 16:05:51 +0100 > Arnd Bergmann wrote: > > > The SoC variant of the ssb code is now optional like the other > > ones, which means we can build the framwork without any > > front-end, but that results in a warning: > > > > drivers/ssb/main.c:616:12: warning: 'ssb_bus_register' defined but not used [-Wunused-function] > > > > This annotates the ssb_bus_register function as __maybe_unused to > > shut up the warning. A configuration like this will not work on > > any hardware of course, but we still want this to silently build > > without warnings if the configuration is allowed in the first > > place. > > > Is there a simple way to disallow this configuration? I could not come up with a simple one. We could turn 'CONFIG_SSB' into a silent option and have it selected by each bus specific driver, but then we also have to change all the device drivers (usb and wireless I guess) to use 'depends on' rather than 'select'. Arnd