From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Clément Léger" <clement.leger@bootlin.com>,
"Sergey Shtylyov" <s.shtylyov@omp.ru>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Wong Vee Khee" <veekhee@apple.com>,
"Kurt Kanzenbach" <kurt@linutronix.de>,
"Revanth Kumar Uppala" <ruppala@nvidia.com>,
"Tan Tee Min" <tee.min.tan@linux.intel.com>
Cc: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Herve Codina" <herve.codina@bootlin.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Milan Stevanovic" <milan.stevanovic@se.com>,
"Jimmy Lalande" <jimmy.lalande@se.com>,
"Pascal Eberhard" <pascal.eberhard@se.com>,
"Mohammad Athari Bin Ismail" <mohammad.athari.ismail@intel.com>,
"Jon Hunter" <jonathanh@nvidia.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v2 6/6] ARM: dts: r9a06g032: describe GMAC1
Date: Wed, 8 Feb 2023 20:54:28 +0100 [thread overview]
Message-ID: <74240c25-cbbe-1e72-b56b-13124111b390@linaro.org> (raw)
In-Reply-To: <20230208164203.378153-7-clement.leger@bootlin.com>
On 08/02/2023 17:42, Clément Léger wrote:
> RZ/N1 SoC includes two MAC named GMACx that are compatible with the
> "snps,dwmac" driver. GMAC1 is connected directly to the MII converter
> port 1. Since this MII converter is represented using a PCS driver, it
> uses the renesas specific compatible driver which uses this PCS.
>
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> ---
> arch/arm/boot/dts/r9a06g032.dtsi | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi
> index 41e19c0986ce..ba32e4429b01 100644
> --- a/arch/arm/boot/dts/r9a06g032.dtsi
> +++ b/arch/arm/boot/dts/r9a06g032.dtsi
> @@ -304,6 +304,24 @@ dma1: dma-controller@40105000 {
> data-width = <8>;
> };
>
> + gmac1: ethernet@44000000 {
> + compatible = "renesas,r9a06g032-gmac", "renesas,rzn1-gmac", "snps,dwmac";
Please test your DTS against the binding you send. If you did it, you
would see here that the binding does not work and needs fixes... The
difference between your DTS and your example should also warn you that
it's not correct.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-02-08 19:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 16:41 [PATCH net-next v2 0/6] net: stmmac: add renesas,rzn1-gmac support Clément Léger
2023-02-08 16:41 ` [PATCH net-next v2 1/6] net: pcs: rzn1-miic: add pcs_early_setup() function Clément Léger
2023-02-08 16:41 ` [PATCH net-next v2 2/6] net: stmmac: add support to use a generic phylink_pcs as PCS Clément Léger
2023-02-08 16:42 ` [PATCH net-next v2 3/6] net: stmmac: add support to provide pcs from platform data Clément Léger
2023-02-08 18:21 ` Sergey Shtylyov
2023-02-08 16:42 ` [PATCH net-next v2 4/6] dt-bindings: net: renesas,rzn1-gmac: Document RZ/N1 GMAC support Clément Léger
2023-02-08 19:51 ` Krzysztof Kozlowski
2023-02-08 16:42 ` [PATCH net-next v2 5/6] net: stmmac: add support for RZ/N1 GMAC Clément Léger
2023-02-09 16:51 ` Russell King (Oracle)
2023-02-08 16:42 ` [PATCH net-next v2 6/6] ARM: dts: r9a06g032: describe GMAC1 Clément Léger
2023-02-08 19:54 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74240c25-cbbe-1e72-b56b-13124111b390@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexandre.torgue@foss.st.com \
--cc=clement.leger@bootlin.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=herve.codina@bootlin.com \
--cc=jimmy.lalande@se.com \
--cc=joabreu@synopsys.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=milan.stevanovic@se.com \
--cc=miquel.raynal@bootlin.com \
--cc=mohammad.athari.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pascal.eberhard@se.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=ruppala@nvidia.com \
--cc=s.shtylyov@omp.ru \
--cc=tee.min.tan@linux.intel.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=veekhee@apple.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®