From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1034F308F23 for ; Thu, 20 Nov 2025 09:10:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763629854; cv=none; b=PgGA6LV3dOLSwczH6pLcbMZAvbMjPHWJAjj572zICyjdbXt6/lTh+1PmFKqH7SzOPlJX81hS7fN8E1Qdh2GBuKFB0NG1w04/ZeNfw/tyV2GWR46SF1+r21BfIv5zZG/4mis8wlu7RQcFxhXLIdl1vhpOhSWfOOsTu3mKkSkWx+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763629854; c=relaxed/simple; bh=3k/hpt0zWDZEdbH5f9htoUyNMHnXEPG4eUskvlsflfs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mVrpG8zhFHYyUmZWA0S5uP9xMpYWQtwDneWDLzmiKX0X+cOJbS9ILoumn5t9j8lGpudYLrz8vUjI9Z75stlyrHmfc0oVtw3Ud8PPu+q9lBtkSBPCm7RLjQR+hQtg6ae36E1gYCiTRetNF7lPXJK0uh2WwBcV7jPNjMOjDoD7bQU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DxcW7vT4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LNJV6Zk2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DxcW7vT4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LNJV6Zk2" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AK4pbVs3720008 for ; Thu, 20 Nov 2025 09:10:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wyimCKeiXS1yx9KrEd+oZ745tjyNxb635bpLRIP4Mxo=; b=DxcW7vT4MB9IwqbH 7VDvC1qKTzQxjJCnCd9apJAHoi80JLc5ZVQhYa/+YzmS28gpYiEaS4hwGL+bf03T p+RRjB/d9YLa5PkwVsAs77w+NTuyGUDiG9777CTO2tEDKSyjzDkPWUVOKTNiUOdn UbsbL31/taj+FpE+dITLoITiJStEkf0Wp1t9Y35GfdfkMDlh6UYBP75vpP4glRJJ ZeoS5T9fWVYVy1imzLxeXEJZVhA9KCsZGt0ijb5KnEXphuIKa7LTE705Iiq0nuub HP1BtuLQr2LNsBCjqLT9APuUKC7jm9j0qYPYC9WrZzbzlMJvaTxVcUX+qRlC7NF6 Pwch0A== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ahqb0hm9u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 20 Nov 2025 09:10:52 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ee05927183so1899071cf.0 for ; Thu, 20 Nov 2025 01:10:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763629851; x=1764234651; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wyimCKeiXS1yx9KrEd+oZ745tjyNxb635bpLRIP4Mxo=; b=LNJV6Zk2qsSGcMcOpFACHWkb60EwGj+Ulo8AysX6FrObyr2UpNvugQv7EHaxSnP6Jw rHA/4Id9VgENaTnIW4TJl4E8Q2N9/MaLRmhjgjuwChEYQZq5GTq9odpzklbVk9RD2QpF BBcuZN7p85L6dnKDgfFOQZY0od6g6u+Tpf7SrEeyQYDMzClorKyUVL2jFDU3xgZYXLFb /DvBiHXUjktfeWSXbjHjSvK/HtX73RRtCIn+na7jsmo/saeq7qRM541PhLqMI/R02UHs sUyt99iPPo6J6jDTTFI46NZDYyQbN2gzr8eU1OsYkdwbHaqd0sTIl7F3UU+oLADXiQsb uS6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763629851; x=1764234651; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wyimCKeiXS1yx9KrEd+oZ745tjyNxb635bpLRIP4Mxo=; b=ccu1SSRQ25K+hhkP7xoZueiqaflHW+SF+gjkalx6GAQmsTMCK5VcAH4EDy28XkaTJR p94/mo07NDr6TkbP7qWuOlLM23Z6g6/USYGrSbdUVAe4KSKad/GO1DdVzmAYjSvRN2XX PgJbXwi1+PUsOS21VBqM2agFd221lBAYSJBv1yWtagQO+8CiO0rcqnkt7XZRnzcYwWKa q7k3hfyZ/hj78zEoE02bH1DGZbpqNLOpsPfjelKKxmvgMwbOgwy3um4pVa6Ert3s7/zF 3bSelYdcXv0yMAY1izqAawfG0z2xgLlGnF/CEC73PAktQsuAotGxugjmnjzaw6Nb2oUd wOpg== X-Forwarded-Encrypted: i=1; AJvYcCUpnbxrJARy9h1P6LM0nPvyk800XhNDf5cn9Xp8NGV7a6JYts3JoWpYeizNrdfEdTZ4XNAakipJyRep58k=@vger.kernel.org X-Gm-Message-State: AOJu0YwBy0e1FBqdo89X0SateYL38xjCQdndNc9nFwMTr+InpMWOiTXw PEp8ea3NM2Mw8pp4rS8BAYiW8RThqIGlqZePOt1nFadTFiiiszn8FYbS48lORF3IfGFWqGNzJwE 4kFBbcTdY0yVGqTcKF0Fi8HZhrg0oarbCxRNPb8+9+xLk4Jzjdg3ZmKZeqNvXRmlm5o0= X-Gm-Gg: ASbGncum2BqeGV7Y71YSu/bCfyZ9nItRqirCk8M5Fn7mTH09YHdj1kt+3VEHkr2SDji 384rHM5Yav+8N92RKz2JM1/XFuf2AE/m9QJsWbm/XLSgCRZ5w52rsMBNkK/ULNyMNYT7iLoe+2r AHxUq3+2t3sETLqovAtylummyWjU3OsiKFvre2vZZmFTzG4yRdjiN5722+1njEQQ6+d31s7wca5 r/W/bdXZxuOexElxhxB+fv+Psb2LgB4+KR8O/1kJfLHBC+7dwOZg7nFYY+DkKM/AuwIomA+ZGZ8 RrutaSsdTvZKlJPUuwba9vu0ytQ2PbBFSxsZa2EqrGsHZh2iI7aKF2Y/UMtIpWo7kDImxE8yiQZ od7Teh4sw4kj2TpDt19O3vviwBY1jmuo+nEw847rROS4Pl1dFl6ioO9/cBBROTjOlZz0= X-Received: by 2002:a05:622a:1a87:b0:4ee:1db1:a61d with SMTP id d75a77b69052e-4ee49487384mr22122911cf.3.1763629851033; Thu, 20 Nov 2025 01:10:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IF+7CSO2eXsAvWMwQgXnloa7iXDcXJQcAajq6GgdbGNlLZIx0Ii0mFO+wY3pusV7uDKUpW9kQ== X-Received: by 2002:a05:622a:1a87:b0:4ee:1db1:a61d with SMTP id d75a77b69052e-4ee49487384mr22122661cf.3.1763629850516; Thu, 20 Nov 2025 01:10:50 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-645363b62cesm1608228a12.13.2025.11.20.01.10.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Nov 2025 01:10:50 -0800 (PST) Message-ID: <742601dc-32d8-41ff-8e2b-a960f6fe77ab@oss.qualcomm.com> Date: Thu, 20 Nov 2025 10:10:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] ARM: dts: qcom: msm8960: expressatt: Add Light/Proximity Sensor To: guptarud@gmail.com, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251119-expressatt_nfc_accel_magn_light-v1-0-636f16f05cf4@gmail.com> <20251119-expressatt_nfc_accel_magn_light-v1-1-636f16f05cf4@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251119-expressatt_nfc_accel_magn_light-v1-1-636f16f05cf4@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: KAK_OYbtuZSTtF_yJ26HCHb4oo2uvm17 X-Proofpoint-ORIG-GUID: KAK_OYbtuZSTtF_yJ26HCHb4oo2uvm17 X-Authority-Analysis: v=2.4 cv=DMqCIiNb c=1 sm=1 tr=0 ts=691edb1c cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=pGLkceISAAAA:8 a=jMnZrQita27iYXhThZwA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIwMDA1NCBTYWx0ZWRfX+3T+hbqn8Zip Em4V5BOs3p6xYju+UIuUSEEcWsgIIunB+61jbylrvp0oepNA89WxM4XH9HZqSoXUL1tMNiVkg3N Bn9qLDzOvwyFv5SEZK4O8RIkW7KEfwPHBs0iKAOyL9+H77w5iF5HIkyrXZ/6+0CFlkTbR/PTN5B wO2PTssYFfkgyl/3kQD1WZtoEK9YOkzrTIYGpibbebp037/El3Ml3uuoTGp7Zye91Fi4s5BT4i6 kCiSrg4tNn+JSdJpuQPk0yHTxtIhtuY1sDdn2DeJn9pAnpRYDvaCtAcxlunzbb7DYU5FzdWur65 c4gSI7fJV0JjreST5JS7ikQsm8VqUgkiGIicZNfCQsKqgkiZLVBXOG0VnFxKBHL20sj+5Du8wC5 SSZVtXFi+dvZmyRNjVPlBL541wT6ng== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-20_03,2025-11-18_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 bulkscore=0 spamscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511200054 On 11/20/25 8:14 AM, Rudraksha Gupta via B4 Relay wrote: > From: Rudraksha Gupta > > Currently the Proximity Sensor doesn't work, but light sensor does. > Left the proximity sensor as a TODO for later. > > Signed-off-by: Rudraksha Gupta > --- > .../dts/qcom/qcom-msm8960-samsung-expressatt.dts | 36 ++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts > index 5ee919dce75b..1e331a046e7b 100644 > --- a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts > +++ b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts > @@ -52,6 +52,31 @@ key-volume-down { > linux,code = ; > }; > }; > + > + i2c-gpio-sensors { > + compatible = "i2c-gpio"; Are you using gpio-i2c for any specific reason? Would GSBI2 not be connected to this pair? (I am not sure FWIW) > + sda-gpios = <&tlmm 12 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > + scl-gpios = <&tlmm 13 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > + i2c-gpio,delay-us = <5>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + light-sensor@39 { > + compatible = "amstaos,tmd2772"; > + reg = <0x39>; > + interrupt-parent = <&pm8921_gpio>; > + interrupts = <6 IRQ_TYPE_EDGE_FALLING>; > + vdd-supply = <&pm8921_l9>; > + vddio-supply = <&pm8921_lvs4>; > + > + // TODO: Proximity doesn't work C-style comments ( /* foo */ ) are preferred > + amstaos,proximity-diodes = <0>; Try comparing the values the upstream and downstream drivers write to the device, maybe you're missing something > + led-max-microamp = <100000>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&prox_sensor_int>; property-n property-names is the preferred order > + }; > + }; > }; > > &gsbi5 { > @@ -163,6 +188,15 @@ &pm8921 { > interrupts-extended = <&tlmm 104 IRQ_TYPE_LEVEL_LOW>; > }; > > +&pm8921_gpio { > + prox_sensor_int: prox-sensor-int-state { > + pins = "gpio6"; > + function = "normal"; > + input-enable; > + bias-disable; > + }; > +}; > + > &rpm { > regulators { > compatible = "qcom,rpm-pm8921-regulators"; > @@ -280,6 +314,7 @@ pm8921_l9: l9 { > regulator-min-microvolt = <2850000>; > regulator-max-microvolt = <2850000>; > bias-pull-down; > + regulator-always-on; > }; > > pm8921_l10: l10 { > @@ -377,6 +412,7 @@ pm8921_lvs3: lvs3 { > > pm8921_lvs4: lvs4 { > bias-pull-down; > + regulator-always-on; Does it stop working if you remove these regulator-always-on additions? Konrad