From: "Arnd Bergmann" <arnd@arndb.de>
To: "Marc Kleine-Budde" <mkl@pengutronix.de>,
"Vincent Mailhol" <mailhol@kernel.org>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Oliver Hartkopp" <socketcan@hartkopp.net>,
"Jimmy Assarsson" <extja@kvaser.com>,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: can: fix build dependency
Date: Wed, 10 Dec 2025 10:10:27 +0100 [thread overview]
Message-ID: <7427949a-ea7d-4854-9fe4-e01db7d878c7@app.fastmail.com> (raw)
In-Reply-To: <20251210-imported-pelican-from-tartarus-c1084f-mkl@pengutronix.de>
On Wed, Dec 10, 2025, at 09:16, Marc Kleine-Budde wrote:
> On 05.12.2025 00:30:14, Vincent Mailhol wrote:
>> > can-dev.> -if CAN_DEV
>> > +if CAN_DEV && CAN
>> ^^^^^^
>> Is this needed? CAN_DEV depends on CAN, so the condition
>>
>> CAN_DEV && !CAN
>>
>> should not be reachable.
>
> Removed the '&& CAN' while applying the patch.
Sorry I forgot to reply here: the '&& CAN' is absolutely
required here, otherwise you can configure CAN device drivers
as built-in with CAN_DEV=y CAN=m, and that results in a
link failure.
Arnd
next prev parent reply other threads:[~2025-12-10 9:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 10:00 Arnd Bergmann
2025-12-04 18:03 ` Oliver Hartkopp
2025-12-04 23:30 ` Vincent Mailhol
2025-12-10 8:16 ` Marc Kleine-Budde
2025-12-10 9:10 ` Arnd Bergmann [this message]
2025-12-10 9:38 ` Marc Kleine-Budde
2025-12-10 13:58 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7427949a-ea7d-4854-9fe4-e01db7d878c7@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=extja@kvaser.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®