From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 2/3] io_uring: add interface for getting files
Date: Tue, 21 Jan 2020 18:54:14 -0700 [thread overview]
Message-ID: <74320473-6f9f-7b10-4d5c-850c6f3af5ae@kernel.dk> (raw)
In-Reply-To: <96dc9d5a58450f462a62679e67db85850370a9f6.1579649589.git.asml.silence@gmail.com>
On 1/21/20 5:05 PM, Pavel Begunkov wrote:
> Preparation without functional changes. Adds io_get_file(), that allows
> to grab files not only into req->file.
>
> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
> ---
> fs/io_uring.c | 66 ++++++++++++++++++++++++++++++++-------------------
> 1 file changed, 41 insertions(+), 25 deletions(-)
>
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 8f7846cb1ebf..e9e4aee0fb99 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -1161,6 +1161,15 @@ static struct io_kiocb *io_get_req(struct io_ring_ctx *ctx,
> return NULL;
> }
>
> +static inline void io_put_file(struct io_ring_ctx *ctx, struct file *file,
> + bool fixed)
> +{
> + if (fixed)
> + percpu_ref_put(&ctx->file_data->refs);
> + else
> + fput(file);
> +}
Just make this take struct io_kiocb?
Apart from that, looks fine to me.
--
Jens Axboe
next prev parent reply other threads:[~2020-01-22 1:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 0:05 [POC RFC 0/3] splice(2) support for io_uring Pavel Begunkov
2020-01-22 0:05 ` [PATCH 1/3] splice: make do_splice public Pavel Begunkov
2020-01-22 0:05 ` [PATCH 2/3] io_uring: add interface for getting files Pavel Begunkov
2020-01-22 1:54 ` Jens Axboe [this message]
2020-01-22 2:24 ` Pavel Begunkov
2020-01-22 0:05 ` [PATCH 3/3] io_uring: add splice(2) support Pavel Begunkov
2020-01-22 2:03 ` Jens Axboe
2020-01-22 2:40 ` Pavel Begunkov
2020-01-22 2:47 ` Jens Axboe
2020-01-22 3:16 ` Pavel Begunkov
2020-01-22 3:22 ` Jens Axboe
2020-01-24 12:31 ` kbuild test robot
2020-01-25 18:28 ` kbuild test robot
2020-01-22 1:55 ` [POC RFC 0/3] splice(2) support for io_uring Jens Axboe
2020-01-22 3:11 ` Pavel Begunkov
2020-01-22 3:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74320473-6f9f-7b10-4d5c-850c6f3af5ae@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®