From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CEFAC433B4 for ; Tue, 6 Apr 2021 14:17:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46D986139C for ; Tue, 6 Apr 2021 14:17:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345004AbhDFOR4 (ORCPT ); Tue, 6 Apr 2021 10:17:56 -0400 Received: from mail.xenproject.org ([104.130.215.37]:51362 "EHLO mail.xenproject.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232541AbhDFORx (ORCPT ); Tue, 6 Apr 2021 10:17:53 -0400 X-Greylist: delayed 1870 seconds by postgrey-1.27 at vger.kernel.org; Tue, 06 Apr 2021 10:17:53 EDT DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=hL/DNXPgONRhYcLJof2CA1fzKZNQ0/R+MlOogkZCxL0=; b=EvBKmne0DBgjh15xBCHJLlyoSk duyPUpDgm7KnGPKqgTjZlC+cQzPAkPH8g1QNA4uOA+7IKkakATGmeDJ1s+PfoqVLvqTuS/bO0F3Gv HXcOPAGQgh2WxyxboCR0mmYB6WdY86xkucxL5+Q5UKz9IZZVS56gnBfTQJ2sNJ8hoAcw=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTm2M-0007fy-Ed; Tue, 06 Apr 2021 13:46:34 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lTm2M-0007os-6u; Tue, 06 Apr 2021 13:46:34 +0000 Subject: Re: [PATCH] xen/evtchn: Change irq_info lock to raw_spinlock_t To: Luca Fancellu , sstabellini@kernel.org, jgross@suse.com, jgrall@amazon.com Cc: boris.ostrovsky@oracle.com, tglx@linutronix.de, wei.liu@kernel.org, jbeulich@suse.com, yyankovskyi@gmail.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, bertrand.marquis@arm.com References: <20210406105105.10141-1-luca.fancellu@arm.com> From: Julien Grall Message-ID: <74349f41-ba4e-7486-5467-fb8fa3c96e50@xen.org> Date: Tue, 6 Apr 2021 14:46:31 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210406105105.10141-1-luca.fancellu@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Luca, On 06/04/2021 11:51, Luca Fancellu wrote: > Unmask operation must be called with interrupt disabled, > on preempt_rt spin_lock_irqsave/spin_unlock_irqrestore > don't disable/enable interrupts, so use raw_* implementation > and change lock variable in struct irq_info from spinlock_t > to raw_spinlock_t > > Cc: stable@vger.kernel.org > Fixes: 25da4618af24 ("xen/events: don't unmask an event channel > when an eoi is pending") > > Signed-off-by: Luca Fancellu Reviewed-by: Julien Grall Cheers, -- Julien Grall