From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1A1A4A3E; Wed, 23 Apr 2025 02:40:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745376033; cv=none; b=PHrUaa+/H78wjfyP6f4ZP4zoUqv1T5pHzkvdvn9HjuXD4oenqxCGNSZZcJ3H5qZPFNe602J/xpqm36HJFEqEKpU9imNOtoAF4vhIwIYegIw9jRhi0E+L5lxBLsafgKDVP+4+omh2ekTLovBrvhiPfjFcbFnpLaWa4LZpMFSpy9k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745376033; c=relaxed/simple; bh=fXEdKwLDEYP1FhT6qUr5SUEW8tpVM+vuvtbPberoHlU=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=RkuFoWqxrPz4q7gMVN36SMJnxYeods/vLU30M/AiyEKlPlAExbTkvL0H8oC+J8Gk2WXt+MWh3/t/cCtGbVz8XOLuahWc0/fXUqPzwbM8IbICJxpuCbUlYbefxNINPQfr0nnwx6wPZnv/pzhQTbb4auglbkT0YpvkW9UO6oq/lT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=f7mxGJfv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="f7mxGJfv" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53N0iRBL014200; Wed, 23 Apr 2025 02:40:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sEnWhSOcmsjXDCbo4JutcllgsrUm4ZD2PZsQO/oVLfI=; b=f7mxGJfvdNfUVeOi Kt+bQqMr2bGb27X6PLl+rQUCEdjuJqBEB2tiV9LQcy8KERqSh5GWtD4ldobgBP46 QGpmILoRS0IkdxFajNEmRhe6vBmjlWQdb+VMWYMNr3VmduTsSaMeOtHzL9cof8ho 3CZenGmXDKFjWKICHFv3EEYAwSzz923M4J3Yrm+CF3H7FSXKQWm/mI0y+iTu1cBS NY7TqUDs+SHccNkrc2qljVlpZMJXdmlURWJTiLkBTZiEhMsuf6TNRDFQLhob8eOT z/GCVHRQF4qJseCpIRa+g8XFNs7lgentAWafsDtudZfSFnT3OBAqwzIzgRI0bJr9 rEhexQ== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 466jh38mff-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Apr 2025 02:40:19 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 53N2eIip015716 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Apr 2025 02:40:18 GMT Received: from [10.71.110.123] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 22 Apr 2025 19:40:17 -0700 Message-ID: <743721c3-9015-4d3b-902d-cfa6ea4e94af@quicinc.com> Date: Tue, 22 Apr 2025 19:40:17 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] dt-bindings: display: msm: dp-controller: document clock parents better To: Dmitry Baryshkov , Krzysztof Kozlowski CC: Rob Clark , Sean Paul , "Marijn Suijten" , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kuogee Hsieh , Mahadevan , , , , , References: <20241202-dp_mst_bindings-v1-0-9a9a43b0624a@quicinc.com> <20241202-dp_mst_bindings-v1-2-9a9a43b0624a@quicinc.com> <2ef59c6d-bef2-4763-9463-06116a2e7d04@kernel.org> Content-Language: en-US From: Abhinav Kumar In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDIzMDAxNSBTYWx0ZWRfX0RgkRCZBz54K QXQwGeYVDusFGsob39/OzvGP6VYzt44Zpjyo/A7ZRiYk/bcsseDhprVkC4Uq4vbRAMMXLDpdqNp zsKz58x0/Payivce04r3qfUZNh0RiravHcsM1OfFUJ3F4e8n1L1M+OuwUbLtRqU3RHpJaqkhrqF 5uVpEHV9AFz1cd9RQvrwaO6JFBefwtR0QGmoS8XtiSiZ/dB05k+mFq/jhhzRWoNuzGuaHuMJ6wW H5JLqpgKFc5XSDy29g81+pR+Nwmn0bIFcHy4ICx2ItGTO5acXWwptxarKLOHz52AWSmqahiuv14 XcUVdZsOGADbJKZNytfytJnVFPIAkXG1DntGvRVMR4cvYh7w6Q0DU5CXVsXvltbZlRaLaTz4wGl zbZvYvqXo0BDUz9PsC7hLp9F0TXuOSZ+tgDxtulhESlsCAqpy/uwuw8VmkQe6DIbZtNneb2T X-Authority-Analysis: v=2.4 cv=bs1MBFai c=1 sm=1 tr=0 ts=68085313 cx=c_pps a=ouPCqIW2jiPt+lZRy3xVPw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=VwQbUJbxAAAA:8 a=gZuivp84EbNu_AB6qtIA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: xlAbQF5h3S4gKkjlBpZtpCfoEWMmHonf X-Proofpoint-GUID: xlAbQF5h3S4gKkjlBpZtpCfoEWMmHonf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-23_01,2025-04-22_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 suspectscore=0 mlxlogscore=984 mlxscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 impostorscore=0 malwarescore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504230015 Hi Krzysztof and Dmitry Sorry for the late response. On 12/5/2024 3:32 AM, Dmitry Baryshkov wrote: > On Thu, 5 Dec 2024 at 09:33, Krzysztof Kozlowski wrote: >> >> On 04/12/2024 11:09, Dmitry Baryshkov wrote: >>> On Wed, Dec 04, 2024 at 09:02:18AM +0100, Krzysztof Kozlowski wrote: >>>> On Tue, Dec 03, 2024 at 03:41:48PM +0200, Dmitry Baryshkov wrote: >>>>> On Tue, Dec 03, 2024 at 09:01:31AM +0100, Krzysztof Kozlowski wrote: >>>>>> On 03/12/2024 04:31, Abhinav Kumar wrote: >>>>>>> Document the assigned-clock-parents better for the DP controller node >>>>>>> to indicate its functionality better. >>>>>> >>>>>> >>>>>> You change the clocks entirely, not "document". I would say that's an >>>>>> ABI break if it really is a Linux requirement. You could avoid any >>>>>> problems by just dropping the property from binding. >>>>> >>>>> But if you take a look at the existing usage, the proposed change >>>>> matches the behaviour. So, I'd say, it's really a change that makes >>>>> documentation follow the actual hardware. >>>> Yes, I was trying to document it better and that way adding/extending more streams becomes easier for the next patches in the series. >>>> First, this should be in the commit msg, instead of "document better to >>>> indicate functionality better". >>>> >>>> Second, what is the point of documenting it in the first place if you >>>> can change it and changing has no impact? So maybe just drop? >>> >>> So, do you suggest setting both of the property descriptions to true? Or >>> dropping them completely and using unevaluatedProperties instead of >>> additionalProperties? >>> >> >> Dropping them entirely, without any changes of additionalProperties. >> Unless this property was added due to limitation of dtschema? > > I don't remember at this point. I think it's worth trying to drop them. > I tried dropping assigned-clock-parents altogether and it seems fine, No schema/errors of warnings if I also fixup the examples in qcom,sc7180-mdss.yaml and qcom,sa8775p-mdss.yaml to drop the usage. So I can go ahead with dropping it. Thanks Abhinav