From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6395AC55178 for ; Thu, 5 Nov 2020 16:53:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F104420759 for ; Thu, 5 Nov 2020 16:53:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="EGd6RItc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731453AbgKEQx0 (ORCPT ); Thu, 5 Nov 2020 11:53:26 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:55418 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726214AbgKEQxZ (ORCPT ); Thu, 5 Nov 2020 11:53:25 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0A5GrKSd051762; Thu, 5 Nov 2020 10:53:20 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1604595200; bh=bJHxWXo+htEqIJck0oZ4xC9NV1O36+j9LjNAzdp58ms=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=EGd6RItcFRPVPWaPhXlQOd5+xwYqgh7nzhmM97enuIGayTDI5zeAb/ODpjJuJtHGw vy91Z52rqq0U9GKxhM4zQ2SqUPMU0RIj6e1OH5/GEYQMTWFTYp8m0IVFv8yFl5I+Ld VnLyhf4c6qoEWv9O2Pzi5JcuR53QGMi24WE/a3dc= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0A5GrKY6045430 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 5 Nov 2020 10:53:20 -0600 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 5 Nov 2020 10:53:19 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 5 Nov 2020 10:53:20 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0A5GrId2050489; Thu, 5 Nov 2020 10:53:18 -0600 Subject: Re: [PATCH 08/19] gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables To: Lee Jones CC: , David Airlie , Daniel Vetter , Laurent Pinchart , References: <20201105144517.1826692-1-lee.jones@linaro.org> <20201105144517.1826692-9-lee.jones@linaro.org> From: Tomi Valkeinen Message-ID: <74399fab-6af5-77d3-e0eb-749774eb2837@ti.com> Date: Thu, 5 Nov 2020 18:53:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201105144517.1826692-9-lee.jones@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/2020 16:45, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘_dsi_print_reset_status’: > drivers/gpu/drm/omapdrm/dss/dsi.c:1131:6: warning: variable ‘l’ set but not used [-Wunused-but-set-variable] > drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘dsi_update’: > drivers/gpu/drm/omapdrm/dss/dsi.c:3943:10: warning: variable ‘dh’ set but not used [-Wunused-but-set-variable] > drivers/gpu/drm/omapdrm/dss/dsi.c:3943:6: warning: variable ‘dw’ set but not used [-Wunused-but-set-variable] > > Cc: Tomi Valkeinen > Cc: David Airlie > Cc: Daniel Vetter > Cc: Laurent Pinchart > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) I'd use "drm/omap: dsi: " subject prefix, the current one is fine too: Reviewed-by: Tomi Valkeinen Should I pick this up or do you want to keep the series intact? Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki