From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CD353A3E82 for ; Tue, 21 Apr 2026 09:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776763688; cv=none; b=dmdlXwP8GujjJ7PHwiKF9tmE97lObPwddhlypQOiJTAfDG5+k+ZRYVzEH0g7b2SESb0nou/BxFx8i1cIWITDgfYImHAxFLwH7rgss+fu6NkeCrUfhqh5ellAE8lpRGSQf5v243rXMrJdlCyXpQmW8Jd/m9bUq9Z66GsivYQjnsE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776763688; c=relaxed/simple; bh=ZNfISKpSCjCGscK8/Ib7YAmiEv+e/c+WMOCf3R0g/PI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dTPt9/PYECj7LhgLnWyqiXBtbW+YWIiPi4UUAlT22TpoW94shm1ouCBcqjH9AK6W0GmD4wVTOJOREaK5CYDt89qXMaTgOVETbfRCa+0RdLIGkfd9x0H0zXPvcl2Wi/pb/vdp01TfXQeneTZX8GwkFwJ8eRWIE1vlPUD367pB9/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JSqRt6Zx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=L4mQi31+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JSqRt6Zx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="L4mQi31+" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63L3PYwu4167765 for ; Tue, 21 Apr 2026 09:28:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XG0WfbWW1KDOp5vpDhXYtbdAi1HkcHqFYHF/2b8RrvE=; b=JSqRt6Zx2TClGGPY pZEMExS6VcQRHcHEpVMr/j0SPz/WC8Xi9eciiwDm0NptLMro2QP9hPghccAbaeEB zEXir5DaIo5+ifXjHJexGJLSHcmYAQ3S1YLvce7BdYigOgDPtSBsNmGZO4JNGpO/ Zd53XcYEdtuNerSMa10xiMW1BjjwLaRydqfVgkBhYr4wGUHzpn/IqxCprRSZBIlw DuXxXi2Xtsm/ZKzo5NGT7hXKS5/lQYyCTDwPvDELq4PDTi2K9aK2eN77FM+6Co6t ohQiTqvqlocMYHOhbPccrM0TgtJenAI2+Rucws+eBJQTLSapeCMHN8oJ+ugCe+xF ZBjVmA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dp1au1as8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Apr 2026 09:28:06 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-358f058973fso4706733a91.1 for ; Tue, 21 Apr 2026 02:28:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776763685; x=1777368485; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XG0WfbWW1KDOp5vpDhXYtbdAi1HkcHqFYHF/2b8RrvE=; b=L4mQi31+prlrTIEWlmHNbZ/1ivELseYWdY/oC/U4gCHyIfGAkNrgdLZtYEdbUzhBzF ZKRpiY+UoSgR2UVftLv7dWPtJcijdEcftPrMXQZycxk5uWED37mh4xZt1NkpXXJe+5Ll EN2zU3w0TryPpfC527dNnHq0M3SdA+0CtzQv3AzbsKBP+lRL5tKad9SC3x5W0OGf9Iv9 14FaKZeq2pLhZjqO+xsE1VbmGOBOMm/n3x1RYz58CtyUFecf81VVuEA4X+9g/ZK/osvT 1SWuRRF+GauDYBhk5GKNtbzOMQwfa7qz4/8hkSoszY14BZVpYfiOvINDtlkV0tv8HLuZ EoAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776763685; x=1777368485; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XG0WfbWW1KDOp5vpDhXYtbdAi1HkcHqFYHF/2b8RrvE=; b=MMkMkJVZkm6+Bih/PZOht9m4QrfVRr9kVDJn3DkIlWN8SxFWZ2OLv9qC8FEHtMw6s8 dLNez3P8CZR9ARqLz8QTKK0TZ+ZUNoUfiiZYyvzG0s2BUmjhhE3a0rz60ly7dsj8CHAc YeHQ6wv9z6VIqlWeFejSM4Ezp48OywR41dqSooF5bpBZScLQZZ6Sdpd9MgRIrs9MRMrj WuBHYBU8SQU/np/ZQX28ANEVgjTc2ikNpk/0/CVyCHjK2ov2AKwj4gEs82Obvekafm4/ ZU3PYA72a2EKLQxFxQtOUCQHFXDI2r8yjz9/CJHRvXhImwtUyZM2+cI7nwz73AtSDmtS KXfw== X-Forwarded-Encrypted: i=1; AFNElJ+OKydQcdfxxTm0O96HTvwQ100B+5+K7ZPMUknqcOK42y2kvVbe+WVVO1jH7NhcAsM+A9/Exx05fgCqr7Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0ekdyJWShZOVgnWmwyGqsGyG6gvsgLdi2rbnCEP697MurIAbN PiWiKNz13egv+nj9F66GSBXCuxHzs2jKQT4NngjS4uGe70j7IH5nrqI8w+Rd/TVMWGHXiKWYkYp eK3La3reLaBxDBwAoH9DHa8t9tz3znRH3+dda9epPln9y3RxwqkDhZp2elKCCdJGvv7o= X-Gm-Gg: AeBDietpL82b6qm0dgZlZmG4oMRdXoQgn6mb90Ywj6zLzSyAkaNY0XMQwCSW2FzYR3+ Vjx0aiUS6H4YETXjZBqNAYm52s/RkRWde8pCW6W1jJ+FHg+OsRgQF1t/co7nebvxzdqR1v3nUyE Lhsuj2WWUIJLyE8FeanLaUr5mMWunCO1ixQa1CzBOkGxlIc26b1R7k4OrKK+xICLYd6KcES3xk4 vZ0VeKw698iPsXJdTM+4pJ8sGzEUQRgRGHiR4lquih5/BJzKDN18+gH3V3zdULdY5PTCSQUySQa 6CnF+eAXS+ngEvq9XPLP/3StVnlF2KDYQp5FvCOIpT9rSg6BFMniZBjTHMn7S4xyLiWFVCjy4rP MLIEx5CcNMYBCC1phlw+TzNBmasSB2r4Kr6arpQ4B9Ljqg5PstKvx+HF7kdlUmmk= X-Received: by 2002:a17:90b:394e:b0:359:d54:846f with SMTP id 98e67ed59e1d1-361403f10f9mr16859887a91.7.1776763684519; Tue, 21 Apr 2026 02:28:04 -0700 (PDT) X-Received: by 2002:a17:90b:394e:b0:359:d54:846f with SMTP id 98e67ed59e1d1-361403f10f9mr16859847a91.7.1776763684031; Tue, 21 Apr 2026 02:28:04 -0700 (PDT) Received: from [10.218.21.127] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3614198f775sm15294860a91.16.2026.04.21.02.27.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Apr 2026 02:28:03 -0700 (PDT) Message-ID: <743ae20d-1894-4566-992f-db8dccebee9f@oss.qualcomm.com> Date: Tue, 21 Apr 2026 14:57:52 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 12/13] arm64: dts: qcom: milos: Add power-domain and iface clk for ice node To: Harshal Dev , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich , Abel Vesa Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Krzysztof Kozlowski References: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> <20260416-qcom_ice_power_and_clk_vote-v5-12-5ccf5d7e2846@oss.qualcomm.com> Content-Language: en-US From: Kuldeep Singh In-Reply-To: <20260416-qcom_ice_power_and_clk_vote-v5-12-5ccf5d7e2846@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIxMDA5MSBTYWx0ZWRfX70SoqqowGMMg bEZ2bkPAm9A3GyFQEBpfGp3jJqpKAREF7eIsaqz7qxteuIJEONgHzXO1r0SrVf9+1/huBV8Jcr+ xvvdk+lSk6eiQQpvB+RORMTTltInyyr4HlAr5o7tbaRYkCby0eleXPiAuYzFddkg+L3ISaTA9N8 xSfF5roZsb7RbJpA6JVRAdRc5Y6dcuf5YcVtYi/PhUeLx1Eahbs+7dk7GJA6T6tdY84hQIOhBy0 3TlJtOJeN8JyhKmTEX9abekAPLJBQbC29CBQpir22PIJn0eXSsQx+za4qVqgpxjfJDXaE1sLJPF QBTrRvuwdEEYQQv2657uRrrGpTUVNr69u1yvkLaFjEEYNGJ4gyKMh/4WmELkTsfmInyGF+PzU5n FKmB3yHgHSUjiw1mpojupddpui9yvh88k7tE71vf1BIexjFFkdIr2JeF9SpLP0+FzPmfwKboHxI V9nXmYhi9Dadi8O2OSQ== X-Authority-Analysis: v=2.4 cv=F9JnsKhN c=1 sm=1 tr=0 ts=69e74326 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=RcdfdvLsBkETvr5PKcUA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: C6LXG5cOZZAcNds9SH2QM-oXGwSjeDsS X-Proofpoint-ORIG-GUID: C6LXG5cOZZAcNds9SH2QM-oXGwSjeDsS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-21_01,2026-04-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604210091 On 16-04-2026 17:29, Harshal Dev wrote: > Qualcomm in-line crypto engine (ICE) platform driver specifies and votes > for its own resources. Before accessing ICE hardware during probe, to > avoid potential unclocked register access issues (when clk_ignore_unused > is not passed on the kernel command line), in addition to the 'core' clock > the 'iface' clock should also be turned on by the driver. This can only be > done if the UFS_PHY_GDSC power domain is enabled. Specify both the > UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for milos. > > Fixes: 04bb37433330e ("arm64: dts: qcom: milos: Add UFS nodes") > Signed-off-by: Harshal Dev Reviewed-by: Kuldeep Singh -- Regards Kuldeep