From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753377Ab3LJOLv (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 Dec 2013 09:11:51 -0500
Received: from aserp1040.oracle.com ([141.146.126.69]:37197 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751622Ab3LJOLs convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 Dec 2013 09:11:48 -0500
User-Agent: K-9 Mail for Android
In-Reply-To: <CABawtvMGOJg5DPRwdWAOSTkxgurv5bx8n=3yJFOq=aagxzseZQ@mail.gmail.com>
References: <1386581831-312-1-git-send-email-ethan.kernel@gmail.com> <20131209213057.GA11314@phenom.dumpdata.com> <CABawtvMGOJg5DPRwdWAOSTkxgurv5bx8n=3yJFOq=aagxzseZQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 8BIT
Subject: Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Date: Tue, 10 Dec 2013 09:11:00 -0500
To: Ethan Zhao <ethan.kernel@gmail.com>
CC: michaelc@cs.wisc.edu, pjones@redhat.com,
        LKML <linux-kernel@vger.kernel.org>
Message-ID: <74430a05-1640-4174-977d-52d2d2b8519f@email.android.com>
X-Source-IP: acsinet21.oracle.com [141.146.126.237]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ethan Zhao <ethan.kernel@gmail.com> wrote:
>Konrad,
>
> boot_kset was allocated when module loaded by
>ibft_init()
>  iscsi_boot_create_kset()
>     kzalloc()
>
>but wasn't freed when module unloaded by
>ibft_exit()
>   ibft_cleanup()
>     iscsi_boot_destroy_kset()
>
>Thanks,
>Ethan
>
>On Tue, Dec 10, 2013 at 5:30 AM, Konrad Rzeszutek Wilk
><konrad.wilk@oracle.com> wrote:
>> On Mon, Dec 09, 2013 at 05:37:11PM +0800, Ethan Zhao wrote:
>>> From: "Ethan Zhao" <ethan.kernel@gmail.com>
>>>
>>> Load and unload iscsi_ibft module will cause kernel memory leak, fix
>it
>>> in scsi/iscsi_boot_sysfs.c iscsi_boot_destroy_kset().
>>>
>>
>> Is there a stack trace?
>>> Signed-off-by: Ethan Zhao <ethan.kernel@gmail.com>
>>> ---
>>>  drivers/scsi/iscsi_boot_sysfs.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/scsi/iscsi_boot_sysfs.c
>b/drivers/scsi/iscsi_boot_sysfs.c
>>> index 14c1c8f..680bf6f 100644
>>> --- a/drivers/scsi/iscsi_boot_sysfs.c
>>> +++ b/drivers/scsi/iscsi_boot_sysfs.c
>>> @@ -490,5 +490,6 @@ void iscsi_boot_destroy_kset(struct
>iscsi_boot_kset *boot_kset)
>>>               iscsi_boot_remove_kobj(boot_kobj);
>>>
>>>       kset_unregister(boot_kset->kset);
>>> +     kfree(boot_kset);
>>>  }
>>>  EXPORT_SYMBOL_GPL(iscsi_boot_destroy_kset);
>>> --
>>> 1.8.3.4 (Apple Git-47)
>>>

Right. In the past we did not do that b/c certain drivers (like broadcom) would allocate on the kset their name and try to free (the driver would after freeing the ibft). So you would end up with this patch a double free ( and it might be fixed by now but I can't recall).

My question was - did you observer a crash or bug. Hence the question about stack trace? How did you see this?

Thank you.