From: Derek Robson <robsonde@gmail.com>
To: gregkh@linuxfoundation.org, robsonde@gmail.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 01/25] Staging: rtl8192u: r819xU_phy.c - style fix
Date: Sat, 11 Feb 2017 22:52:40 +1300 [thread overview]
Message-ID: <7449ebb425c14eb669d2f85c036a6b9db466463e.1486804834.git.robsonde@gmail.com> (raw)
In-Reply-To: <cover.1486804834.git.robsonde@gmail.com>
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson <robsonde@gmail.com>
---
drivers/staging/rtl8192u/r819xU_phy.c | 41 +++++++++++++++++++++++------------
1 file changed, 27 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_phy.c b/drivers/staging/rtl8192u/r819xU_phy.c
index 696df3440077..c99130fdb8ee 100644
--- a/drivers/staging/rtl8192u/r819xU_phy.c
+++ b/drivers/staging/rtl8192u/r819xU_phy.c
@@ -367,7 +367,8 @@ static u32 phy_FwRFSerialRead(struct net_device *dev, RF90_RADIO_PATH_E eRFPath,
/* Firmware RF Write control.
* We can not execute the scheme in the initial step.
* Otherwise, RF-R/W will waste much time.
- * This is only for site survey. */
+ * This is only for site survey.
+ */
/* 1. Read operation need not insert data. bit 0-11 */
/* 2. Write RF register address. bit 12-19 */
data |= ((offset&0xFF)<<12);
@@ -380,7 +381,8 @@ static u32 phy_FwRFSerialRead(struct net_device *dev, RF90_RADIO_PATH_E eRFPath,
read_nic_dword(dev, QPNR, &tmp);
while (tmp & 0x80000000) {
/* If FW can not finish RF-R/W for more than ?? times.
- We must reset FW. */
+ * We must reset FW.
+ */
if (time++ < 100) {
udelay(10);
read_nic_dword(dev, QPNR, &tmp);
@@ -394,7 +396,8 @@ static u32 phy_FwRFSerialRead(struct net_device *dev, RF90_RADIO_PATH_E eRFPath,
read_nic_dword(dev, QPNR, &tmp);
while (tmp & 0x80000000) {
/* If FW can not finish RF-R/W for more than ?? times.
- We must reset FW. */
+ * We must reset FW.
+ */
if (time++ < 100) {
udelay(10);
read_nic_dword(dev, QPNR, &tmp);
@@ -426,7 +429,8 @@ static void phy_FwRFSerialWrite(struct net_device *dev,
/* Firmware RF Write control.
* We can not execute the scheme in the initial step.
* Otherwise, RF-R/W will waste much time.
- * This is only for site survey. */
+ * This is only for site survey.
+ */
/* 1. Set driver write bit and 12 bit data. bit 0-11 */
/* 2. Write RF register address. bit 12-19 */
@@ -442,7 +446,8 @@ static void phy_FwRFSerialWrite(struct net_device *dev,
read_nic_dword(dev, QPNR, &tmp);
while (tmp & 0x80000000) {
/* If FW can not finish RF-R/W for more than ?? times.
- We must reset FW. */
+ * We must reset FW.
+ */
if (time++ < 100) {
udelay(10);
read_nic_dword(dev, QPNR, &tmp);
@@ -451,10 +456,12 @@ static void phy_FwRFSerialWrite(struct net_device *dev,
}
}
/* 7. No matter check bit. We always force the write.
- Because FW will not accept the command. */
+ * Because FW will not accept the command.
+ */
write_nic_dword(dev, QPNR, data);
/* According to test, we must delay 20us to wait firmware
- to finish RF write operation. */
+ * to finish RF write operation.
+ */
/* We support delay in firmware side now. */
}
@@ -723,7 +730,8 @@ u8 rtl8192_phy_checkBBAndRF(struct net_device *dev, HW90_BLOCK_E CheckBlock,
WriteAddr[HW90_BLOCK_RF],
bMask12Bits, WriteData[i]);
/* TODO: we should not delay for such a long time.
- Ask SD3 */
+ * Ask SD3
+ */
usleep_range(1000, 1000);
reg = rtl8192_phy_QueryRFReg(dev, eRFPath,
WriteAddr[HW90_BLOCK_RF],
@@ -820,7 +828,8 @@ static void rtl8192_BB_Config_ParaFile(struct net_device *dev)
}
/* Check if the CCK HighPower is turned ON.
- This is used to calculate PWDB. */
+ * This is used to calculate PWDB.
+ */
priv->bCckHighPower = (u8)rtl8192_QueryBBReg(dev,
rFPGA0_XA_HSSIParameter2,
0x200);
@@ -839,7 +848,8 @@ void rtl8192_BBConfig(struct net_device *dev)
rtl8192_InitBBRFRegDef(dev);
/* config BB&RF. As hardCode based initialization has not been well
* implemented, so use file first.
- * FIXME: should implement it for hardcode? */
+ * FIXME: should implement it for hardcode?
+ */
rtl8192_BB_Config_ParaFile(dev);
}
@@ -1158,7 +1168,8 @@ bool rtl8192_SetRFPowerState(struct net_device *dev,
switch (pHalData->eRFPowerState) {
case eRfOff:
/* If Rf off reason is from IPS,
- LED should blink with no link */
+ * LED should blink with no link
+ */
if (pMgntInfo->RfOffReason == RF_CHANGE_BY_IPS)
Adapter->HalFunc.LedControlHandler(Adapter, LED_CTL_NO_LINK);
else
@@ -1168,7 +1179,7 @@ bool rtl8192_SetRFPowerState(struct net_device *dev,
case eRfOn:
/* Turn on RF we are still linked, which might
- happen when we quickly turn off and on HW RF.
+ * happen when we quickly turn off and on HW RF.
*/
if (pMgntInfo->bMediaConnect)
Adapter->HalFunc.LedControlHandler(Adapter, LED_CTL_LINK);
@@ -1263,7 +1274,8 @@ static u8 rtl8192_phy_SwChnlStepByStep(struct net_device *dev, u8 channel,
if (!IsLegalChannel(priv->ieee80211, channel)) {
RT_TRACE(COMP_ERR, "set to illegal channel: %d\n", channel);
/* return true to tell upper caller function this channel
- setting is finished! Or it will in while loop. */
+ * setting is finished! Or it will in while loop.
+ */
return true;
}
/* FIXME: need to check whether channel is legal or not here */
@@ -1609,7 +1621,8 @@ void rtl8192_SetBWModeWorkItem(struct net_device *dev)
}
/* Skip over setting of J-mode in BB register here.
- Default value is "None J mode". */
+ * Default value is "None J mode".
+ */
/* <3> Set RF related register */
switch (priv->rf_chip) {
--
2.11.1
next prev parent reply other threads:[~2017-02-11 9:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-11 9:52 [PATCH 00/25] Staging: rtl8192u - fixed block comments Derek Robson
2017-02-11 9:52 ` Derek Robson [this message]
2017-02-11 9:52 ` [PATCH 02/25] Staging: rtl8192u: r819xU_firmware.c - style fix Derek Robson
2017-02-11 9:53 ` [PATCH 03/25] Staging: rtl8192u: r819xU_cmdpkt.h " Derek Robson
2017-02-11 9:53 ` [PATCH 04/25] Staging: rtl8192u: r819xU_cmdpkt.c " Derek Robson
2017-02-12 12:39 ` Greg KH
2017-02-11 9:53 ` [PATCH 05/25] Staging: rtl8192u: r8192U_hw.h " Derek Robson
2017-02-11 9:54 ` [PATCH 06/25] Staging: rtl8192u: r8192U_dm.c " Derek Robson
2017-02-11 9:54 ` [PATCH 07/25] Staging: rtl8192u: r8192U_core.c " Derek Robson
2017-02-11 9:54 ` [PATCH 08/25] Staging: rtl8192u: r8192U.h " Derek Robson
2017-02-11 9:55 ` [PATCH 09/25] Staging: rtl8192u: r8190_rtl8256.h " Derek Robson
2017-02-11 9:55 ` [PATCH 10/25] Staging: rtl8192u: r8190_rtl8256.c " Derek Robson
2017-02-11 9:55 ` [PATCH 11/25] Staging: rtl8192u: r8180_93cx6.c " Derek Robson
2017-02-11 9:55 ` [PATCH 12/25] Staging: rtl8192u: ieee80211: ieee80211_crypt_wep.c " Derek Robson
2017-02-11 9:56 ` [PATCH 13/25] Staging: rtl8192u: ieee80211: rtl819x_TSProc.c " Derek Robson
2017-02-11 9:56 ` [PATCH 14/25] Staging: rtl8192u: ieee80211: ieee80211_softmac.c " Derek Robson
2017-02-11 9:56 ` [PATCH 15/25] Staging: rtl8192u: ieee80211: ieee80211_module.c " Derek Robson
2017-02-11 9:56 ` [PATCH 16/25] Staging: rtl8192u: ieee80211: rtl819x_HTProc.c " Derek Robson
2017-02-11 9:57 ` [PATCH 17/25] Staging: rtl8192u: ieee80211: rtl819x_BAProc.c " Derek Robson
2017-02-11 9:57 ` [PATCH 18/25] Staging: rtl8192u: ieee80211: rtl819x_HT.h " Derek Robson
2017-02-12 12:31 ` Greg KH
2017-02-11 9:57 ` [PATCH 19/25] Staging: rtl8192u: ieee80211: rtl819x_BA.h " Derek Robson
2017-02-11 9:57 ` [PATCH 20/25] Staging: rtl8192u: ieee80211: ieee80211_wx.c " Derek Robson
2017-02-11 9:58 ` [PATCH 21/25] Staging: rtl8192u: ieee80211: ieee80211_tx.c " Derek Robson
2017-02-11 9:58 ` [PATCH 22/25] Staging: rtl8192u: ieee80211: ieee80211_rx.c " Derek Robson
2017-02-11 9:58 ` [PATCH 23/25] Staging: rtl8192u: ieee80211: ieee80211_crypt.h " Derek Robson
2017-02-11 9:59 ` [PATCH 24/25] Staging: rtl8192u: ieee80211: ieee80211_crypt.c " Derek Robson
2017-02-11 9:59 ` [PATCH 25/25] Staging: rtl8192u: ieee80211: ieee80211.h " Derek Robson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7449ebb425c14eb669d2f85c036a6b9db466463e.1486804834.git.robsonde@gmail.com \
--to=robsonde@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®