From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E2F13F54C5 for ; Wed, 8 Jul 2026 07:35:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783496140; cv=none; b=LMTEe33NoNyykjO2WBcRBldF7vcHwFDy+UdGbZ9TTjKOrC/Yy+j+BE9DDoIudPmbtmzmLA9LuRQDumF/uW0sDayc4jEknge6dWtJl2drkeU5t8Wt9dbuddtd/XcEJ2oT5/bc2+keGWp9vS1X17mhoz94zHzPKTBJTBZjSfFCIU4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783496140; c=relaxed/simple; bh=b5ZTxjwdijmuADzULPIvDGzxFk7ODUmj1Xb0RRNjP+8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YKQuAV4IAon+Wh73yPQf7DAYfUGoVNjQ1DiGV1GEtS0WMk08HR7Q0TJbiDHDDx4ydBws/+EeijWYmFxeS8+IHxiBCURqBCdWx8CAgiReKCrPBetIWrvPEwKiht8B74WfxEvTC/i11UKI2q8d54HY8xcu4uW9LlrkF8nDm2wE9Wo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d1BJxneH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=G3QBshCs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d1BJxneH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="G3QBshCs" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66842AvS1572647 for ; Wed, 8 Jul 2026 07:35:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3nrZBDGQDmY+CQjESpuWaDP7VmOJKMsPPsfgvpK8nTM=; b=d1BJxneH8nuJ5u20 HuzLWDQqdekws2WZG82OdLcnm4tKzco5B+Zz3fkfgeU8AETXA4zft8PLCS+OLvZo Z8uDEFVgc2m3Mwlz27ofzeY3u+xO8lbKTVaZORjje5sXT+NnYXeO8WeRoV+6PKcZ 8rueLzNyWWQYsarMKBOUwSmP4Jhh2RHAW4VEs1pv0XmgkszWahJM1kStWONu9SrN Bfneww2ra2HpWDh8+0DqHkstAxRq+L0K1ByYBnJulVRYI0UcEBTBrJPZTqNh2XkC z201L4GHoovT94Uc0SOtJ8804WfnaihpDJk/tdIu2TBd/Txdf9e4rR0oSXHV/E31 eQUB8w== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f99hgt0ba-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Jul 2026 07:35:29 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8478ff5d801so922567b3a.2 for ; Wed, 08 Jul 2026 00:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783496128; x=1784100928; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3nrZBDGQDmY+CQjESpuWaDP7VmOJKMsPPsfgvpK8nTM=; b=G3QBshCs0/wFXpEQut9D6Iw6HGqiprLA9YqpyiGwLsBvOlPny4+2H3YPyKpjhgmMGp kDS8ygLsnYxfegUHyz1g13Wz/QPNb005A0oPr5v4Z6bLIUddJw7Y6To90/lgucejw5/X VQxoujztrhkUtLfFREc4KGXx0wK9m9qvUtDDKeUupkIxwacQvujTWnoIRk7BwX7orHfF uf9YjSUgQABZuXoLWZ04HafNSmjiuhtbvdyvZZJlcAjM3b7XKAK7MpSULK4AUhc0R1sr zzGtZz8aDUMmT5agrdQJ4qRO41CGBWYwqBOfuyLqO+XPVBVCSCr1DoBaOiODCAxmegtN 2Qig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783496128; x=1784100928; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3nrZBDGQDmY+CQjESpuWaDP7VmOJKMsPPsfgvpK8nTM=; b=fNC9MAi7Rx1TkbCj+ZUof53CTbRUJbBDfeEOtChZcPhjqS4/M39Vv6N+ZDg/a3vJLP Bit2H+TiS8eDkKVjy2nYSm1CoNW6ysGNJtvilFurbr270X/Bj0egPuMKN7qhOlZitjcZ aFUhXpR4pdT0/MuW8n8/g8GEUEjKb8cFHUX4RpM8ATP4v/QZ5EmZYXpSm4i+rWh5bC6K bpjBC63vdrjyyGhTM8IHarziZ0JPGXHjW5AJ6lRc+30aeOu+XOGjnTAMAqeOw4tLsUCX 0QUt0e8FwRU6k8KZ4YfFJ0YrXUjtZ3dBMsrE4kqBZhGY7d4NKfbzXtN6VGmn9I3XLvUx Eevw== X-Forwarded-Encrypted: i=1; AHgh+Rp29YeRtls4U810lilkaSYR0HkF58V4CQX7o2RubJUSTABgZCJEgGfuncDcT/jDRGPJ0gAJ2ukRwC7bfBg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3BpMoRqpBRQiFzeqmt+xfOp4A967udPn4CahtN3mQUOPHO+OD YjcqJ/QKPZEkTR4SSvObxyEeNjAZcxgHywsmOV2AdzIhn8mlqWC8+5v6IY2cACbYQSbEvwJGlyM XteQ1s3MV5nEMKis9ZM/xlK4SSKvlITjoKJTet3fTtm0roYFPc+cFLinVtp9mkVa/WKc= X-Gm-Gg: AfdE7cmXmLVXoRd4LcXmBEUoor1yw0UMefeConmR0tKaYbilgcL/RMAqjb8azZp/Emw 0HAG9DeTVsPo9X6apfS0k7TSBhDeDwtD0cRJITMZ1W/JRODxX5xKXE+imXnN6FFz9Ze7BQYcPA9 yWIjczA6jDFMTgbvTg9ggoJG6q+FWfE/UuymFkce+1qbAOgQiVqd5Heo/QAaHvPLFeGDBDwEpor 4B2xiuylA5L1C8I/yuFYKn3wuigZ3pLQHJjm+Oa+axec8xDVEWZBsNLEwZw7n6t0M5DgeBENkBX h9J/vW1TkXhoDgNJ+Eu6EHE+4Quj7KRx7XfmZ4lYpKJRB7ZcU0LObLxc+6YWGKJNDXYgFP/QSiT u3EKF7hKjqRAX8Y4JiK+shBwQS0utqOgasQW+DXWrqF3E X-Received: by 2002:a05:6a00:244a:b0:847:9ce5:d293 with SMTP id d2e1a72fcca58-8484301f0a4mr1601367b3a.24.1783496128155; Wed, 08 Jul 2026 00:35:28 -0700 (PDT) X-Received: by 2002:a05:6a00:244a:b0:847:9ce5:d293 with SMTP id d2e1a72fcca58-8484301f0a4mr1601339b3a.24.1783496127648; Wed, 08 Jul 2026 00:35:27 -0700 (PDT) Received: from [10.217.219.87] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6d44d48sm6644002b3a.39.2026.07.08.00.35.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2026 00:35:27 -0700 (PDT) Message-ID: <74520b45-b3d1-475a-8929-b965ce760d5a@oss.qualcomm.com> Date: Wed, 8 Jul 2026 13:05:18 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] i2c: qcom-geni: use cancel command before abort on transfer timeout To: Praveen Talari , Viken Dadhaniya , Andi Shyti Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Naresh Maramaina References: <20260708-fix_cancel_sequence_on_failure_for_i2c-v1-0-dd8f841f36a2@oss.qualcomm.com> <20260708-fix_cancel_sequence_on_failure_for_i2c-v1-1-dd8f841f36a2@oss.qualcomm.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: <20260708-fix_cancel_sequence_on_failure_for_i2c-v1-1-dd8f841f36a2@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: C0jnpRhtRnX4cPCmSesTJk8ITdbL-zuv X-Authority-Analysis: v=2.4 cv=CviPtH4D c=1 sm=1 tr=0 ts=6a4dfdc1 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=6kLu1IwUGHXDgf738pMA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-ORIG-GUID: C0jnpRhtRnX4cPCmSesTJk8ITdbL-zuv X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA4MDA3MSBTYWx0ZWRfX3WFQ44wsPuKo XAVBUgy1y6GKljBFQ1lrdWeLARuHWOR5HWPJR5IGFD+H+pMBeSeYDvgVb9+s2P7EDsJ3bnpANSb 0jRI6GmMyd9LpBUwFj+EoSaAk7mwEEk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA4MDA3MSBTYWx0ZWRfXxZF8cDxYkaJX x2gWDgl5S9cpUboLbmLUXVRtwLT5o/ETjpYlqPiEiH0ksjs8E4+4WqpsW9XnhDAcqE8rN/jTtuZ cBieY3i/fbENokfBNHmXpz/Ln2yMihtmGhrZx9NcsHgFoF2MJMwQg+0jZHlR4kk2mU9wBT95Ed6 JICqMdZrFy9YIRqiFRHL+CCvXnK2mAc0+chBkcWvQmk3KBtcWdNSwfYxpbq3CQNco9IppTKN2Ro zSuEvMS5cbpmrXj+JLbkD/Mt9fWLGDecTE2j6FiuORqkWGDlOqT7FHhyS47aXPZrdYs8ueozFqL wmnt3DcFQjej5J9Y0nC96r0H89Mh29mS/fZekSxB91O8SzuSVBKDJQRwQKIjnDSfNHUSG/e1DVT 2+3Ai45sfMgMHGQYLZaWpoao9fHBXIYGlWiSWDhHqjunUhluI0gkk2V3KITU1q1mfaUCPAZe6uD +A7IuyvvqlHXLsyw/LA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_06,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 phishscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607080071 On 7/8/2026 11:45 AM, Praveen Talari wrote: > The GENI I2C driver currently invokes geni_se_abort_m_cmd() directly when > a transfer times out. However, the GENI hardware command cancellation > flow requires a cancel command to be issued first. An abort should only > be used as a fallback when the cancel operation itself fails to complete. > > Introduce a dedicated cancel_done completion that is signalled on Typo :signalled "signaled when M_CMD_CANCEL_EN is received" With this , rest looks good. > M_CMD_CANCEL_EN. The timeout recovery path waits for cancel completion > and escalates to geni_i2c_abort_xfer() only if the cancel command does > not complete within the expected time. > > Co-developed-by: Naresh Maramaina > Signed-off-by: Naresh Maramaina > Signed-off-by: Praveen Talari > --- Reviewed-by: Mukesh Kumar Savaliya > drivers/i2c/busses/i2c-qcom-geni.c | 30 ++++++++++++++++++++++++++++-- > 1 file changed, 28 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index 96dbf04138be..15403edb355a 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -74,6 +74,7 @@ enum geni_i2c_err_code { > #define PACKING_BYTES_PW 4 > > #define ABORT_TIMEOUT HZ > +#define CANCEL_TIMEOUT HZ > #define XFER_TIMEOUT HZ > #define RST_TIMEOUT HZ > > @@ -112,6 +113,7 @@ struct geni_i2c_dev { > int err; > struct i2c_adapter adap; > struct completion done; > + struct completion cancel_done; > struct i2c_msg *cur; > int cur_wr; > int cur_rd; > @@ -361,6 +363,8 @@ static irqreturn_t geni_i2c_irq(int irq, void *dev) > dm_tx_st & TX_DMA_DONE || dm_tx_st & TX_RESET_DONE || > dm_rx_st & RX_DMA_DONE || dm_rx_st & RX_RESET_DONE) > complete(&gi2c->done); > + if (m_stat & M_CMD_CANCEL_EN) > + complete(&gi2c->cancel_done); > > spin_unlock(&gi2c->lock); > > @@ -387,6 +391,27 @@ static void geni_i2c_abort_xfer(struct geni_i2c_dev *gi2c) > dev_err(gi2c->se.dev, "Timeout abort_m_cmd\n"); > } > > +static void geni_i2c_cancel_xfer(struct geni_i2c_dev *gi2c) > +{ > + unsigned long time_left = msecs_to_jiffies(CANCEL_TIMEOUT); > + unsigned long flags; > + > + reinit_completion(&gi2c->cancel_done); > + > + spin_lock_irqsave(&gi2c->lock, flags); > + if (!gi2c->err) > + geni_i2c_err(gi2c, GENI_TIMEOUT); > + gi2c->cur = NULL; > + geni_se_cancel_m_cmd(&gi2c->se); > + spin_unlock_irqrestore(&gi2c->lock, flags); > + > + time_left = wait_for_completion_timeout(&gi2c->cancel_done, time_left); > + if (!time_left) { > + dev_err(gi2c->se.dev, "Timeout cancel_m_cmd\n"); > + geni_i2c_abort_xfer(gi2c); > + } > +} > + > static void geni_i2c_rx_fsm_rst(struct geni_i2c_dev *gi2c) > { > u32 val; > @@ -473,7 +498,7 @@ static int geni_i2c_rx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg, > cur = gi2c->cur; > time_left = wait_for_completion_timeout(&gi2c->done, XFER_TIMEOUT); > if (!time_left) > - geni_i2c_abort_xfer(gi2c); > + geni_i2c_cancel_xfer(gi2c); > > geni_i2c_rx_msg_cleanup(gi2c, cur); > > @@ -515,7 +540,7 @@ static int geni_i2c_tx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg, > cur = gi2c->cur; > time_left = wait_for_completion_timeout(&gi2c->done, XFER_TIMEOUT); > if (!time_left) > - geni_i2c_abort_xfer(gi2c); > + geni_i2c_cancel_xfer(gi2c); > > geni_i2c_tx_msg_cleanup(gi2c, cur); > > @@ -1107,6 +1132,7 @@ static int geni_i2c_probe(struct platform_device *pdev) > > gi2c->adap.algo = &geni_i2c_algo; > init_completion(&gi2c->done); > + init_completion(&gi2c->cancel_done); > spin_lock_init(&gi2c->lock); > platform_set_drvdata(pdev, gi2c); > >