mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xiubo Li <xiubli@redhat.com>
To: Yue Haibing <yuehaibing@huawei.com>,
	idryomov@gmail.com, mchangir@redhat.com, jlayton@kernel.org
Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ceph: Remove unused declarations
Date: Mon, 19 Aug 2024 09:16:51 +0800	[thread overview]
Message-ID: <74549d76-1187-4ed6-9589-e5978ba513d0@redhat.com> (raw)
In-Reply-To: <20240814033415.3800889-1-yuehaibing@huawei.com>


On 8/14/24 11:34, Yue Haibing wrote:
> These functions is never implemented and used.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>   fs/ceph/mds_client.h            | 3 ---
>   fs/ceph/super.h                 | 2 --
>   include/linux/ceph/osd_client.h | 2 --
>   3 files changed, 7 deletions(-)
>
> diff --git a/fs/ceph/mds_client.h b/fs/ceph/mds_client.h
> index 9bcc7f181bfe..585ab5a6d87d 100644
> --- a/fs/ceph/mds_client.h
> +++ b/fs/ceph/mds_client.h
> @@ -559,9 +559,6 @@ extern struct ceph_mds_session *
>   ceph_get_mds_session(struct ceph_mds_session *s);
>   extern void ceph_put_mds_session(struct ceph_mds_session *s);
>   
> -extern int ceph_send_msg_mds(struct ceph_mds_client *mdsc,
> -			     struct ceph_msg *msg, int mds);
> -
>   extern int ceph_mdsc_init(struct ceph_fs_client *fsc);
>   extern void ceph_mdsc_close_sessions(struct ceph_mds_client *mdsc);
>   extern void ceph_mdsc_force_umount(struct ceph_mds_client *mdsc);
> diff --git a/fs/ceph/super.h b/fs/ceph/super.h
> index 6e817bf1337c..c88bf53f68e9 100644
> --- a/fs/ceph/super.h
> +++ b/fs/ceph/super.h
> @@ -1056,8 +1056,6 @@ extern int ceph_fill_trace(struct super_block *sb,
>   extern int ceph_readdir_prepopulate(struct ceph_mds_request *req,
>   				    struct ceph_mds_session *session);
>   
> -extern int ceph_inode_holds_cap(struct inode *inode, int mask);
> -
>   extern bool ceph_inode_set_size(struct inode *inode, loff_t size);
>   extern void __ceph_do_pending_vmtruncate(struct inode *inode);
>   
> diff --git a/include/linux/ceph/osd_client.h b/include/linux/ceph/osd_client.h
> index f66f6aac74f6..d7941478158c 100644
> --- a/include/linux/ceph/osd_client.h
> +++ b/include/linux/ceph/osd_client.h
> @@ -449,8 +449,6 @@ extern int ceph_osdc_init(struct ceph_osd_client *osdc,
>   extern void ceph_osdc_stop(struct ceph_osd_client *osdc);
>   extern void ceph_osdc_reopen_osds(struct ceph_osd_client *osdc);
>   
> -extern void ceph_osdc_handle_reply(struct ceph_osd_client *osdc,
> -				   struct ceph_msg *msg);
>   extern void ceph_osdc_handle_map(struct ceph_osd_client *osdc,
>   				 struct ceph_msg *msg);
>   void ceph_osdc_update_epoch_barrier(struct ceph_osd_client *osdc, u32 eb);

Reviewed-by: Xiubo Li <xiubli@redhat.com>

Thanks!



      parent reply	other threads:[~2024-08-19  1:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14  3:34 Yue Haibing
2024-08-14 11:56 ` Jeff Layton
2024-08-16  7:34   ` Ilya Dryomov
2024-08-19  1:16 ` Xiubo Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74549d76-1187-4ed6-9589-e5978ba513d0@redhat.com \
    --to=xiubli@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=jlayton@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchangir@redhat.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®