From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757531AbcAaNAa (ORCPT ); Sun, 31 Jan 2016 08:00:30 -0500 Received: from mail.eperm.de ([89.247.134.16]:60436 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757319AbcAaNA1 (ORCPT ); Sun, 31 Jan 2016 08:00:27 -0500 From: Stephan Mueller To: Dan Carpenter Cc: Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] crypto: keywrap - memzero the correct memory Date: Sun, 31 Jan 2016 14:00:16 +0100 Message-ID: <7459893.TVu3jshKD9@positron.chronox.de> User-Agent: KMail/4.14.10 (Linux/4.3.3-303.fc23.x86_64; KDE/4.14.16; x86_64; ; ) In-Reply-To: <20160130143828.GC3462@mwanda> References: <20160130143828.GC3462@mwanda> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Samstag, 30. Januar 2016, 17:38:28 schrieb Dan Carpenter: Hi Dan, > We're clearing the wrong memory. The memory corruption is likely > harmless because we weren't going to use that stack memory again but not > zeroing is a potential information leak. > > Fixes: e28facde3c39 ('crypto: keywrap - add key wrapping block chaining > mode') Signed-off-by: Dan Carpenter Acked-by: Stephan Mueller Thanks Stephan