From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2483739-1516657791-2-3864801195544925203 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='utf-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-serial-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516657791; b=ZVMNY7g/Nf4m3OMQixeVJwbeM2EonCIU+XU6Uy5K6P6eWE9 AqgDd6E8u3XeQGbV8mnfZmDSUs1DnQMxX9gLIaBTEu4bI1P6xzoJnuTJ2RlGg+HF BzRZSiIRQ49p+kcoi3Twh0kTobcdCBIE7r5ZRk0ISCBHWb8qQdNBpFwXXP7lyPln 97OqcezcrHTKx+VAvWvkXoKUGbKhxV4FknT/1w7z6M9M3WdeEixKg85Qs2k2Cv9X 3FnSmpiq0dqPdfTTVRgoG7kPYPnOlSlt10+QyUcsqrU0LJbOXwHA9u816Ud4M84X H9ygIyCA5inq/yUEHoneruw6iG29acu+BPSWYAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=subject:to:cc:references:from:message-id :date:mime-version:in-reply-to:content-type :content-transfer-encoding:sender:list-id; s=arctest; t= 1516657791; bh=MKAsVNIM7ctq/icQaqXp/quGGvEImoVzp4YDLC7/Ijg=; b=O OzcLI0Uo9OXZdujVVvQmarDwU7bsiUxMXk1Iu5MyWSYvCfPaYeNaF7NxQATl1n3P il4nY+7zIsUOkZF1gaXuYz9cdA/+ZX8BdEyZiffPwAyD85U6YUn+MEqJH/EXLkRh JGTBGIQGY4OtD04Zt2BbcMx5Xq7NeKAuD3veDjpuZ644GGN90kFjjuvJz8hl3cqG PIdYbyoQ8DJlUtVw8aUbjGKZV0mekQNE3l9QfFijZYMF2/RHGzqlApNxe5FTYysM 2mLK7O5YHToSXhs25xjaMAxIjefFvRff+NuI5Do/XiiV0rnQQzSRFbXXf7XCPIYN gQ3f9tGJdlM4X3YXkugrA== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 1024-bit rsa key sha256) header.d=codeaurora.org header.i=@codeaurora.org header.b=SAjujYz+ x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=default; dkim=fail (body has been altered; 1024-bit rsa key sha256) header.d=codeaurora.org header.i=@codeaurora.org header.b=ebewaB38 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=default; dmarc=none (p=none,has-list-id=yes,d=none) header.from=codeaurora.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-serial-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=codeaurora.org header.result=pass header_is_org_domain=yes Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 1024-bit rsa key sha256) header.d=codeaurora.org header.i=@codeaurora.org header.b=SAjujYz+ x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=default; dkim=fail (body has been altered; 1024-bit rsa key sha256) header.d=codeaurora.org header.i=@codeaurora.org header.b=ebewaB38 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=default; dmarc=none (p=none,has-list-id=yes,d=none) header.from=codeaurora.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-serial-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=codeaurora.org header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751071AbeAVVts (ORCPT ); Mon, 22 Jan 2018 16:49:48 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:44102 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038AbeAVVtr (ORCPT ); Mon, 22 Jan 2018 16:49:47 -0500 X-Remote-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Remote-Spam-Level: X-Remote-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 589EA60328 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=timur@codeaurora.org Subject: Re: [PATCH] acpi, spcr: Make SPCR available to x86 To: Prarit Bhargava , linux-kernel@vger.kernel.org Cc: linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-serial@vger.kernel.org, Bhupesh Sharma , Lv Zheng , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Jonathan Corbet , Catalin Marinas , Will Deacon , graeme.gregory@linaro.org, mark.salter@redhat.com References: <20180118150951.28964-1-prarit@redhat.com> From: Timur Tabi Message-ID: <745c9e29-f0b4-775b-28f7-8712cdc90fe1@codeaurora.org> Date: Mon, 22 Jan 2018 15:49:43 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180118150951.28964-1-prarit@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-serial-owner@vger.kernel.org X-Mailing-List: linux-serial@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 01/18/2018 09:09 AM, Prarit Bhargava wrote: > if (acpi_disabled) { > - if (earlycon_init_is_deferred) > + if (earlycon_acpi_spcr_enable) This patch works for me, so I can ACK it, but first you might want to rename earlycon_acpi_spcr_enable, because these two lines don't make much sense. "If ACPI is disabled, and ACPI SCPR is enabled, then ...." If ACPI is disabled, then how can a variable called "earlycon_acpi_spcr_enable" be true? Would it make more sense to rename it to earlycon_spcr_enable? -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.