mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>,
	alim.akhtar@samsung.com, avri.altman@wdc.com,
	James.Bottomley@HansenPartnership.com,
	martin.petersen@oracle.com, beanhuo@micron.com,
	can.guo@oss.qualcomm.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	op-tee@lists.trustedfirmware.org, jenswi@kernel.org,
	sumit.garg@oss.qualcomm.com
Subject: Re: [PATCH 1/2] ufs: rpmb: retry power-on UNIT ATTENTION on the RPMB WLUN
Date: Fri, 17 Jul 2026 14:10:28 -0700	[thread overview]
Message-ID: <745f117a-253a-4b17-ad87-710f330c56c5@acm.org> (raw)
In-Reply-To: <20260715214327.1933560-2-jorge.ramirez@oss.qualcomm.com>

On 7/15/26 2:39 PM, Jorge Ramirez-Ortiz wrote:
> +	/* Retry the power-on UNIT ATTENTION (ASC 0x29); the SCSI core does not. */

If this patch is reposted please leave out "; the SCSI core does not"
because most developers consider scsi_execute_cmd() as a SCSI core
function. Hence, this patch makes the SCSI core retry upon a power-on
unit attention. Otherwise this patch looks good to me.

Thanks,

Bart.

  reply	other threads:[~2026-07-17 21:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-15 21:39 ufs: rpmb: make RPMB usable with OP-TEE key derivation Jorge Ramirez-Ortiz
2026-07-15 21:39 ` [PATCH 1/2] ufs: rpmb: retry power-on UNIT ATTENTION on the RPMB WLUN Jorge Ramirez-Ortiz
2026-07-17 21:10   ` Bart Van Assche [this message]
2026-07-15 21:39 ` [PATCH 2/2] ufs: rpmb: use a fixed-length RPMB dev_id Jorge Ramirez-Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=745f117a-253a-4b17-ad87-710f330c56c5@acm.org \
    --to=bvanassche@acm.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=can.guo@oss.qualcomm.com \
    --cc=jenswi@kernel.org \
    --cc=jorge.ramirez@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=op-tee@lists.trustedfirmware.org \
    --cc=sumit.garg@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox