From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E7E1C6FD1D for ; Fri, 17 Mar 2023 15:51:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230314AbjCQPv0 (ORCPT ); Fri, 17 Mar 2023 11:51:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230357AbjCQPvX (ORCPT ); Fri, 17 Mar 2023 11:51:23 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27DCAB0B99 for ; Fri, 17 Mar 2023 08:51:21 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id y4so22230216edo.2 for ; Fri, 17 Mar 2023 08:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679068279; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VgbCEwBBaMJgjzTFKLCTgfUkZg+a1TMJ6pPEoqV63Hc=; b=LwuCElSXbXOCVZGj7kYeemZnW62++O0ppaxM7gnXTHJSYAyJpXJoVkQ6DwBOhLNaMJ Kf4s1x9Cc69FYIaJywiJMkt86sBWGheEfqggTlkg3v9Qs5LctnwnQfXKWmbQDk3Yuh9r g+tDtl8BlfPDL8GXvh6KyA5aggB1LpL2rV2UcjyA/qytvb7zxpgXFIc7eutHCtx14aze Y3byhgJcqb5+9UzImhKpn/GG+qN+lbe4sQLDvqmeBBegMst5k512i+IlC6pkBjt0sob4 LaGs8Ob+BCPvmVjLrMR3UT2NUe4h9u7+3b91+l88eUdb624n8f9Od8Re/7TIJK49RGpT roCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679068279; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VgbCEwBBaMJgjzTFKLCTgfUkZg+a1TMJ6pPEoqV63Hc=; b=D2+A/EP/lEY5CMWC7YhzgZITy2yOe17g8E0S5O1pp5Z5PXCTvCv+XRv3dqkM4urDvo doEBV0laE9BzVR4ya/OV+dta1RemBbNgSLiA54nCO1Yl5S9hZwqa4C8OVUSTINpGrsr1 1DctOmy8RIg0r0fd7tccwOfZWGWLAOZlFHGsvMZny0tV35TudZuwhms2V99aLf5WWuAq iPl/dJrRopQz9QCbkpqNwZnVNqXAMaZgUzjFZu+z8UUdRUNzbIl/z9DKiLui8KJy37b1 fy8DbUBBYzNRHYmxbdukHjYrW9cMdOTXeaWLfZ6wEdt49FgOplNWxmj+2SgJ6HlaaVlU AykQ== X-Gm-Message-State: AO0yUKUJ7xuOnuvfSlJXm0mGgqgxQuBxbPWUM+PEXYNSBEVjhQuQtSGu tGUm246GMjOcQAnjjht4SOl19A== X-Google-Smtp-Source: AK7set+le+sP+6r2wPX7W1qxTD9Ck//nvh8FN3PUI0b+9ZyihWQUg3l+YvlQhJ034uCNeDK4yazy9w== X-Received: by 2002:aa7:db97:0:b0:4fb:fd22:29b6 with SMTP id u23-20020aa7db97000000b004fbfd2229b6mr3165846edt.40.1679068279633; Fri, 17 Mar 2023 08:51:19 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:d013:3eeb:7658:cec? ([2a02:810d:15c0:828:d013:3eeb:7658:cec]) by smtp.gmail.com with ESMTPSA id k12-20020a50ce4c000000b004af70c546dasm1226755edj.87.2023.03.17.08.51.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Mar 2023 08:51:19 -0700 (PDT) Message-ID: <7469290a-0671-7d2f-b0ce-cdde2a9e66cc@linaro.org> Date: Fri, 17 Mar 2023 16:51:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 1/2] dt-bindings: spi: add loongson spi Content-Language: en-US To: zhuyinbo , Mark Brown , Rob Herring , Krzysztof Kozlowski , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jianmin Lv , wanghongliang@loongson.cn, Liu Peibao , loongson-kernel@lists.loongnix.cn References: <20230317082950.12738-1-zhuyinbo@loongson.cn> <20230317082950.12738-2-zhuyinbo@loongson.cn> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/03/2023 11:00, zhuyinbo wrote: >>> +properties: >>> + compatible: >>> + enum: >>> + - loongson,ls2k-spi >>> + - loongson,ls7a-spi >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + clocks: >>> + minItems: 1 >> I don't understand why did you change it. I did not ask for it. >> >> Best regards, >> Krzysztof > Add clocks "minItems: 1" description is for fix yaml file compile issue. minItems: 1 is not correct, so you cannot use incorrect code to suppress some warning. This should be list the clocks or use maxItems: 1, if you have only one clock. Best regards, Krzysztof