mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Arimil <renari@arimil.com>
Cc: Aleksa Savic <savicaleksa83@gmail.com>,
	Will Smith <github@notthatwillsmith.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] hwmon: (asus_rog_ryujin) Add per-device configuration
Date: Thu, 13 Aug 2026 04:14:16 -0700	[thread overview]
Message-ID: <746d6546-0239-41af-abf2-2631beefc85c@roeck-us.net> (raw)
In-Reply-To: <CADBHdQ2up=rcwC=GgVBO382H41uxep-Z7XD6gtnTpZBi-KcpJA@mail.gmail.com>

On 8/13/26 03:07, Arimil wrote:
> On Thu, Aug 13, 2026 at 12:57 AM Guenter Roeck <linux@roeck-us.net> wrote:
>> This is introduced by this patch and thus irrelevant for the commit
>> message.
>>
> 
> Do you want me to make a v4 to fix this?
> 

No need; I'll drop it when I apply the patch.

>> We are too close for me to accept this series without independent
>> Tested-by: and/or Reviewed-by: feedback. I plan to apply it after
>> the next commit window closes.
>>
>> I won't mandate that the issues reported by Sashiko are getting fixed,
>> but I wuold strongly suggest for the users of this driver to have a look
>> and consider fixing them. The issues look very real to me.
>>
> 
> I have already started looking into fixing them but since this is my first ever
> kernel contribution I was avoiding expanding the scope of this series
> unless you explicitly asked for them to be resolved.

As I said, not as part of this series, and I had hoped that Aleksa would step in.

Thanks,
Guenter


  reply	other threads:[~2026-08-13 11:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-12 10:35 [PATCH v3 0/3] hwmon: Add ASUS ROG Ryujin III support Arie Miller
2026-08-12 10:35 ` [PATCH v3 1/3] hwmon: (asus_rog_ryujin) Add per-device configuration Arie Miller
2026-08-13  4:57   ` Guenter Roeck
2026-08-13 10:07     ` Arimil
2026-08-13 11:14       ` Guenter Roeck [this message]
2026-08-14 17:30   ` Aleksa Savic
2026-08-14 18:20   ` Guenter Roeck
2026-08-12 10:35 ` [PATCH v3 2/3] hwmon: (asus_rog_ryujin) Add ROG Ryujin III support Arie Miller
2026-08-14 17:34   ` Aleksa Savic
2026-08-14 18:21   ` Guenter Roeck
2026-08-12 10:35 ` [PATCH v3 3/3] hwmon: (asus_rog_ryujin) Add ROG Ryujin III White Edition Arie Miller
2026-08-14 17:35   ` Aleksa Savic
2026-08-14 18:21   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=746d6546-0239-41af-abf2-2631beefc85c@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=corbet@lwn.net \
    --cc=github@notthatwillsmith.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=renari@arimil.com \
    --cc=savicaleksa83@gmail.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®