From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACACAC4167B for ; Fri, 8 Dec 2023 09:25:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573426AbjLHJZh (ORCPT ); Fri, 8 Dec 2023 04:25:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233238AbjLHJZd (ORCPT ); Fri, 8 Dec 2023 04:25:33 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7141F171C; Fri, 8 Dec 2023 01:25:39 -0800 (PST) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B89GRZG012002; Fri, 8 Dec 2023 09:25:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=4PjOLiFFmML10b2IGM2FgxHX2eg4l+9eS6oUXWvGhkQ=; b=fsJ6a5J4L/bJYuGMTuGh7/fcdP3xKAOmgjrL+rV8eKADzVltMuwvyG8gTDe4yMe0U7V1 M1dWCcTeCxo3F52XEoRnp8r+1Q5JnPiXbMtBdelXTD20sO8CgqxVDPHKLMsblmipQjIb oh0oKEWrbIUdesKr2j5CWfWeVnWoOwUT/oAlryaB3J/mvcnTO8grL9mNXfh6fF5fA2SY buHSYuMBNIfLbO1voydakHfGHkSgogkoAwAW2stdlj08oR5l6GDVVL9Gs3P73kjotMX9 QELGr5cbeiIqGUG9tcxQ3lR1Idytzy6sKl5nYUlQtU1seLXX9B5Xa2lwFwrDFxz9jLVf Lw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3uu928kcfk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Dec 2023 09:25:31 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3B89PTd9027477 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 8 Dec 2023 09:25:29 GMT Received: from [10.50.44.194] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 8 Dec 2023 01:25:26 -0800 Message-ID: <7472fe73-e7a0-5c8c-6e85-655db028a5c3@quicinc.com> Date: Fri, 8 Dec 2023 14:55:21 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v2 05/17] scsi: ufs: qcom: Remove the warning message when core_reset is not available Content-Language: en-US To: Manivannan Sadhasivam , , CC: , , , , , , References: <20231208065902.11006-1-manivannan.sadhasivam@linaro.org> <20231208065902.11006-6-manivannan.sadhasivam@linaro.org> From: Nitin Rawat In-Reply-To: <20231208065902.11006-6-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: pFoOcZVQRYLqNQkkvC_Kghosb4o2VXoc X-Proofpoint-GUID: pFoOcZVQRYLqNQkkvC_Kghosb4o2VXoc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-08_04,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 mlxscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 clxscore=1015 bulkscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312080076 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/8/2023 12:28 PM, Manivannan Sadhasivam wrote: > core_reset is optional, so there is no need to warn the user if it is not > available. > > Reviewed-by: Andrew Halaney > Signed-off-by: Manivannan Sadhasivam > --- > drivers/ufs/host/ufs-qcom.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index dc93b1c5ca74..d474de0739e4 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -296,10 +296,8 @@ static int ufs_qcom_host_reset(struct ufs_hba *hba) > struct ufs_qcom_host *host = ufshcd_get_variant(hba); > bool reenable_intr; > > - if (!host->core_reset) { > - dev_warn(hba->dev, "%s: reset control not set\n", __func__); > + if (!host->core_reset) > return 0; > - } > > reenable_intr = hba->is_irq_enabled; > disable_irq(hba->irq); Hi Mani, I think core reset is not frequent. It happen during only probe ,error handler. core reset is needed in kernel to cleanup UFS phy and controller configuration before UFS HLOS operation starts as per HPG. Having existing warn print can be used to to debug or atleast know core_reset is missed in device tree to give indication complete reset hasn't been done and we could still be operating in bootloader configuration. Regards, Nitin