From: "Horia Geantă" <horia.geanta@nxp.com>
To: "Andrei Botila (OSS)" <andrei.botila@oss.nxp.com>,
Aymen Sghaier <aymen.sghaier@nxp.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: caam/qi2 - add support for dpseci_reset()
Date: Thu, 28 May 2020 18:41:55 +0300 [thread overview]
Message-ID: <7474713b-93b1-6f8b-600b-08d473ca92c4@nxp.com> (raw)
In-Reply-To: <20200528110450.11279-1-andrei.botila@oss.nxp.com>
On 5/28/2020 2:05 PM, Andrei Botila (OSS) wrote:
> @@ -4698,6 +4698,9 @@ static void dpaa2_dpseci_free(struct dpaa2_caam_priv *priv)
> struct device *dev = priv->dev;
> struct fsl_mc_device *ls_dev = to_fsl_mc_device(dev);
>
> + if (DPSECI_VER(priv->major_ver, priv->minor_ver) > DPSECI_VER(5, 3))
> + dpseci_reset(priv->mc_io, 0, ls_dev->mc_handle);
Even though dpseci_close() should be called in all cases,
a warning when reset fails would be useful.
> +
> dpaa2_dpseci_congestion_free(priv);
> dpseci_close(priv->mc_io, 0, ls_dev->mc_handle);
> }
prev parent reply other threads:[~2020-05-28 15:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 11:04 Andrei Botila
2020-05-28 15:41 ` Horia Geantă [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7474713b-93b1-6f8b-600b-08d473ca92c4@nxp.com \
--to=horia.geanta@nxp.com \
--cc=andrei.botila@oss.nxp.com \
--cc=aymen.sghaier@nxp.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®