From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752538AbdK1M51 (ORCPT ); Tue, 28 Nov 2017 07:57:27 -0500 Received: from mail-ve1eur01on0114.outbound.protection.outlook.com ([104.47.1.114]:6746 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752417AbdK1M5W (ORCPT ); Tue, 28 Nov 2017 07:57:22 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: kasan: false use-after-scope warnings with KCOV To: Mark Rutland , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Alexander Potapenko , Dmitry Vyukov References: <20171128123555.mo4ikj2ru6mkibwo@lakrids.cambridge.arm.com> From: Andrey Ryabinin Message-ID: <747765dd-b156-9388-6471-bb0f9a256a89@virtuozzo.com> Date: Tue, 28 Nov 2017 16:00:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171128123555.mo4ikj2ru6mkibwo@lakrids.cambridge.arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: AM0PR0102CA0072.eurprd01.prod.exchangelabs.com (2603:10a6:208::49) To DB6PR08MB2824.eurprd08.prod.outlook.com (2603:10a6:6:1d::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e19bf5ed-9700-4017-b028-08d5365f8f6f X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(7168020)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:DB6PR08MB2824; X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2824;3:eQrjcuYSqUvtKnDitsblJcqt7BrITY/LjGc/SuXPApRkFQL0vTlRvjwaDbrUHa1XmQqCxRyFEYcSplCiTwfhsRlCNhBGmvpyXVDZagWP8d/aNdA6KRR81EWPoLyGtSE4XcT9ma23wWhFYM29pkDz6JOsguv0InFpiSTYMsyWLPIEJCVUNhWVdVKjiPdBT8s1WpilpFXUr5ZjJl6UKbcd7mctC7fp5w9Sdafe9E+8K7L5fG+jdvsl1FBzR8bQqFxz;25:mtepbpSQlk1egglETyrJsJT+JqBMwl8S8xRSwCZQnQUshaH3F6973w+H6JhBcyMHykyAOJbwEdmxS9XZ6FgVlupVFD8I9rwtoXzSF39MfnIjzuFrc7Wn1jRZRCvvPkSapLjrJS4wybm8DWmO6yewwZGdNtuRVYQxEkOUq8SIje2TYYkuAN9s0UrJkowLYBidpriqHymD8P+IYjc5r7KQw2Iw9/urEGfU4Yr2lxVVLHTQA7pFmOyNEmC0T0bvNOb0ayODbjUHfFtoJLQ1bEzfAic2F22BV0i81nJfc28ylrE9RfPwxmp9f5guVWZIYLSnFItu6hW1pmhGoTVXDpLLMQ==;31:N8jo2PbI3RNlXb6RcpC0DeBM8k2kJKCKQ0QhLAWEbYHcgF8XdGhbDh12z7LTkN0qbp7Qn26Vxy65vynSlyp69NvtdO8jIiSXRjWIKigUw7E5uC7IQO2Jej7U/NYN0+gbu9O/yASsWl9qp5Xifo2SQJeK6Y1Ha07ELnUXKg7QOGyRg/05JqZghwMJZSoLGWBuGEoQOnzPNNAlCO++30XqYSmgdzsxnU0LwnM8ScVeR4c= X-MS-TrafficTypeDiagnostic: DB6PR08MB2824: X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2824;20:ntGL6bRKk9WUyneGBvkFVrSmHf7b9QYxHkIwpg/x/fh7ISJTspwbxa5nyJe/BbVtqf+F4/GQBv4Yv6WZP9BxOXZW6MeAHkMBQ0+DaZbMlS5YLR4XjaS1V+IAQTGOXLWztF6iyizHxFPcEPCoZR/Fb1+XC3GwWTwNTsa1u3z6MwID4Vvu0GmNZMCXbCL0wi4p6eBuoatGXWCGVqklZnC0fT/Axsf2f9ocK9Ggr5Z6oos9R6L2QLuU0pJ2IK9w+zUQtF2lUz+eyaOiI6tL2F5xxfmhblDN2A8MEoGZVQyFtuPX0rvKxydJsqYgQriG5coQM4J0rz9ZBFw7aqZAm7hS/x7d9AT3xry4M/tsMyqKijpdUKTZ8PSlJzwcZLW18Qx6KjaM4ijJtY/L3V8Hoj9Td7a5uEcFS2PFXs5p8EGaLOQ=;4:orxC4Pn2GyqS2qnHwxnTuHiAdC783lYOJ9ULwxubR1rXxo+H0Gql9dqt82OyqQ2qKviFVJQdDnhb8uxxdJSJCeFVgmgEVVwhY2wfPfg5bOt1EI4ZYJ4XHzF4boCHL6E0l+fsVk3fRht4D+vF1b0X6RjeZCgOStRYk7/4Pt0+W6p0ZTD3MdKwr6zvbyDq0E7Cy8t260oCIj6BYe8f5feoNyb5gGkqWJZ5Zo5ZPF4YwClg9VB8XEuj0JKmgcx7HX4KLzI9K7Ua/PGAWIzOhmsmy/QfU2UkYCdtBaQILwq+rO5nPIglHlNBpDGn6VyHIumnptFQZFPXUbrpSwKwrPIARiLOMHz2Em8f8Q8S2sgCU9eGm7mJafo9bHjkGJ5VdhMgAy8Pe1VK+9cDqjBp6gL1Pv9vQii6dlVfn/0aOKKAG3U= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(20558992708506)(42068640409301)(211171220733660)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231022)(93006095)(93001095)(6041248)(20161123562025)(20161123555025)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011);SRVR:DB6PR08MB2824;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DB6PR08MB2824; X-Forefront-PRVS: 0505147DDB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(6049001)(366004)(346002)(376002)(24454002)(189002)(199003)(54356999)(50986999)(76176999)(36756003)(53546010)(6116002)(3846002)(966005)(478600001)(101416001)(81156014)(81166006)(105586002)(2906002)(8676002)(31686004)(53936002)(189998001)(106356001)(8936002)(230700001)(229853002)(6306002)(4326008)(305945005)(25786009)(230783001)(33646002)(65826007)(55236003)(83506002)(47776003)(7736002)(65956001)(68736007)(5660300001)(77096006)(6486002)(6666003)(66066001)(16526018)(316002)(50466002)(86362001)(31696002)(58126008)(16576012)(97736004)(64126003)(52146003)(52116002)(54906003)(23676004)(6246003)(2950100002)(2486003)(65806001)(505234006);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR08MB2824;H:[172.16.25.12];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA4TUIyODI0OzIzOmt2WDlPSS9xSGFGSFUrc2lIOVZtV3pJRy9W?= =?utf-8?B?VWNjWmlMRU9KOTlhbjVzNkEwRk1XT3dSdGEraEFPYXhrWlJRRWxuV2R2L3VS?= =?utf-8?B?bXc5c1lKS3hIOHFNM0tobzg1NytFOVlvdDh5ZlozY0RCVk9SeVJOaWRHM1cr?= =?utf-8?B?ZmR5SnFHRHE1Ylo4U05OZzFsQ091MG01aE5WeStLY1djOCtFV0JoS1JKT29S?= =?utf-8?B?Y21HTkx5VE1MZUp5ZzRyQXBaajN6U3NoeFgxYmFxaGJNSUJxbUJONXBCRzcx?= =?utf-8?B?Z1ZhZWhNS20wb0duVUhHUE45WVB2ckZmL1N0eFk1U0F2UUVGWjgvSE5tQVhm?= =?utf-8?B?dVV6cThKdHBlbzVTbHlWWUh4c21GS0xRZUd4a0hGS3NTRnBJd1NNRDJ6cXJE?= =?utf-8?B?NWIyUmNoRGRmWWplVHFNSDZQNTlua3gxWnRpdVZYcTVWWEZ1SlJYa1lubHFC?= =?utf-8?B?Sm5VaXh6NE1mYTNMWWVBZjF4RlorVW56K05yRCttbHJmUnQzOXJ5V1pjcUxK?= =?utf-8?B?OWZZUE1zVjlBQXlYbUU1eXFnV2ZTbWhSRldEMFBjRGNZd2pVZW1yeGIzQzJ0?= =?utf-8?B?WldtWFhSRXppdjNFN09OMEtuQkFPeUVJRWwxc2YzRFJEMjFsQ25OYkw3MUNk?= =?utf-8?B?U3NVSFA4em9TZmJuSjl4ZXJ1NHAvQTl6S1JPbW16YTRHbEljS0FadXRrNHR5?= =?utf-8?B?WnoybkdJWDhrNGJoQjZLd0hFcllxcTZvN0xtS1NFTGtMZnlFWURwaDdoRkow?= =?utf-8?B?ZzNXR3k4UEs1NFRtc0hteTZJZXhjTEZib1Z0a1o0RlNMdzFsMjlKWUFBUHZ4?= =?utf-8?B?aHQyMFdXS1NWbXJhUGpSUGtHYjdyRjZsaDdhZ2xzTDdRemgyVmVyTnNRWkkr?= =?utf-8?B?bm16TGZZUzZSQnJpRWQ1SmoxelVFY1RuaXA4UmtTQTJVQ3ZBc2h3VVNtQjBv?= =?utf-8?B?aUlHV2ZGSEpnZDhJQUt5aW85aTBzYi9RVC9HVGprU0R6bXFSTkJPeVI0S2dW?= =?utf-8?B?MzdVTkV5bHJDVVNZUDNLRVRvZitVaEs2VTgvd2cvZE5aeEtISnZmNldBNy8w?= =?utf-8?B?Tld3K3A1OWs0NTZQa1VKNVJWdEtldWRIT292RG0wVGRBdWc0endYSUZOZkdG?= =?utf-8?B?V0ZHUEJ5bUxqZFhHeGpWKzJrZ2NmTWU3b3I1YXYwUlpEVlZoeVZtZ1ZoQS8z?= =?utf-8?B?MWtaYXp2Ryt3WlBrL1ZEZ3A0VDVWdTZqd3F4TUlWRlFydHNOSDBoZ3NCM0Jj?= =?utf-8?B?K0ZtcXpnbS9oYXhBVXZycGlTa0M4OU8vWlh4WjNHV0tPQmdoM3dRbjRvdEhp?= =?utf-8?B?bXcrU2ZDYUQ3RCtSYUhOckJsdlJPTWFKT1V4dGVaM3hzWjBXVkdkTkprc0VD?= =?utf-8?B?VjAwOGRjNWV1Q2syUkViLzR6YjlwdjhVM1pFa3BFYWV6TXFUNHpOaElhTTd5?= =?utf-8?B?N3BKYUM3aThjNkFlS2hTbXltVzZrbUIrcjQ0VkpScURqWkZYVXhoZW9IaXFY?= =?utf-8?B?WnI2NmhBZnRIYVlyVCtpUTN5Nmd4dkUyazlrdEZqMDVMMDVOUmtKZE5qTWp1?= =?utf-8?B?V0I2QzFaZ3p6N0pxWWswcXFpUnp1czlkR3Bkcm43TlJBK1h5YXFEZ3VpQW84?= =?utf-8?B?REVMbnVock0vMFpDeUhQNXh4WjB6WjY5MTZkN1RIMHhhK2dQZkxOYUtocDhM?= =?utf-8?B?clJ1T1ZmTWFRekNBSVZGd0lsR2pmN2t3QVk1ZUZ0LzJkakhBMFJNVUV3SkZr?= =?utf-8?B?ZkpBNzVlMXhMS2J1Vm00bmdSckRlT2txWUN3NHlDcDZPR24yWFI1eG4xMllV?= =?utf-8?B?SDdLeHZxWVdabllGNGZmcy9jVHUxc0dBci92NXZNbmpLUzBkazBmOWRhelNM?= =?utf-8?B?cldRakVMeEpnSEZhMzhqWjZwWFlWWVhTeThQVDJmeUNLQmVjd3Z5Tkg5UFFz?= =?utf-8?B?SnNETHMxc0pRcUJCaW9zdm1mY0pMQTQxZ1FIQVl5Szd4TnF4Vno4b1ovOGVQ?= =?utf-8?B?UEIwNVIrSjFHN255UnkvbkFHZzl5M09ERVk1UT09?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2824;6:Ut8BnOxZxhbUghFvgJA07L/vXYuaIHRIsRYityCJOSz+z8cFGQs36boneqjsByZ2Yh3KrkjfwpKblC0KkBgu1b09zWp+VvAutFwB5ynKpJ5pSKef1w/u6o8wTcqudTd8+Fw9tSvHFaN0cgD0jKHCA/kU8234v9AIaAcw1k/z9azAeAp2f39v5RqviTzlziNMCkKo4ECVg+3E8ppN4HAKroKYjJUk2C7omtBl79x97/iVuGxvYe2l3bFnGMJ7oAs8qfZUIn+7XCBw7OdsVst1bbbdN9d3V87c7LLogM8EFoOSHHbeQ4+qJp/oKyYmbDLGdV5OtbygGED/adeyNZyryV3Qoy77xBAkBq3y2Ck/I1U=;5:HbS52M5qTMWuMhov0xgdgjvqbMDH13caAcKuEJymjxJd1k7y8rhZrajLMNGsPQNmTWCNeB+MmianSv7umCNGlZxTiZFafdk6oZNAS4MXEk25OJS/3PVQJfXTSp3h99MHP/xbYQdiNefWkeDN1/OaBBNHj0qgWFyUbvLag7lUy9M=;24:sZ6U8CsS9DOTYhiGFrIxHOOVaD5/wdQXdkZo3kiYBsVQmni9uJIrcPMCsTRuAY1rL4IUl8eYrHqyDqVuc/21gO5bul879Ig/BubwxSXjomI=;7:OLpc4tWq8zNRfNPtPNs+eTIiiJhatj3napkjD/yjmBzkwdrcJmpIOD4u+sUfO41m0Poqe61yJBw3NugV589wfNHAsDdX7KA9EAz4yzuH5l27zXlfRVdb0tAnxgVrpG4WtRLjsVbNJxsNWscklrYIZOZievfkjZo/OSUCfu359hfskSziWJ5dmXMotFi3tjSnOXp+IcepfNHoYmnWszloIoCzssiPyGxZAiIzZ5pxjwR/NkR9g9bfhuI0+807mlyd SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2824;20:xoWPEe/nGmrKcZQmYgiVHgrRIYeY08iJhKaBelA7bg25zPW7TWB+zE/H+eSlbYg2YJjM0Ijafmco48iQNO0V0CfLlLi1IKlY2AiExHrfRz+ggP5es+xvb1ls3qiIN98/+LYpXmc4/A5mzTNMSIqQ6K0agusNeugf75X8ydSksZo= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2017 12:57:19.4516 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e19bf5ed-9700-4017-b028-08d5365f8f6f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2824 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/28/2017 03:35 PM, Mark Rutland wrote: > Hi, > > As a heads-up, I'm seeing a number of what appear to be false-positive > use-after-scope warnings when I enable both KCOV and KASAN (inline or outline), > when using the Linaro 17.08 GCC7.1.1 for arm64. So far I haven't spotted these > without KCOV selected, and I'm only seeing these for sanitize-use-after-scope. > > The reports vary depending on configuration even with the same trigger. I'm not > sure if it's the reporting that's misleading, or whether the detection is going > wrong. > > For example, with v4.15-rc1, defconfig + KCOV + KASAN_OUTLINE, I can trigger a > splat: > > $ perf record true > > [ 37.577497] ================================================================== > [ 37.584702] BUG: KASAN: use-after-scope in __alloc_pages_nodemask+0x104/0x1608 > [ 37.591883] Write of size 24 at addr ffff80092d65f160 by task perf/2430 > [ 37.598452] > [ 37.599944] CPU: 1 PID: 2430 Comm: perf Not tainted 4.15.0-rc1-00001-gaf82bf81ebae #1 > [ 37.607725] Hardware name: ARM Juno development board (r1) (DT) > [ 37.613605] Call trace: > [ 37.616051] dump_backtrace+0x0/0x320 > [ 37.619700] show_stack+0x20/0x30 > [ 37.623005] dump_stack+0x108/0x174 > [ 37.626481] print_address_description+0x60/0x270 > [ 37.631162] kasan_report+0x210/0x2f0 > [ 37.634811] check_memory_region+0x148/0x198 > [ 37.639063] __asan_storeN+0x14/0x20 > [ 37.642624] __alloc_pages_nodemask+0x104/0x1608 > [ 37.647221] alloc_pages_vma+0xa0/0x2d8 > [ 37.651042] wp_page_copy+0x15c/0xee0 > [ 37.654689] do_wp_page+0x404/0xa70 > [ 37.658165] __handle_mm_fault+0xb28/0x13e0 > [ 37.662331] handle_mm_fault+0x290/0x390 > [ 37.666237] do_page_fault+0x32c/0x5c0 > [ 37.669969] do_mem_abort+0xa8/0x1e0 > [ 37.673528] el0_da+0x20/0x24 > [ 37.676477] > [ 37.677961] The buggy address belongs to the page: > [ 37.682730] page:ffff7e0024b597c0 count:0 mapcount:0 mapping: (null) index:0x0 > [ 37.690692] flags: 0x1fffc00000000000() > [ 37.694518] raw: 1fffc00000000000 0000000000000000 0000000000000000 00000000ffffffff > [ 37.702225] raw: 0000000000000000 ffff7e0024b597e0 0000000000000000 0000000000000000 > [ 37.709922] page dumped because: kasan: bad access detected > [ 37.715457] > [ 37.716941] Memory state around the buggy address: > [ 37.721709] ffff80092d65f000: f2 f2 04 f2 f2 f2 f2 f2 f2 f2 00 f2 f2 f2 f2 f2 > [ 37.728893] ffff80092d65f080: f2 f2 00 f2 f2 f2 f2 f2 f2 f2 00 f2 f2 f2 f2 f2 > [ 37.736078] >ffff80092d65f100: f2 f2 00 f2 f2 f2 f2 f2 f2 f2 f8 f8 f8 f8 00 f2 > [ 37.743257] ^ > [ 37.749576] ffff80092d65f180: f2 f2 f2 f2 f2 f2 00 00 00 00 00 00 00 f2 f3 f3 > [ 37.756761] ffff80092d65f200: f3 f3 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > [ 37.763939] ================================================================== > [ 37.771117] Disabling lock debugging due to kernel taint > > $ ./scripts/faddr2line vmlinux __alloc_pages_nodemask+0x104/0x1608 > __alloc_pages_nodemask+0x104/0x1608: > __alloc_pages_nodemask at mm/page_alloc.c:4215 > > ... which is the declaration+initialisation of a local variable in > __alloc_pages_nodemask: > > 4208 struct page * > 4209 __alloc_pages_nodemask(gfp_t gfp_mask, unsigned int order, int preferred_nid, > 4210 nodemask_t *nodemask) > 4211 { > 4212 struct page *page; > 4213 unsigned int alloc_flags = ALLOC_WMARK_LOW; > 4214 gfp_t alloc_mask; /* The gfp_t that was actually used for allocation */ > 4215 struct alloc_context ac = { }; > > ... which is clearly not a use-after-scope bug. > > If I separate the declaration and assignment, I get a splat corresponding to the > assignment to ac. > > I wondered if we were missing some shadow initialisation, so I hacked a call to > kasan_unpoison_task_stack() into dup_task_struct(), but this had no effect. I > also wondered if this was the result of an overflow caused by instrumentation > bloating the stack, but doubling my stack size (from 32K to 64K) also had no > effect. > > Any ideas? I'm a bit confused by this. Search in lkml gave me this: http://lkml.kernel.org/r/<20171128124534.3jvuala525wvn64r@wfg-t540p.sh.intel.com> Do you have GCC_PLUGIN_STRUCTLEAK_BYREF_ALL=y ? Note, that in Fengguang's config, CONFIG_KCOV=y but CONFIG_KCOV_INSTRUMENT_ALL=n, so at least in his case KCOV shouldn't be involved. > Thanks, > Mark. >