From: "Michel Dänzer" <michel@daenzer.net>
To: Joe Perches <joe@perches.com>,
"Zhang, Jerry(Junwei)" <Jerry.Zhang@amd.com>,
Christian Koenig <christian.koenig@amd.com>,
Huang Rui <ray.huang@amd.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
Chris Wilson <chris@chris-wilson.co.uk>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm: Only #define DEBUG if CONFIG_DYNAMIC_DEBUG is disabled
Date: Thu, 6 Dec 2018 15:41:16 +0100 [thread overview]
Message-ID: <747d6c1b-8c0a-8168-bd1e-e969839ff5be@daenzer.net> (raw)
In-Reply-To: <61385d4cb6c9d990427349849d0af28faa3b67af.camel@perches.com>
On 2018-12-06 1:23 p.m., Joe Perches wrote:
> On Thu, 2018-12-06 at 12:52 +0100, Michel Dänzer wrote:
>> In contrast to the 2b case, the pr_debug output isn't visible by default
>> with 1b, so the latter doesn't fit "always produce output" either.
>
> I think you are mistaken here.
Still puzzled as to what you're hoping to achieve with that kind of
language. None of the confusion about this patch has been on my part. :)
> Adding #define DEBUG as Chris did enables pr_debug output
> and is your 1b.
>
> Perhaps your default console logging level is set to a
> non-default value.
I have CONFIG_DYNAMIC_DEBUG enabled in my kernels. The problem addressed
by this patch is that messages from drm_debug_printer are visible by
default (case 2b), whereas they shouldn't be (case 2a, like 1b).
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
next prev parent reply other threads:[~2018-12-06 14:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 16:56 Michel Dänzer
2018-12-05 16:56 ` [PATCH 2/2] drm/ttm: Use pr_debug for all output from ttm_bo_evict Michel Dänzer
2018-12-06 2:43 ` Zhang, Jerry(Junwei)
2018-12-06 9:09 ` Michel Dänzer
2018-12-06 9:33 ` Koenig, Christian
2018-12-06 9:38 ` Michel Dänzer
2018-12-06 9:50 ` Michel Dänzer
2018-12-06 9:39 ` Zhang, Jerry(Junwei)
2018-12-06 9:49 ` Christian König
2018-12-06 9:54 ` Michel Dänzer
2018-12-06 16:46 ` Joe Perches
2018-12-06 17:28 ` Michel Dänzer
2018-12-06 2:40 ` [PATCH 1/2] drm: Only #define DEBUG if CONFIG_DYNAMIC_DEBUG is disabled Zhang, Jerry(Junwei)
2018-12-06 2:51 ` Joe Perches
2018-12-06 9:23 ` Michel Dänzer
2018-12-06 11:41 ` Joe Perches
2018-12-06 11:52 ` Michel Dänzer
2018-12-06 12:23 ` Joe Perches
2018-12-06 14:41 ` Michel Dänzer [this message]
2018-12-06 16:10 ` Daniel Thompson
2018-12-06 16:14 ` Michel Dänzer
2018-12-06 16:22 ` Joe Perches
2018-12-06 9:12 ` Chris Wilson
2018-12-06 9:21 ` Michel Dänzer
2018-12-06 9:28 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=747d6c1b-8c0a-8168-bd1e-e969839ff5be@daenzer.net \
--to=michel@daenzer.net \
--cc=Jerry.Zhang@amd.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=ray.huang@amd.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®