From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB5F8286413 for ; Wed, 30 Jul 2025 12:07:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753877233; cv=none; b=VWfDDx9yXloHznKU4T1lS6IF17iKO08oocl9Y01bEVNxhN7fc3wa08lSnEQPGly/VsS9TCuXE8R6BYPKbltW4Mn9dcsVdp2bEdJpscyv+mjNNknjp899s5FLsXn0q3Lt9An5s/ckYihw0sjOoO/nl56bJkJAj7soDDP+x6Ibz5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753877233; c=relaxed/simple; bh=nzDS3J8Tl4uutqBKhmKxdBPH3AFv6h9o+HqreCGEqhk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lqDoAeeUmHs/1AZEJCi1p4xxIKUNO+ikjPO/LObr1ewo6ZmB6FYDBNDajpF3/xUM2RnAD2YE19O2OsTTNcjE/Hvgrcon7drjSEjrXM21kZzyfHLr9WCMb0gU0HbP3JIKUzauiKdH9OXgVb5GCpZD6VhC1tcf3ANAt/vEFU+GjPY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KfVywomE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KfVywomE" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56U7Ziqd029390 for ; Wed, 30 Jul 2025 12:07:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YXPB8xAVMNnXhcculy8uUbKvbOohXUXRpW6onDRXyIM=; b=KfVywomEGyh5bNld 2Wbq7OIXVEqVAHR6DemCa7a0Ylp5iK0oK3UJ9ccKl3mTf+Djrp8S+GGJtVlX/sQu 4WlgkNELKiE9V5fPb2Z3hMqRLn+7BiK8C6PdLSOz0Riq9ZjoGo+CNS1ddjL22H9W 0SRKpdKPOv3okZfR+LMq7EJech25fJCSgfgvfH0+6DlCEZyiP0raBPkRdfvwHZk3 /dzQLnP08tF1thaMCWBwub+Lzqc6mqJabFNnHmyjbKo04WC38oAiMYHusVtbWTYo AYIXTzaKmEDs0KXcnDEojcGuQUtU4AjXuQNF2oVPFQGT7NbAHXlY668AtR008iwh hqYa+A== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 484qda3kdc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 30 Jul 2025 12:07:10 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4abd7342386so16967871cf.1 for ; Wed, 30 Jul 2025 05:07:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753877229; x=1754482029; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YXPB8xAVMNnXhcculy8uUbKvbOohXUXRpW6onDRXyIM=; b=wDxXB9+8mFPYVPjU0n4m5M0d2HeXS4qxyG0udLDWwW2fRRR5pgpFb13im2ZYFWrFtx V9sxSgLlgIiPKRumNqMDIkGbU71itMSTITX4AphcjjGmzNro+bsN4mp2Ty5+grF5r1uH gAtXBPHNMUhGp+YQ5o0v0azDfxcAYAfP70iHFhPncGForeUF3FM6Vu16AZjaOxVOk9xw IPecQPnBO/Hj+Q4ceBucB5ltU4hh5YMlTE1wGzdEOcr5c25NVjtDUzEx2GNUErdGsgZb lF9UMpII60nFmL6K8Xe20Ep4h9APD+LFf5w4DHSNFLCCO6PDMQWhD387ReRk1K+syzcn v/Qw== X-Forwarded-Encrypted: i=1; AJvYcCWUAyFjAgTxJRB5Ri0tNpbiLx2SOx26c6UUgW2ZVk67BrsSQNng9uGQ11z/d9iHgoTJ6TAo7o2aJ2LMwU8=@vger.kernel.org X-Gm-Message-State: AOJu0YxJx0ljSbL4MvpPtzqwunmh88NrHPDZ1VpxsmkB5G64uYCfhOVy iG0lz09+Qj8D6gnAkPdjlFiQ/UqnI4yOovXxRe9qRDQEBF7QBhFOqx4N1Y1v2ae2zRoDjuDw2Bm jfytMJWNlYgqWMQOu5Zx7Pq1K00PQQKfE0d1U+1dK67CuApBu5HPqzpbhR5DuImaSKQg= X-Gm-Gg: ASbGncvb4lP4n0Kbr/o9eSr79E9il/ORGSFPwPzcWHLCzzG87lsyG31NyUp278g+yOG 0lXXThLnJZQv98Y+sFg9rqQWrDt3YDR6xZP5Reb5k6B/IDL5dTQ9fmhM7dDZw+Wc8gtPpS8qevW 0Y0HyUS2OpFhZBg55Go6ptWGo99m3fzvtDjWq4iLkE36VuNVxqGJjS/eBcKEOT2euatOjgd/A3n m6gatNdNSIaiHRkNopDTK+Ha9vlH8eTjNu/9Z3yrIzkFz7y8TjXgxFSuGiSTnD/8ax49G2zPBOd dKOQ1bfpSzZvjqNDA9o8OD8zj1FK9z/XPFuu9Q78ivyZADo4ahl7MCIG2T5fBVEEVVFJfMtw4Ur P34/WT9JLWvVBlYOyZw== X-Received: by 2002:a05:620a:1989:b0:7e3:49b9:d06a with SMTP id af79cd13be357-7e66f3412c6mr190738685a.9.1753877229198; Wed, 30 Jul 2025 05:07:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH2dFWuV9ypfCgfd4v8j0ZSQkQwxTOTO6AEX7GRCA3ShMfzfTaFvEB2RNG2NOx9CQxbn3Lu1w== X-Received: by 2002:a05:620a:1989:b0:7e3:49b9:d06a with SMTP id af79cd13be357-7e66f3412c6mr190733685a.9.1753877228415; Wed, 30 Jul 2025 05:07:08 -0700 (PDT) Received: from [192.168.43.16] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af6358d2fa9sm732893766b.62.2025.07.30.05.07.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Jul 2025 05:07:07 -0700 (PDT) Message-ID: <747e5221-0fb1-4081-9e98-94b330ebf8c7@oss.qualcomm.com> Date: Wed, 30 Jul 2025 14:07:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 1/3] dt-bindings: sram: qcom,imem: Allow modem-tables To: Krzysztof Kozlowski , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alex Elder Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Alex Elder References: <20250527-topic-ipa_imem-v2-0-6d1aad91b841@oss.qualcomm.com> <20250527-topic-ipa_imem-v2-1-6d1aad91b841@oss.qualcomm.com> <97724a4d-fad5-4e98-b415-985e5f19f911@kernel.org> <68622599-02d0-45ca-82f5-cf321c153cde@kernel.org> <62b0f514-a8a9-4147-a5c0-da9dbe13ce39@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <62b0f514-a8a9-4147-a5c0-da9dbe13ce39@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: U9BgyMt4XAf2-Ez9fcEMUVZiaUJlRUox X-Authority-Analysis: v=2.4 cv=Pfv/hjhd c=1 sm=1 tr=0 ts=688a0aee cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=8yqZ_v4obXD5Xgezft8A:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: U9BgyMt4XAf2-Ez9fcEMUVZiaUJlRUox X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzMwMDA4MyBTYWx0ZWRfX7bgFgZ9Ioy+q 6PjUqpLvRWFkGVcRWol6zQhuJfx8DgikLJ/PE8ElJhq0Ca0ma+yDq26OfW95D0IHiE5wUP81XKr f0qUQxyFRQI0G2bwtyQszdDfL5X6w3caBq9lRd8+3QxyKGh9yZPEpPySgdhNGiwuPugOfEcdy1x oJQ1C3Ug8NZOhgY/M0mou6e1DE0xvUqxJ1GyFHbcEl/V4pMV4cJcR7w85mzFVKwiihyuIRcqie+ +m8FkHuWXcTQJYF4yzgupGS1UyoqjemDlMI5lcn27UY3cghWy8Ar+J1rFTMOamQjsV0eWIePKso rhlvW0sXohzQ4H6yn0IQi3TyjiFoRoNW+V0aDx2jZC/BRfJOZFnGwxJreAnoOxx2g02vIcQbmha X5Q6DBiDxu5K0J8xwkP7jISMzPvH3sqUvX3qIicEY5ZJC23+vp3oyNujeYYgqPFRmedlR9d4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-30_04,2025-07-30_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 clxscore=1015 adultscore=0 priorityscore=1501 mlxscore=0 spamscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507300083 On 7/15/25 8:37 AM, Krzysztof Kozlowski wrote: > On 14/07/2025 19:53, Konrad Dybcio wrote: >> On 5/27/25 1:42 PM, Krzysztof Kozlowski wrote: >>> On 27/05/2025 13:36, Konrad Dybcio wrote: >>>>>> diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml >>>>>> index 2711f90d9664b70fcd1e2f7e2dfd3386ed5c1952..7c882819222dc04190db357ac6f9a3a35137cc9e 100644 >>>>>> --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml >>>>>> +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml >>>>>> @@ -51,6 +51,9 @@ properties: >>>>>> $ref: /schemas/power/reset/syscon-reboot-mode.yaml# >>>>>> >>>>>> patternProperties: >>>>>> + "^modem-tables@[0-9a-f]+$": >>>>>> + description: Region reserved for the IP Accelerator >>>>> >>>>> Missing additionalProperties: false, which would point you that this is >>>>> incomplete (or useless because empty). >>>> >>>> How do I describe a 'stupid' node that is just a reg? >>> With "reg" - similarly to many syscon bindings. >> >> Is this sort of inline style acceptable, or should I introduce >> a separate file? > > It's fine, assuming that it is desired in general. We do not describe > individual memory regions of syscon nodes and this is a syscon. > > If this is NVMEM (which it looks like), then could use NVMEM bindings to > describe its cells - individual regions. But otherwise we just don't. It's volatile on-chip memory > There are many exceptions in other platforms, mostly old or even > unreviewed by DT maintainers, so they are not a recommended example. > > This would need serious justification WHY you need to describe the > child. Why phandle to the main node is not enough for consumers. It's simply a region of the SRAM, which needs to be IOMMU-mapped in a specific manner (should IMEM move away from syscon+simple-mfd to mmio-sram?). Describing slices is the DT way to pass them (like under NVMEM providers). > > If the reason is - to instantiate child device driver - then as well no. > This has been NAKed on the lists many times - you need resources if the > child should be a separate node. Address space is one resource but not > enough, because it can easily be obtained from the parent/main node. There is no additional driver for this Konrad