From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADE0541B360 for ; Tue, 9 Jun 2026 13:02:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781010161; cv=none; b=NgODC86hw7nsGmKGjV1zoEtrdHRK4qhea/IUAyg8LRVQAItW/p/o6xVanuQlD/8G0Szve23c/sAGovPygmQgyzu/hP75O7v2nfys2nZXa7RuuYE8YA4DcdK7ATtJCVY2FKLO6FGWa1/KMoeNjsOjqZUbjp1QLsqoRueS+Q7wA58= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781010161; c=relaxed/simple; bh=XN8hc40Aqohm1Oux1FTd9z3AKS0NcB448jgv5NkarhE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dVw0qQ4Q3usopT9gzdLupxmy2dxNyLtu1VyCRuAWRNMnBI9m63T8wL3nRoSuOWyKMchT0nnUFLCGCMgPHVaoIbJyVJbA2UpAfz53yIlJWax1M00S5JjWhmKJ63erh+EhqV5hKukSnVuEtv8hAFb+xPvzlDDno6QXW3JWKg+bPiU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=juR/rMp9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KFsb5JJ4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="juR/rMp9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KFsb5JJ4" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 659ClZO92183120 for ; Tue, 9 Jun 2026 13:02:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xbHtB5FkcaadoqFbH3R3CLsT+3mMjSYwuCc/ZzU+pvY=; b=juR/rMp9c8O5SUDq lR2VC+Cf03ny9QkPsi1RhTiFv5TqEdSvTLNOanb5ziwG50E8axHc6ZOqw0seTMgq zMF45s5nLRpIet9gRi5rlUgnRWe/nUpP91hzOwevI4z8iNyNwN+fnkPEa+C5NpTA 3uhgNOBNeCdYCDl/9DW38g55oG9Sb/5lXA2SgSDLCWmkp9dt/6BapdL+mIzU3t9v Dq/i1MrsoYLRBBTLnNw8LzxAJ3bbKP74hZjlMWoc7EUsavmRndvnRgK073aneVg8 rLKKI3+Vmubmn59MUGN40EIApeXQ/m01rqSnVDwkEqCZrNsjx4m/+ju2e+CF10vy EJAMPw== Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epenr9bfm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 13:02:39 +0000 (GMT) Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-963a5d302f4so189559241.1 for ; Tue, 09 Jun 2026 06:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781010159; x=1781614959; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xbHtB5FkcaadoqFbH3R3CLsT+3mMjSYwuCc/ZzU+pvY=; b=KFsb5JJ47UamgoKfHHUSaPtpSlIl5m3+6jb3ZxR+vURPCnSb56l/rUP+/22A0yE7vM 3wMygMNdzycls+7eBSITOecNxG01pDusM75IxfKPZ4zjTVbPzmV7xftK5T+vLPIkekdT EKUbJ+5G8vwlZGjAy1O5OANo8BfWqfP+Pdb3NImbT63dg5rpwvl+1p0rMKxSTRiVMi8o T4+9HuncRjKClDV/WkMLz0WK0UDOz6DRYewFvGSE9QSnmCsbnO4ql7Q6oYatkQajbpif ADjzRbRWDifEQuhgkSkJgRg5yrBBE2yT4W42qDFMvsQtxu4jf10w1Ud2pk4lMO86/65F dEXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781010159; x=1781614959; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xbHtB5FkcaadoqFbH3R3CLsT+3mMjSYwuCc/ZzU+pvY=; b=IqxIzPKEoO4/TtyNuwXvs7iF4rnzHPWLk555Ivu1kzJSv5uLq8MXMRj+v/ej9skgGj H2IobRK8QKMV8Q1ZBxd8IEeZtNmSQXdp1SgbUXEZwTo/n9+mNkwVIfmo7or7kl3i1BX+ ZNua3UHWG0THVqsCjoR3WLxFeR9Tdc5gyZEGcOZaYK6dlLYZEHRSdhFG078lI9+NBLdk G8GS3ievwJ1GR6hUjWsqGtkAYM8EmM2Yyx0OqV/+vW9UNcwAgNjfzWjJPBc+lA2qxwv1 aLSsfMpRFWEsb1eERpeVvvSqFQHQoTr3q/LoNHOUwJAmzsPlZ7O9yFPjlyr97tTaVxDJ BEeg== X-Forwarded-Encrypted: i=1; AFNElJ9zwmVacLpXId4Ao5mDqSV2/GEBWxysQww2pZo3Z6m0tYVKsWVUdng9YE5RfZDu4r6y/YR0WVkHyp8BlDg=@vger.kernel.org X-Gm-Message-State: AOJu0YymfmNFikpUg/9Saz93YVTUyIG94udxQdFFr8iTUAsRpSYaLlPe Fzj5DmVXkKWHrZHMvKeXEzNGPMhlEpL7lIuoUcq29CLQAOsKwHPHmEDkmR8P3ClhcetX3JaKnG4 uvB6ZoOmh+Hkae52ODs3r5xeE9HpuGUWHHw6BmLF9gSEb1yukR0/pJ87+gKW35ve1w1o= X-Gm-Gg: Acq92OHbdzxzifNzo+B86CYSoMYIRPKjNCbmO/4R6ZfbnNetpEStLVwg6PzlkRm+1u1 Fo4sOB0wWlP6cDo51UF4jvq9f6Y1Bd5Qv/gT9zwcuNKBzRN6wVFrwO993BseGf8DmU5XgKEkYwZ 9xJhacCV+y1lycMe1OfN7Fu0qec3dMSwFQClOZzRvVBhyVeqHKz16rnFEfvfIVsLG5uEbSmOBHG WEWlcsJJRE//YeCnGPWEua7a+nqiOXmYpc20lPiAj3mqT5SJdTlIStZLEgA7fd7DWVSxKGxqgAb YRqRkKIw3aDb8mvkvrc1Aohiws7qju0nJ1TTWNiTNHFQSkY4sjfoRMm6kk92kUexbG+lgh3WEyH aXyXtEDx+20PEsii6XM3PcJiMgKl5oTeAjhSOcVcnIbq2EDrLAaYvbyj8 X-Received: by 2002:a05:6102:26d1:b0:631:3ccc:42df with SMTP id ada2fe7eead31-719255a6e8emr465869137.3.1781010153589; Tue, 09 Jun 2026 06:02:33 -0700 (PDT) X-Received: by 2002:a05:6102:26d1:b0:631:3ccc:42df with SMTP id ada2fe7eead31-719255a6e8emr465752137.3.1781010152819; Tue, 09 Jun 2026 06:02:32 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-396ac2be29fsm51941651fa.21.2026.06.09.06.02.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 06:02:31 -0700 (PDT) Message-ID: <747f0319-68e1-4cd7-9dd1-4a675d882f99@oss.qualcomm.com> Date: Tue, 9 Jun 2026 15:02:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/7] clk: qcom: tcsrcc-glymur: Migrate tcsr_pcie_N_clkref_en to clk_ref common helper To: Qiang Yu , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, krishna.chundru@oss.qualcomm.com References: <20260527-tcsr_qref_0527-v4-0-ded83866c9d9@oss.qualcomm.com> <20260527-tcsr_qref_0527-v4-3-ded83866c9d9@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260527-tcsr_qref_0527-v4-3-ded83866c9d9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: MBc8zzKBucNFQ5Xil5tWbXkQHoyC-br5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDEyMyBTYWx0ZWRfX2rpctOF4Ni4u SgU+cLpHAX/1cIDaDxN4MzTYZKmB6jpOyxh0sjUp8zRDe3/lpXHSho/6sSWecBzV3O8iECwsed0 R2rbQyQk7R7CIB3p2xuSa5YbgUrVrU7bL4WrZY1ey28Yry/2SMe9OKZEEPQgGF2P2XPSnuk/Dll L+FgDIdHXKEJZ/gH8Qy7PDhDBFG+gJip09U4Tja5gjGGyRTfztX8uNALPZfpemNVVr+uW2LlyDC 6gQCwIW5h9UVjhpZd9FblP91y212QH4e7Z+unANvty7iBPbq+nEnVz2hYtvXXoL/+uvrEpiy48v dDqiwGThlru2gDP3bHnkeW14gTvUibnm5A0Ya11Pc1OMlwuaHOB69Li/I8gEjI62D8i4cqM5lAY GYLwPcqLc5iJt7R72u5pQqY5RuwQizs7R2/wfn4EaaxsbDlAHpXHaeDIoSh1fuRjQr0mF+kcqTu LLEtWBIAv4JshpCiEaw== X-Authority-Analysis: v=2.4 cv=NKPlPU6g c=1 sm=1 tr=0 ts=6a280ef0 cx=c_pps a=KB4UBwrhAZV1kjiGHFQexw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=hcCWvLewiaSd8YhtB04A:9 a=QEXdDO2ut3YA:10 a=o1xkdb1NAhiiM49bd1HK:22 X-Proofpoint-ORIG-GUID: MBc8zzKBucNFQ5Xil5tWbXkQHoyC-br5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_03,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 impostorscore=0 malwarescore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090123 On 5/28/26 4:29 AM, Qiang Yu wrote: > Replace local clk_branch-based clkref definitions with descriptor-based > registration via qcom_clk_ref_probe(). > > This keeps the glymur driver focused on clock metadata and reuses common > runtime logic for regulator handling, enable/disable sequencing, and OF > provider wiring. > > Signed-off-by: Qiang Yu > --- You can remove the of.h include. Apart from that: Reviewed-by: Konrad Dybcio Also, attaching a diff to complete the regulator map. I'm fairly sure these are correct, but it never hurts to triple-check. You can add: Co-developed-by: Konrad Dybcio Signed-off-by: Konrad Dybcio if you squash them together. FYI e.g. the tertiary USB QMPPHY would only start every 20 boots or so without this, running on pure luck.. Konrad diff --git a/drivers/clk/qcom/tcsrcc-glymur.c b/drivers/clk/qcom/tcsrcc-glymur.c index e317003398d1..eb4ee8ec9ad7 100644 --- a/drivers/clk/qcom/tcsrcc-glymur.c +++ b/drivers/clk/qcom/tcsrcc-glymur.c @@ -21,6 +21,14 @@ static const char * const glymur_tcsr_tx0_rx5_regulators[] = { "vdda-qreftx0-1p2", }; +static const char * const glymur_tcsr_tx1_rpt0_rx0_regulators[] = { + "vdda-refgen4-0p9", + "vdda-refgen4-1p2", + "vdda-qreftx1-0p9", + "vdda-qrefrpt0-0p9", + "vdda-qrefrx0-0p9", +}; + static const char * const glymur_tcsr_tx1_rpt01_rx1_regulators[] = { "vdda-refgen4-0p9", "vdda-refgen4-1p2", @@ -40,6 +48,15 @@ static const char * const glymur_tcsr_tx1_rpt012_rx2_regulators[] = { "vdda-qrefrx2-0p9", }; +static const char * const glymur_tcsr_tx1_rpt34_rx4_regulators[] = { + "vdda-refgen2-0p9", + "vdda-refgen2-1p2", + "vdda-qreftx1-0p9", + "vdda-qrefrpt3-0p9", + "vdda-qrefrpt4-0p9", + "vdda-qrefrx4-0p9", +}; + static const struct regmap_config tcsr_cc_glymur_regmap_config = { .reg_bits = 32, .reg_stride = 4, @@ -52,6 +69,8 @@ static const struct qcom_clk_ref_desc tcsr_cc_glymur_clk_descs[] = { [TCSR_EDP_CLKREF_EN] = { .name = "tcsr_edp_clkref_en", .offset = 0x60, + .regulator_names = glymur_tcsr_tx1_rpt0_rx0_regulators, + .num_regulators = ARRAY_SIZE(glymur_tcsr_tx1_rpt0_rx0_regulators), }, [TCSR_PCIE_1_CLKREF_EN] = { .name = "tcsr_pcie_1_clkref_en", @@ -80,34 +99,50 @@ static const struct qcom_clk_ref_desc tcsr_cc_glymur_clk_descs[] = { [TCSR_USB2_1_CLKREF_EN] = { .name = "tcsr_usb2_1_clkref_en", .offset = 0x6c, + .regulator_names = glymur_tcsr_tx1_rpt34_rx4_regulators, + .num_regulators = ARRAY_SIZE(glymur_tcsr_tx1_rpt34_rx4_regulators), }, [TCSR_USB2_2_CLKREF_EN] = { .name = "tcsr_usb2_2_clkref_en", .offset = 0x70, + .regulator_names = glymur_tcsr_tx1_rpt01_rx1_regulators, + .num_regulators = ARRAY_SIZE(glymur_tcsr_tx1_rpt01_rx1_regulators), }, [TCSR_USB2_3_CLKREF_EN] = { .name = "tcsr_usb2_3_clkref_en", .offset = 0x74, + .regulator_names = glymur_tcsr_tx1_rpt34_rx4_regulators, + .num_regulators = ARRAY_SIZE(glymur_tcsr_tx1_rpt34_rx4_regulators), }, [TCSR_USB2_4_CLKREF_EN] = { .name = "tcsr_usb2_4_clkref_en", .offset = 0x88, + .regulator_names = glymur_tcsr_tx1_rpt34_rx4_regulators, + .num_regulators = ARRAY_SIZE(glymur_tcsr_tx1_rpt34_rx4_regulators), }, [TCSR_USB3_0_CLKREF_EN] = { .name = "tcsr_usb3_0_clkref_en", .offset = 0x64, + .regulator_names = glymur_tcsr_tx1_rpt34_rx4_regulators, + .num_regulators = ARRAY_SIZE(glymur_tcsr_tx1_rpt34_rx4_regulators), }, [TCSR_USB3_1_CLKREF_EN] = { .name = "tcsr_usb3_1_clkref_en", .offset = 0x68, + .regulator_names = glymur_tcsr_tx1_rpt34_rx4_regulators, + .num_regulators = ARRAY_SIZE(glymur_tcsr_tx1_rpt34_rx4_regulators), }, [TCSR_USB4_1_CLKREF_EN] = { .name = "tcsr_usb4_1_clkref_en", .offset = 0x44, + .regulator_names = glymur_tcsr_tx0_rx5_regulators, + .num_regulators = ARRAY_SIZE(glymur_tcsr_tx0_rx5_regulators), }, [TCSR_USB4_2_CLKREF_EN] = { .name = "tcsr_usb4_2_clkref_en", .offset = 0x5c, + .regulator_names = glymur_tcsr_tx1_rpt01_rx1_regulators, + .num_regulators = ARRAY_SIZE(glymur_tcsr_tx1_rpt01_rx1_regulators), }, };