From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D56C83EC2CB for ; Mon, 15 Jun 2026 14:38:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781534294; cv=none; b=nMvS4eYKLvT5pHrC+B5iCUQG8ePhI5UzbWAfXl0M1Pj1+s/KiXTeujxtAwfaDN0pWS7moS1TbRW6FKXG1Ts7z6mviURFLBZKenSJrj0hZqcvyaoHn1qNgKC3dgA0RXEBrDnPeRBqH2F8QyNomigbWqBZVZ+jenbk8mCPjeBXbO8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781534294; c=relaxed/simple; bh=/dqmKEk8IHcyT64dAazScoiyh61y6MuCEqGtr0TDgeA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LBe8bvbNX60gEsk75yVrCKWmVEozcS/g9avuBDNskf+FRYTXQuJ11FhrpVTmUpF5JlGw6z9IYR1xT/wMkmzI8Xku9PFYHZ3lRbriZpqn9Qyg6+03AUgC75O1z4Uy37TxonJxpsWMfyMhPzY24pSFzFj1Ztp9kemLRc1eGyrEuVQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V2rJNPHY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=f+1akzKb; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V2rJNPHY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="f+1akzKb" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FEYC6Y290677 for ; Mon, 15 Jun 2026 14:38:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2J+LVI+c+0smqU6fvzbOLf0LFTi1VUdvON3SrgIXMag=; b=V2rJNPHY3yu5Fz0Z FOjU9xPe3Dnhh9j6j+NjNeQ3APHJ7rR5mMP53L4026uFMAcrGKTJWoLR8Qtm9nTC GJSxHfnkAlo8V/vdBxt2pXf89myXLuFv0iE+kh2bpZuZ5hfGn8DHfBoVlNzqsyrs lbSasmHddLicNNFRm40ew2oFrwe4rwaeo77KxkIFDgLFIZIBtkXaKFQFfs3Og2uz Vj1x0AMAV/6ncfqKDAepLHVNptZAPHTL3Nf08oYLvE6WfFbkR1tyDlwBWg8dOG47 8i0AADjYCMfxJHw1oWkrelC5xF98DS2+US63hhyVAcVU9tb8y8frhkH9ZmQsL8xD XP+ALQ== Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4etew0h6as-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 14:38:12 +0000 (GMT) Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-963a5d302f4so108551241.1 for ; Mon, 15 Jun 2026 07:38:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781534291; x=1782139091; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2J+LVI+c+0smqU6fvzbOLf0LFTi1VUdvON3SrgIXMag=; b=f+1akzKbzeTw4IUBkfz6awmNFWnXB9zgqMa6UXAR+ekxVM6BYnc6G5WOm5SFzWzlCc lZTNcKpi79Rk91TKkZs8LTBYqiElPl/Avr2ddhi2+H6BtsGFbftuKcjxhP+M/92E8o0t hQg0BC5pRQxYIxHteiLSXKQccDzW2+xj4WX409+VV1ddPdnvT7ptmw+3+0OXh7/U9MXB 30/UdsqdOWZ/781LRa+jtPd7skedd0PPepxG72itNZ+2yYuwWuhzWDylfLsFnTGPjZZb Wj+85ZQCf3Ccc6IvVx0Uur96kmcAqe3Ygla7GB0YnikqH6K/SNucTfxiC0L4pugofc7l GfEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781534291; x=1782139091; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2J+LVI+c+0smqU6fvzbOLf0LFTi1VUdvON3SrgIXMag=; b=ISbkGeCJzZogUSh/zoNDxtCS4GylT9EPRNx5Ve4YUPP2U5MsHH5nr+eI47jr+CPvtp OH/V0ZDQ4ePozhS/v2aE+uDDC1PFFYDm+lsuOrYfua/ZF9brc/QxRm7V45PoAXORETvB NRFmhF8n5p2WYiUR1sUwhsTNlaFzQP8ygMhyrxIcsLcXeLQweZYP7Zjjl65+Bs5KYEzf JnSMXmvmjgD7Z9gelaMttreGI3xvlfM5iVyHUv7Rzt9y6o5tBSBCCzEmB0dw95HY8N3J 4l3+J/IVexLI4V81rslVe/ht0IBk34LirHXYB+yROiBJGx6RDNnOLDw2HUD8V+Hr0WwN aXsA== X-Forwarded-Encrypted: i=1; AFNElJ9MRjhOtK+tGpMBgxgITGOn+QY1WupjKlpusVOZbV3jpAQx3oWUlYbqQMme0sEtJu3+EyP2s74dCHcUSl0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3dtrfV7xjhWGqr8oyIh0mphpNwOUHFOprpYnkrMv7392IB1IX jrZLsQDmsI16NCGVuxAh4OgkRivpV4hyblQqQBex0W+KJI9pNE0leMgkP8MzhVKWAoxIpKdiyRU NqyhZh2fSzk/Zv9qtNjsES1oRDGP5f2TvEDPJWskRrL0y9/mfxJJFzgAftdMtMviKP8s= X-Gm-Gg: Acq92OHMe736SNnlUl9nvzyG67B+HK6fbsH/fxZnfJaWxO3avmqc+iE81prJjOFI3du 5HrOuVAfHBw4D6Rjw05NWW2aD30yftIO9Inti26LkeeJaxREyhj1uv4BRQA4XVUgXwY8xmn3INu 7YW5auwmFF1fqeb58dBPRvrhrwDj1NF9u0X7urGZOjjmfpzlMb1sn7G2MNWAmL/InIB2exUK2qc j6Rud3MOpZ35YSWCCLc1ESbWsfjmqBBdKqHuItYHg+pMuED10+nLP4fuO6DqHBo9vE++lK7b3Sa FiYKPq5Z4scYxVneOfIfeybjvs7SOnE3CWs6xe9ScRcN/0s2rv6ngojtHvoTRPwonlP0jfOfYnL FG0zILv1cO8HP4o9/kpZjC7jKW74Sg4GE6SSfeMQTMwLE6g== X-Received: by 2002:a05:6102:3f06:b0:674:84bf:8e0a with SMTP id ada2fe7eead31-71e88e6c8d2mr2467505137.7.1781534291090; Mon, 15 Jun 2026 07:38:11 -0700 (PDT) X-Received: by 2002:a05:6102:3f06:b0:674:84bf:8e0a with SMTP id ada2fe7eead31-71e88e6c8d2mr2467497137.7.1781534290655; Mon, 15 Jun 2026 07:38:10 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfe5116f409sm453354266b.23.2026.06.15.07.38.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 07:38:09 -0700 (PDT) Message-ID: <748147d8-0145-424b-b147-67d92154a989@oss.qualcomm.com> Date: Mon, 15 Jun 2026 16:38:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] pinctrl: qcom: Avoid assigning thread_op_remain in unthreaded test To: Sneh Mankad , Bjorn Andersson , Linus Walleij , Yuanjie Yang Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260529-tlmm_test_changes-v1-0-88bfdccb4369@oss.qualcomm.com> <20260529-tlmm_test_changes-v1-3-88bfdccb4369@oss.qualcomm.com> <8b110f90-2001-4655-856d-ec8cff98fc0a@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <8b110f90-2001-4655-856d-ec8cff98fc0a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDE1NCBTYWx0ZWRfX+U4AMSBIvszU z1Fc7QRkk59uZE1UyZkr8SNdPGBYGYxfMXxYr2J4M8wl/+5dVfzT2v9YifuW/YiCKhtmeGSJY4F bGXnR1MTOFd7NgVTKNA12OZ2E0MtV6k= X-Authority-Analysis: v=2.4 cv=QLlYgALL c=1 sm=1 tr=0 ts=6a300e54 cx=c_pps a=ULNsgckmlI/WJG3HAyAuOQ==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=MRFKDVH_TV9PNoJzvMIA:9 a=QEXdDO2ut3YA:10 a=1WsBpfsz9X-RYQiigVTh:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDE1NCBTYWx0ZWRfX3GuPk4sKTNTY Abj7oZbLAu07rrxq07FBN2n4ajNni5pHWYQjsk3B6+5G+LPV3mk0zYsYo21/3llOxwC05gSe8Fx ebbWOCuqPgvbXJw7RWpEv1rIm4gHJgBvk/hnZC/UtJwUCvVHR/3Wq+puiKR0NPrOzDlo1+IHxML HNxxFRo7bnpI7q2ig0HTFgS/1Nslt6fQ2d+/PaeKT/eq+dH/qboUNs4pj39Omrp31FaJYLdTA+H NrlWrMOZWpaPKg2Vfvg0dUqEtwhw/6ZsBSRF8iiUeFNc2JveovOKcdEDljZSwL4WY5OgLmDZKX1 1K1OtAEeCgsPw2eIIVNA/BDwJbE3dC1yOlRkJovTjokyh0A6yCXpCoMpm+RBZPka3AafVIh+Ljv YeUxoby3MSVhtiQ38Dp9W0/6o2EFB4lAeUGGe4SD9aSNuVGmdtMTnngFPPU7YOgCf7SxsIHy9RI Ja/+yvfQKxkGvv72KXw== X-Proofpoint-GUID: mjoLtbeGET_HgDRFvngehiB1jogiQKVc X-Proofpoint-ORIG-GUID: mjoLtbeGET_HgDRFvngehiB1jogiQKVc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_03,2026-06-15_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 priorityscore=1501 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150154 On 6/10/26 8:16 AM, Sneh Mankad wrote: > > > On 03-Jun-26 7:28 PM, Konrad Dybcio wrote: >> >> >> On 29-May-26 14:55, Sneh Mankad wrote: >>> tlmm_test_rising_while_disabled() sets thread_op_remain to 10, but this >>> variable is only used by the threaded IRQ handler to control the number >>> of GPIO pin toggles. Since tlmm_test_rising_while_disabled() does not >>> register a threaded IRQ handler, the assignment is never used. >>> >>> Remove the thread_op_remain assignment from >>> tlmm_test_rising_while_disabled(). >>> >>> This does not cause any change in functionality. >>> >>> Signed-off-by: Sneh Mankad >>> --- >>> drivers/pinctrl/qcom/tlmm-test.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/drivers/pinctrl/qcom/tlmm-test.c b/drivers/pinctrl/qcom/tlmm-test.c >>> index 007d6539ceced294e81cfbe93a00c75a98c858de..e9e04300ab3687825255885821ebde0f3ee586a8 100644 >>> --- a/drivers/pinctrl/qcom/tlmm-test.c >>> +++ b/drivers/pinctrl/qcom/tlmm-test.c >>> @@ -521,7 +521,6 @@ static void tlmm_test_rising_while_disabled(struct kunit *test) >>> unsigned int before_edge; >>> >>> priv->intr_op = TLMM_TEST_COUNT; >>> - atomic_set(&priv->thread_op_remain, 10); >> >> Should this be setting priv->intr_op_remain instead? > > Should not be needed. > priv->intr_op_remain is to indicate the hard IRQ handler how many times to toggle the GPIO line within the irq handler. > Here the test case does not require any toggles within IRQ handler. Oh yeah seems you're right > I also found other test cases where intr_op_remain is assigned but never used. Will remove them in v2. Thanks! Konrad