From: Jon Hunter <jonathanh@nvidia.com>
To: Jesper Juhl <jesperjuhl76@gmail.com>, linux-kernel@vger.kernel.org
Cc: linux-tegra@vger.kernel.org, Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [Patch] [tegra] Remove unneeded version.h includes pointed out by 'make versioncheck'
Date: Fri, 17 Feb 2023 09:39:29 +0000 [thread overview]
Message-ID: <74818031-0a0f-bdcb-3a04-434203f7c99a@nvidia.com> (raw)
In-Reply-To: <f1b1c2df-b88d-e668-fade-ca0ef74e7b07@nvidia.com>
On 17/02/2023 09:30, Jon Hunter wrote:
>
> On 16/02/2023 00:53, Jesper Juhl wrote:
>> From 7264ec7d00ece4b56fe9fafa3237d4870cbe6785 Mon Sep 17 00:00:00 2001
>> From: Jesper Juhl <jesperjuhl76@gmail.com>
>> Date: Mon, 13 Feb 2023 02:49:50 +0100
>> Subject: [PATCH 04/12] [tegra] Remove unneeded version.h includes
>> pointed out
>> by 'make versioncheck'
>>
>> Signed-off-by: Jesper Juhl <jesperjuhl76@gmail.com>
>
>
> The patch looks correct, but there is no commit message and I am not
> sure why the header is in the body of the message. Make sure you use git
> send-email to send patches.
Also the patch $subject prefix should match subsystem you are patching.
You can check this by looking at the git history ...
$ git log --oneline drivers/soc/tegra/cbb/
b6c6bbfc65f5 soc/tegra: cbb: Remove redundant dev_err call
fa9b5246e260 soc/tegra: cbb: Use DEFINE_SHOW_ATTRIBUTE to simplify tegra_cbb_err
2927cf85f487 soc/tegra: cbb: Check firewall before enabling error reporting
55084947d6b4 soc/tegra: cbb: Add checks for potential out of bound errors
So you want some like "soc/tegra: cbb: Remove unneeded version.h header"
Jon
--
nvpublic
prev parent reply other threads:[~2023-02-17 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 0:53 Jesper Juhl
2023-02-17 9:30 ` Jon Hunter
2023-02-17 9:39 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74818031-0a0f-bdcb-3a04-434203f7c99a@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=jesperjuhl76@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®