From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.53 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792690855; b=FAtkYUoXocQ8eKEChmeJnvnVn+mrdbdYuFhXvhNDAoTvjNaYUBfpVzkHUGKozR38KmPp vybRchyHRyiXZwsI8VkAjBTKa+QQ+0Qre1ySKPD5FF/lpnwckhlOKS3/LhuzgJTvG2s2C mzGsQtrEI71T4ozmMJio8KXlirmzRZ6iKv5EHAuBws8DuK0zk+pdAmmk2mJSNdo+aw5Vy rOmFauctGBua+hZdHq2EGYc6jhckcBS2JCuvazMOXHUjn3yhlu9cdfeoeaNcC7IPVVPsV m1sG+LCbYhhVlIut50yqWXoQHYj4dpfgkNg4YvwQ2QqeXQmYupo7czDOxQhdmIvXtwQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792690855; h=DMARC-Filter:Received:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:Message-ID:Date: MIME-Version:User-Agent:Subject:To:Cc:References:Content-Language: From:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=lqDNdqh7JWi24rY3vzEqU+LCO6MlMl1qL5MbUIf6AO4=; b=HJ8uL+Vdo8fgtiMCRMsw0OIma/DtC7gXRUbqqCTr4JoA91lG5Ecsxq+HYOqWFSk1ZhUX yg4dp/q1vRoi094q8GNf3iAWkS0fz1oW66sh9QaxhdwlLgCT6pEgU4qMwxacgqXttZhgN KJmLaBU18qEJefYmllhGUznDwZOGfNHXgqDPd+RB/+C6bIPhZ/Uk8IERnej54kF3jFbuR FnxsUYwreWbT4suV0Fb27MJedx1VcaST9V1cGG73t/zc0a62pjOZtfKkxxNgxxu7HyOpL /lBAxHedyauwmieQT2x34FmfEtvhnh4Gw31wDrOjHigUpPvwpRzAToED0eFHwGF2Z7Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail header.from=linux.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.remote-ip=209.85.128.53 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33072606A31A for ; Thu, 22 Oct 2026 17:40:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 33072606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4a20bdaf39cso941865e9.1 for ; Thu, 22 Oct 2026 10:40:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792690853; x=1793295653; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lqDNdqh7JWi24rY3vzEqU+LCO6MlMl1qL5MbUIf6AO4=; b=np5eGrgzY6b/NxOHUxvzXVB1nedXlD5RTyeFXjDuJhkpQwpbqvhNizT2S4FLPva23O Y+luJ3uNevR9133zKPKQSNGJKWS9IraKoVm3JFfXzuxV/0R/Y6YUmfr+I9u5mG+EBO8i MfRPzyBd7xTx4aRXHTp+Sx23MXiq5yqT/k1BEPHxZN5FgXa+XhiR/ARBXRxCXO2E/G1S hJmgjLfuq1e/oRPVPDn/fWOhmdy4AmRyQAWQ7t6cJNg6kQcLdfrbvFSss0h9oytK4P4W kVbQSY/tGeLon0DFmIhKZ50sd2Zx06P5BdRsjsifUqxcapG6ZxHfN6T3v/7TB212fscR braQ== X-Forwarded-Encrypted: i=1; AKwUvBzMI8/HZHg9+35fJXL52n7wPNsVHy8ejoJrMSH0aV2/zFDZZi+ooz1opv6uij01BWNyJCO/2tO2MofPKDU=@vger.kernel.org X-Gm-Message-State: AFq9FYImgZDzQt8upzlgPi1VGMCrnYwOtYYG5ViiLy7bHr7cKr/3rxyN CP7js2UnEcibe/XYn2j0LhHK9r+YHnT5HGPgsgphj5b58ySOJE5guXfH X-Gm-Gg: AYBFou0UOSCyH/lZhVZmOfvI8eh9uTQ02YcqpSbTAXXBdHdd9YEwTT+UaAeFN+QwJFd 0DU2C1vAUHWdOdvSMeHz2qeTfZPt/63cPNwXl4apI3+IMB+IKG79rcZm58DT6jXvXHwHPy8FqP+ kLKjMOf/eY15WRcEq/1UrrZLKjXlVyPetDkCM9fnFs92rfKxfnjas6vFDeWTAT+D1h9muLX/EwM k5SlzZQLsa1FDG/ynOwX8xu+mZ26zJFYD62K959iHhXHycOyQcqZimN+6hG1xWJ6XY51cWu5cRJ /6jAgayKZYzdtKKkK+5Fy2nk71m4AiP7hGW05lX41ZqxoSm2LzBxfenZz0app+rVD7rhSYuaDXa Eb6hgeeyEjFZDTES9eSw3cg8jwCXnSuwgj7DfoUEiNwUP7FVjJMOdhPjQuAb9vd55++Ey1bBQ4S GWvGGXJFDnfQDUy61qoHQQGKrpHJ3G9TvTPfF2so6CIKznSYGtPHOpvwi+C9xKMCldeYOX0Ynm1 KxCFfRV2UHODk0KHBLcwVP6Ys8r56MXakNC6WaW30flsWxwFuHpbl+Z/j/FFVkn9seHtMnNY9fo /8sgQ5JtuQ== X-Received: by 2002:a05:600c:8b45:b0:4a2:a3b:7aa8 with SMTP id 5b1f17b1804b1-4a20a3b7c0emr41739035e9.3.1792690853435; Thu, 22 Oct 2026 10:40:53 -0700 (PDT) Received: from [192.168.1.135] ([81.79.62.202]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a2101cd7cesm14216005e9.0.2026.10.22.10.40.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Oct 2026 10:40:52 -0700 (PDT) Message-ID: <74840159-62d9-4d6d-a0c3-b079e6e4da6e@linux.com> Date: Thu, 22 Oct 2026 18:40:51 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/8] arm64: dts: amlogic: t7: khadas-vim4: enable the ethernet port To: Martin Blumenstingl Cc: xianwei.zhao@amlogic.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Maxime Chevallier , Maxime Coquelin , Alexandre Torgue , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20261010105900.247342-1-tanure@linux.com> <20261010105900.247342-8-tanure@linux.com> Content-Language: en-US From: Lucas Tanure In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/10/2026 23:00, Martin Blumenstingl wrote: > On Sat, Oct 10, 2026 at 12:59 PM Lucas Tanure wrote: > [...] >> RGMII needs a delay on each of its two clocks, and on this board >> both come from inside the chips, not from the board traces. The PHY >> adds the one on receive. Its transmit delay does not work here, so the >> controller adds that one. > [...] >> +ðmac { >> + status = "okay"; >> + pinctrl-0 = <ð_pins>, <ð_rgmii_pins>; >> + pinctrl-names = "default"; >> + phy-mode = "rgmii-id"; >> + phy-handle = <&external_phy>; >> + tx-internal-delay-ps = <2000>; > You're stating that RTL8211F's TX delay doesn't work but not explaining why. > I haven't come across this behavior before and I'm worried that that's > an issue with a batch of RTL8211F. > What if the previous/next batch of RTL8211F will have working TX delay > again - wouldn't that mean 4ns delay in total unless the RTL8211F > driver is changed? Yes, you are right. After I understood I had a missing clock I re-tested the everything from scratch. On the T7 the register block with PRG_ETH0/PRG_ETH1 sits behind a clock gate (the "pclk" clock in patches 2 and 6). My first tests ran before I knew about that gate: the block ignored every write and PRG_ETH0 kept the value the bootloader left there, 0x1621. Bit 5 of that value is the TX clock phase select, 1/4 cycle, which is 2ns at 1Gbit/s. So with "rgmii-id" the PHY added 2ns and the MAC added another 2ns nobody asked for, 4ns in total. The CRC errors from that made me believe the PHY TX delay was not working. With the clock enabled and a plain "rgmii-id" node, no delay property: PRG_ETH0 = 0x1601 (TX phase 0), PRG_ETH1 = 0x0 RTL8211F page 0xd08: reg 0x11 = 0x0109 (TX delay on), reg 0x15 = 0x0019 (RX delay on) iperf3: 940 Mbit/s board to PC, 943 Mbit/s PC to board, 0 retransmits 0 CRC errors on both ends v4 drops tx-internal-delay-ps from the VIM4 node and the wrong sentence from the commit message. The PHY adds both delays, as the generic text expects. Thanks Lucas