From: Hans de Goede <hdegoede@redhat.com>
To: Luis de Bethencourt <luisbg@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Larry Finger <Larry.Finger@lwfinger.net>,
Bastien Nocera <hadess@hadess.net>, Arnd Bergmann <arnd@arndb.de>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH] staging: rtl8723bs: Fix trailing semicolon
Date: Tue, 9 Jan 2018 17:11:52 +0100 [thread overview]
Message-ID: <74881576-42ba-47a8-75d4-868149bdf68e@redhat.com> (raw)
In-Reply-To: <62011a82-9412-d26d-fc19-52a873f65687@kernel.org>
Hi,
On 09-01-18 17:02, Luis de Bethencourt wrote:
> On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote:
>> On Tue, Jan 09, 2018 at 03:09:27PM +0000, Luis de Bethencourt wrote:
>>> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
>>> ---
>>
>> I can't take patches without any changelog text, sorry :(
>>
>
> Hi Greg,
>
> I have done some research around previous patches to this driver and
> I am not entirely sure what you mean.
>
> Sorry, but I need to ask before sending a v2.
>
> Do you mind I'm missing a small summary in the commit message? Fix is
> so small I thought just the commit subject would be enough.
>
> It is something different let me know and I will correct it.
I'm not entirely sure, but I believe Greg may have a script for this,
given the amount of mail he receives and commits without a changelog
in general not being a good idea.
What I usually do with trivial patches like this, is simply take the
part after the last : in the subject, append a "." and voila you've
a changelog txt. So in this case that would simply be:
Fix trailing semicolon.
Regards,
Hans
next prev parent reply other threads:[~2018-01-09 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 15:09 Luis de Bethencourt
2018-01-09 15:20 ` Greg Kroah-Hartman
2018-01-09 16:02 ` Luis de Bethencourt
2018-01-09 16:11 ` Hans de Goede [this message]
2018-01-09 16:13 ` Luis de Bethencourt
2018-01-09 16:46 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74881576-42ba-47a8-75d4-868149bdf68e@redhat.com \
--to=hdegoede@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luisbg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®