From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-157.mta1.migadu.com [95.215.58.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 336B229BDBF for ; Sat, 17 Oct 2026 21:30:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792272652; cv=none; b=PEkjekxw/uwtrwMA27pc7cq80fOEteZNyc3MFd0X8eKIzcDTv9k8hV0nTw+VuXx315kjqWU5OkQNQ1ou5/WnP5fPqZAfJqzRr9t+TuFfJqvtVnRUsb2UhyufBKKs+xDMzPtdKWkzflB3F2kN7NTAHfF+zfnLHmH6oZejio5VYtw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792272652; c=relaxed/simple; bh=oFKzuUCJrKx39ZMIlQ2/kgBJRP6R7Lq8f0WtyI+Xr90=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=njhtkb8PS4DjwEeXMYNQoBfPYMs5nyz0Qpq8jeQ6V2z9nteIk4U81QKl8erP9C1andmc0OXB0TK6/POpshAenaFDAV/C6u2SgvnKAJqwjfc3zBtmaSUuptcs1OsDBf+cNmRLYkOb2q++ufL2dqh/CyK9/nDtpbrrKXkVoYw6xIo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool; spf=pass smtp.mailfrom=packett.cool; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b=VkigHWZo; arc=none smtp.client-ip=95.215.58.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=packett.cool Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b="VkigHWZo" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=oFKzuUCJrKx39ZMIlQ2/kgBJRP6R7Lq8f0WtyI+Xr90=; c=simple/simple; d=packett.cool; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1792272647; v=1; x=1792877447; b=VkigHWZoTyVHLcC0AUP9bugYpUfLbltbP5wRebbiNqyi/GD/nuIyrbJlkJ5L8PTDbDyFD5p/ +7ick6/HO6GpWfFbr/PpPiCHwgjeg+Z5GOCBdSjJkpTMPADdTqesmFlOSm/2FzgW6IBPsgzM9ja O7wZ2UatHoi9ZdnRnHERC+sNcxLiQlgvfjbFtZGdOI+23bNilqvDPpctmNPuj8tqFyDcAgoVQ5d FelL/MsoqwhgGO6dnTm5FM85HfHWyTUi8bhYdF8WTp3e6graQw+MANDjzn9kfhbzk8MYqxgFg04 Grnco/5DETQi8xnw03JhMUu2z5JFkYt5WpTZ0nMJtCyig== X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 4b86bf520d346430; Sat, 17 Oct 2026 21:30:18 +0000 X-Mizu-Trace-ID: 4b86bf520d346430 X-Migadu-Flow: FLOW_OUT Message-ID: <748ec3d0-2eb6-454b-b0ce-36c04d7bf844@packett.cool> Date: Sat, 17 Oct 2026 18:30:08 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] dt-bindings: arm: psci: Add skip-suspend-mode-switch property To: Reza Kurniawan , Mark Rutland , Lorenzo Pieralisi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ulf Hansson , "Rafael J. Wysocki" , Daniel Lezcano , Christian Loehle , Bjorn Andersson , Konrad Dybcio , Abel Vesa Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, Alejandro Tafalla References: <20261017-psci-fix-v1-0-dedae27e4a31@gmail.com> <20261017-psci-fix-v1-1-dedae27e4a31@gmail.com> Content-Language: en-US From: Val Packett In-Reply-To: <20261017-psci-fix-v1-1-dedae27e4a31@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/17/26 1:41 PM, Reza Kurniawan wrote: > From: Alejandro Tafalla > > On some SoCs (e.g. Qualcomm MSM8917 and MSM8937), PSCI_FEATURES reports > that OS-initiated mode is supported, but every PSCI_SET_SUSPEND_MODE > call is rejected with NOT_SUPPORTED. > > PSCI provides no call to read back the current suspend mode, so the OS > cannot tell which mode the firmware is operating in or why the switch > is rejected. > > Add an optional flag that tells the OS not to issue > PSCI_SET_SUSPEND_MODE on such firmware. > > Signed-off-by: Alejandro Tafalla > [Reza Kurniawan: split out the patch, rewrote the property description, > renamed the property] > Co-developed-by: Reza Kurniawan > Signed-off-by: Reza Kurniawan > --- > Documentation/devicetree/bindings/arm/psci.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/psci.yaml b/Documentation/devicetree/bindings/arm/psci.yaml > index 0d04389c81..7777077dd0 100644 > --- a/Documentation/devicetree/bindings/arm/psci.yaml > +++ b/Documentation/devicetree/bindings/arm/psci.yaml > @@ -98,6 +98,19 @@ properties: > [1] Kernel documentation - ARM idle states bindings > Documentation/devicetree/bindings/cpu/idle-states.yaml > > + skip-suspend-mode-switch: > + $ref: /schemas/types.yaml#/definitions/flag > + description: | > + Do not issue PSCI_SET_SUSPEND_MODE. > + > + Some firmware advertises support for OS-initiated mode but rejects > + every suspend mode switch with NOT_SUPPORTED. Since PSCI cannot report > + the current mode, the OS cannot verify the state the firmware is in. > + > + This property is an assertion that the firmware works correctly without > + a mode switch. This is a workaround for non-compliant firmware, only set > + it on firmware known to behave this way. "for devices that ship with firmware known to …" would be better phrasing imo, "set it on firmware" might sound like it's implying things that aren't actually happening Thanks, ~val