From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 189862DAFC9 for ; Thu, 11 Sep 2025 08:46:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757580379; cv=none; b=RHuyy+2zPq6qGAt29mXH91eGlMSa1MKdblD87t5ObtomdIxphQSMU5rZFlPSOTL/4S7fV3YEZEo+jheQffv+nP+DhuEhCEZz3nXydc3faHNRuS2GQ1OGM3k0VA3jmjKMpVAtx8jAZTV+zikuZR2ux2hd5ciVcMgygJ30aEduwrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757580379; c=relaxed/simple; bh=K1OfSduqwQRBsTKKg1BvFgKfn1PGIxJFKzG2KTEy5K8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WoY6XJtrSfcmDILjqncS3wF2kmJWA3FfPI5IPEXAQgbtG8XCwXdXvaqeD6FN1wLDc4WTx0Mq2/3B+gMOp84vpEHvYPDMjJ051zCO5SPmv7PCPTO4eteHc0oO2ms6SI3ZDdYtv3Hvc+6fu1a4Xr+wdM3+9qTh9abkcu3taeCulKI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BLp/+df+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BLp/+df+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757580376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ssCjsQRosnIsyQi6TRiWy/gOOQy1TqZDzUkPJYAbPso=; b=BLp/+df+XMNhpL1kC6Dd5wlnl6OXGgPiJkbz1vZBu1XJt+YxuQlpr+ILMI676gKoPRK6cd AS5tG/UdLp4pgHbRZkEyWmSeRpg0AWJ3iozkWQcSDfieuu1uvus2tY2l5R9Q9OeIa+hcYG ugJB5R+qoK0QOQU0qj4n2fIeWfpEtuM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-563-YqidZTGdMNiFWMOTuf0qxw-1; Thu, 11 Sep 2025 04:46:14 -0400 X-MC-Unique: YqidZTGdMNiFWMOTuf0qxw-1 X-Mimecast-MFC-AGG-ID: YqidZTGdMNiFWMOTuf0qxw_1757580373 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-45deddf34b9so9633465e9.1 for ; Thu, 11 Sep 2025 01:46:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757580373; x=1758185173; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ssCjsQRosnIsyQi6TRiWy/gOOQy1TqZDzUkPJYAbPso=; b=qLGBByJu32fG3SGbmeP8o1mjKC1Zu6A8eadG1Vlsd/sQIIYcvSdzyA2Txq+EoovEI7 Jm0TSYcz/UXh44ubMkIefS4Um1yKrw/LzppPXwxuwM7npOUabHEDHq5ukLruIxHrsAz4 kbfFP4wFXJSdlZaohVhWDUodpeN10OhAUjUpQNigxRnoZJIonQvg0jAEWskKyLWbldAr h8PFHjQ+Xr4iY7BrWqORd59AS43WTVAmjvQXqOSOQYU/U+4uYt2xL5KeZ7THQhVTX4m6 UZU9RJuyOT2XH48v2bfOTerHGkTCsmk6wuLXsayDK1isC4VVFjAVtyjWLkGqEfYCakm4 7oXw== X-Forwarded-Encrypted: i=1; AJvYcCUgubfdLKLDOLP6oX2IsUhmABjLLIktElKam70VKzbxCERaJA3/QMgUKDTNX4u3+ggjqTM/GO/mLDU6RcI=@vger.kernel.org X-Gm-Message-State: AOJu0YzN8QyE3IvQBOo8c3XuP/hbhKgtFKcKT2NXr6DfnB0RU6cm9KRt bXZ4RNAXIb9mi//C+7BvfpIzRH7HYzqiIEmbn5SWsI5nvhW7ohX9hlxfc5tneLHBy7mbHlckn1W e8dox+3WmoDjC/XITlOGbtYBKxn+3h4z+XNHx79Z84zopyalFPCEaouUB5fvldvPsyw== X-Gm-Gg: ASbGncupjzt4vYk4l6jOLLeyT3eLVJlnKJzRntukXNIg7ioj6cOTmlzaqkBa5yZMmXo n4puxg7ob02ChtsqDpspD/+xQyJOzbRCWQIEH6VTPQFTQz0EoDOxRCOC/w1MLtNftkgLZR6Az7x s+LUGlWysYVyejE8WPeeV+gLw4CyJvIbwa7AgpOGo3MXIhDaypCE6ZTIBpSKYP3/W+xGHgAjFz3 yKaNypMAsZTezz+CyNDt+7yAqD6uzJK+3TUnWqDeDk36eqNzh3cLdrqRJtN3671CEVMR9y3WmUT jBP8gzNYb44JpDDa5Aa68O00uZEcbyy3XnyUFoCTjWd8fnTH91nbb0y3HVeHmwz64QpUbu/AvgJ D/0vmfZXiM3LjxP4B0vTXz2j4W0LzU3WCPTFZOdqZvXo3b+W0R6FPbQfC/NcJaeL+kmg= X-Received: by 2002:a05:600c:46c8:b0:458:b8b0:6338 with SMTP id 5b1f17b1804b1-45dfd5c473bmr26815845e9.6.1757580373264; Thu, 11 Sep 2025 01:46:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFEKWKwxqu2qOEyBEgAUAxpXzm9G4HcETc4FviAdPqhEnNC1NKGJCc3NQuXVk0LzZ/0UgZIzQ== X-Received: by 2002:a05:600c:46c8:b0:458:b8b0:6338 with SMTP id 5b1f17b1804b1-45dfd5c473bmr26815495e9.6.1757580372845; Thu, 11 Sep 2025 01:46:12 -0700 (PDT) Received: from ?IPV6:2003:d8:2f42:b000:db8b:7655:f60f:812b? (p200300d82f42b000db8b7655f60f812b.dip0.t-ipconnect.de. [2003:d8:2f42:b000:db8b:7655:f60f:812b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e760786ceasm1624111f8f.16.2025.09.11.01.46.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Sep 2025 01:46:12 -0700 (PDT) Message-ID: <749511a8-7c57-4f97-9e49-8ebe8befe9aa@redhat.com> Date: Thu, 11 Sep 2025 10:46:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/memory-failure: Disable soft offline for HugeTLB pages by default To: Kyle Meyer , akpm@linux-foundation.org, corbet@lwn.net, linmiaohe@huawei.com, shuah@kernel.org, tony.luck@intel.com Cc: Liam.Howlett@oracle.com, bp@alien8.de, hannes@cmpxchg.org, jack@suse.cz, jane.chu@oracle.com, jiaqiyan@google.com, joel.granados@kernel.org, laoar.shao@gmail.com, lorenzo.stoakes@oracle.com, mclapinski@google.com, mhocko@suse.com, nao.horiguchi@gmail.com, osalvador@suse.de, rafael.j.wysocki@intel.com, rppt@kernel.org, russ.anderson@hpe.com, shawn.fan@intel.com, surenb@google.com, vbabka@suse.cz, linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org References: From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10.09.25 18:15, Kyle Meyer wrote: > Soft offlining a HugeTLB page reduces the available HugeTLB page pool. > Since HugeTLB pages are preallocated, reducing the available HugeTLB > page pool can cause allocation failures. > > /proc/sys/vm/enable_soft_offline provides a sysctl interface to > disable/enable soft offline: > > 0 - Soft offline is disabled. > 1 - Soft offline is enabled. > > The current sysctl interface does not distinguish between HugeTLB pages > and other page types. > > Disable soft offline for HugeTLB pages by default (1) and extend the > sysctl interface to preserve existing behavior (2): > > 0 - Soft offline is disabled. > 1 - Soft offline is enabled (excluding HugeTLB pages). > 2 - Soft offline is enabled (including HugeTLB pages). > > Update documentation for the sysctl interface, reference the sysctl > interface in the sysfs ABI documentation, and update HugeTLB soft > offline selftests. I'm sure you spotted that the documentation for "/sys/devices/system/memory/soft_offline_pag" resides under "testing". If your read about MADV_SOFT_OFFLINE in the man page it clearly says: "This feature is intended for testing of memory error-handling code; it is available only if the kernel was configured with CONFIG_MEMORY_FAILURE." So I'm sorry to say: I miss why we should add all this complexity to make a feature used for testing soft-offlining work differently for hugetlb folios -- with a testing interface. -- Cheers David / dhildenb