From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C147D1F8755 for ; Tue, 20 Jan 2026 02:43:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768877034; cv=none; b=Vm2QAP5VnhT8G8pDY+PtHQgBcAXmTAHhC5dSQVWu+i1xB7wy7VULBSrtCXFcCem385lZnkD5hp36KtDzhTVz2agFk+BchybMtoApHDhv3u7XHFiU0fbo4tlFGMBvyf89E0BbhnQP+FMoIHuEmPlFjqWFzZcwtNajAyvzF0sGTqE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768877034; c=relaxed/simple; bh=nuUeT7gQlkRoba8PY7o/3+JBn/7v3Dz02pM/gPiGE3U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YrDjW0SIAP3Qmx3o/47A8F7Z8MEsFHRCZhAax4eoVZjbGfQ2xrGFMp8N55dOZ8OxMSOn6/vaFHWsgE3ervygglb5IlREqjS+5lM41vivm+xV9sDeiEM9J+mjgT9RphN4cA+DU1Lj7p6rhD7PogEDjBXIKs4SlLMPYbIpe5NbTco= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WSvofj2G; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CgJB4cPW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WSvofj2G"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CgJB4cPW" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60JEoSJC2305826 for ; Tue, 20 Jan 2026 02:43:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NRl6Sa+ZwZHRuOm1+JnhJZ4n5H6tSZyrGahUYzTc84k=; b=WSvofj2Ghfai1Lkw n/ekCft7017zUBHDfVGYjif8awVgXqrqhsEU0L1Kj1C2m6jjfd++qfyXeZjPwKEy yDXRmp1osxY1dxsB0joR1aNWiPGJMA7wfdi5dE+6VSIaUdzXFCl/tiNg1MtvcSO8 6u8pRPYhRVpjHaPBjDzeygdoNSPzDL9ourbsHugbo/KsPfhmKHERcXRsqkqGVf2E 3/H11PBbezN0yd0gLNIkHMIKbor9cryQ0fT1wLXesmS86xyQe5r8ybS81bOddA3p snpL9YvgB6TTUWziPGpNMHl4VGIHwVsBl4E0buhBSOOqp+hpQjC1hlFiNMHp0ABp Xu8yxQ== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bspqv9g3g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 20 Jan 2026 02:43:51 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c5539b9adbcso7019215a12.3 for ; Mon, 19 Jan 2026 18:43:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768877031; x=1769481831; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NRl6Sa+ZwZHRuOm1+JnhJZ4n5H6tSZyrGahUYzTc84k=; b=CgJB4cPW8JUr8ow44S7vUtZamHaSjWa9Sy2WOzkISNoxx1KG+OV/37Uyz42lUO2Jjh hvYmFPi7tUFDFTbrr/ChICFHu/03zE8glQa9518762Yo17sy8MKjmUxy1EPG7owbiwM1 ZDszthVU4WPS1dFXolVYBmyOzy2Fz3LhjKyr1kjc+vJe5FK3P9n77zh/aJ7ZoVdx4Tgn PO1C47K0KBONdLL8BCQkwQuhH+vB6V0zvsB8z0ZERn96msuDu1nExEms1CHf01fKAC03 Gh2brc8iYsfLfm3AQ3Lr/mTTYBucPWto4xccbx210LerofAK8lDpBEEtGQSRAOOwGsU+ 0Ykg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768877031; x=1769481831; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NRl6Sa+ZwZHRuOm1+JnhJZ4n5H6tSZyrGahUYzTc84k=; b=F3FMGjuxgRxSMSjooOkizk+KlTlyEiD+Rmono+5KjqoHfieg7402lNCLxoaKj4DAqs 7Z4157uesTB/5pEU8NlpA0Ram29mHwoni/LmZtnhdZaCHAmujJgtOLxreQ+VpA8SBEsH +IPZixcHBKJyq2yyEiAHfamQySOfIWgRRi5BgHKoCG4WKL33CLb3lqhTbjq2Hqf1/NYf KvEEoolIDOTSH1q+zQ6dJBBaRhbnv0E6tnBLYTRocws4xDZp/uJY4cLN2Oo/nNXP6fTL MxkoouFmrI7m1cSVIeNJ7TqcGlXRHe+G3S5tHmTQB7DXJ/CYW1L4/KqasbuDnOO5zhnt iZJg== X-Forwarded-Encrypted: i=1; AJvYcCXcK+srI+CrLpeRheyNGNNRmO0qd5na5YqjD2aL5aQzDO8LV0SYO9Bi13yT5/jVIoEtl52zttI/9IMrd9Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxoHTx+ScDjqcBMPD8cgvgTZHro0e6UOJ/tAFPwNg1FJCErHRgz zrSnWov5EPCMOfYJwaWu13V7cR1tduuyG57blsZAqCq8JKXPGjIamiOoiV+Rd7VjRNUqeRavtp6 SYnM+OCwZLlo8vkU1i7/O8o8SN8ck1mF9mmfQbW/RplzFQW1aklZuklkJf2C7dG93yWbwWDu5G9 D8nA== X-Gm-Gg: AY/fxX49Rj3ZYgb8g8S0H7ksk5K67KkK/ForVZwUC1+bymQOWDKMcTavd9128KSG9sa 9R3WwhdTLVNOrTEfaKiZmOTS9L1Rioy40oIyvk3P2zzyLl38WviJqR8O6tmePzvfuf9qLLXKLZa cQgq/AteVxaGWZ7EI+NVN6CQWl4U1BxEE2rFNQU/ZoGQENhoarY2BTMOZsLfyYKJb6IGEt6RSCL CNobaFReaThTUqE8OK78/IriIBwhPJlgrwwEQwuOirBKprElwhCqL32cB+cNxHqg07HF6uoTxNo lGbdF1JmGVHTA4WRj6xXuGvEAw79ZG6H7ozW1JEOXJMGlH/DXfchPMJ0VhixkHgtY6ndv+pRQfV 0nCxccelohYoFqkVtFLEQ85l+CI7vVEWqO96kYgQFzRmBL81DD9O57w1YWBR+Gs5rV5bSUUk5tx 5yHSPf X-Received: by 2002:a05:6a21:6f01:b0:2b1:c9dc:6da0 with SMTP id adf61e73a8af0-38e45e40609mr460454637.46.1768877031042; Mon, 19 Jan 2026 18:43:51 -0800 (PST) X-Received: by 2002:a05:6a21:6f01:b0:2b1:c9dc:6da0 with SMTP id adf61e73a8af0-38e45e40609mr460438637.46.1768877030477; Mon, 19 Jan 2026 18:43:50 -0800 (PST) Received: from [10.133.33.57] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c5edf395851sm10323294a12.36.2026.01.19.18.43.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jan 2026 18:43:50 -0800 (PST) Message-ID: <749e716e-a6cb-4adb-8ffc-0d6f4c6d56c4@oss.qualcomm.com> Date: Tue, 20 Jan 2026 10:43:46 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/msm/dp: Correct LeMans/Monaco DP phy Swing/Emphasis setting To: Dmitry Baryshkov Cc: Vinod Koul , Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Abel Vesa References: <20260119-klm_dpphy-v2-1-52252190940b@oss.qualcomm.com> <47skckagggxijdhinmmibtrd3dydixtj6pccrgjwyczs7bj2te@2rq2iprmzvyf> Content-Language: en-US From: Yongxing Mou In-Reply-To: <47skckagggxijdhinmmibtrd3dydixtj6pccrgjwyczs7bj2te@2rq2iprmzvyf> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Js78bc4C c=1 sm=1 tr=0 ts=696eebe7 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=GPqq8a5sn0nJmRmufXgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-ORIG-GUID: slLlbjwN8NOwi_dBAx05KfLAmtO5OpGG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIwMDAyMSBTYWx0ZWRfX3rI8PrmjPJu8 Qj0G0gqHnS+BiY3CE0vkfHucjY086rde5cTbzoTsY52br3UdZjVm1zPjk3EFnzzgM/peHwyuFQ0 lLE3iIX3liiCX7TTZnHfyDUFBThzuxHZXniUqpSYXQknLc7b+MAwZVbnKLn/zoY8RcL8r6UpxDi r9WFmjRt12wPRhhZ6C50+nt9kpLFXWXlUQq/HHRKsZeRQnbRkR3zHhTMbWuDs+lHmSrkhr0D2Hq HrQCtOQOPYFhqljuNOjPpvOrTYwyRIJwkoTEeQ2haBPj6+rcQKS65bD3JSjvl9ZRMrr6L4SDBRU YnbTY34II38pedESyZpH7J6IEX0zdu4/0cOF8Zp9Wl9LsGPck4kRcmSBtNhYFa6Hdl/JQtmE468 LbA22ZioPt4PqhZCm1ael3W1z08ItVKoPQJQX56vDPDB/imNZ+9doEOamHG49fKNo1barQ+vPuR SbmtymFuVnEYVH9CLzA== X-Proofpoint-GUID: slLlbjwN8NOwi_dBAx05KfLAmtO5OpGG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-20_01,2026-01-19_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 adultscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601200021 On 1/19/2026 8:55 PM, Dmitry Baryshkov wrote: > On Mon, Jan 19, 2026 at 08:37:20PM +0800, Yongxing Mou wrote: >> Currently, the LeMans/Monaco devices and their derivative platforms >> operate in DP mode rather than eDP mode. Per the PHY HPG, the Swing and >> Emphasis settings need to be corrected to the proper values. > > No, they need to be configured dynamically. I wrote earlier that the > driver needs refactoring. > Hi, Dmitry. I plan to submit them in this order: this patch ā†’ LDO patch ā†’ refactor. Since the refactor involves more platforms and may take some time, Iā€™d like to get this patch merged first. >> >> This will help achieve successful link training on some dongles. >> >> Cc: stable@vger.kernel.org >> Fixes: 3f12bf16213c ("phy: qcom: edp: Add support for eDP PHY on SA8775P") >> Reviewed-by: Abel Vesa >> Signed-off-by: Yongxing Mou >> --- >> Changes in v2: >> - Separate the LDO change out.[Konrad][Dmitry] >> - Modify the commit message.[Dmitry] >> - Link to v1: https://lore.kernel.org/r/20260109-klm_dpphy-v1-1-a6b6abe382de@oss.qualcomm.com >> --- >> drivers/phy/qualcomm/phy-qcom-edp.c | 23 ++++++++++++++++++++++- >> 1 file changed, 22 insertions(+), 1 deletion(-) >> >