From: Stephen Warren <swarren@nvidia.com>
To: Andrew Chew <AChew@nvidia.com>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"olof@lixom.net" <olof@lixom.net>,
Dan Willemsen <dwillemsen@nvidia.com>,
Rhyland Klein <rklein@nvidia.com>,
Venkat Moganty <vmoganty@nvidia.com>
Cc: "devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Chew <AChew@nvidia.com>
Subject: RE: [PATCH 1/3 v2] usb: tegra20-ehci: Add devicetree support.
Date: Wed, 20 Jul 2011 12:51:08 -0700 [thread overview]
Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF049EBDEF4E@HQMAIL01.nvidia.com> (raw)
In-Reply-To: <1311190690-18334-1-git-send-email-achew@nvidia.com>
achew@nvidia.com wrote at Wednesday, July 20, 2011 1:38 PM:
> From: Andrew Chew <achew@nvidia.com>
>
> Add code to try to get platform data information (register base, irq,
> modes, various tuning parameters) from device tree, if not present in board
> files.
>
> Signed-off-by: Andrew Chew <achew@nvidia.com>
> +++ b/Documentation/devicetree/bindings/usb/tegra20-ehci.txt
...
> +Required properties for type = "ulpi":
> + - reset_gpio: The GPIO used to drive reset
> + - clk
We should probably document what this is. I know you're finding out more
about this internally.
> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
> + retval = of_property_read_u32(dn, "power_down_on_bus_suspend",
> + &pdata->power_down_on_bus_suspend);
Sorry I missed this before, but perhaps we should skip reading that
property unless mode=="host"?
Otherwise,
Acked-by: Stephen Warren <swarren@nvidia.com>
--
nvpublic
next prev parent reply other threads:[~2011-07-20 19:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 19:38 achew
2011-07-20 19:38 ` [PATCH 2/3 v2] dt: tegra20: Add ehci host controller nodes achew
2011-07-20 19:52 ` Stephen Warren
2011-07-20 20:03 ` Grant Likely
2011-07-20 19:38 ` [PATCH 3/3 v2] dt: tegra20: Add ehci overrides to Seaboard achew
2011-07-20 19:51 ` Stephen Warren [this message]
2011-07-20 20:02 ` [PATCH 1/3 v2] usb: tegra20-ehci: Add devicetree support Grant Likely
2011-07-20 20:16 ` Andrew Chew
2011-07-20 20:19 ` Grant Likely
2011-07-20 20:27 ` Andrew Chew
2011-07-20 20:28 ` Grant Likely
2011-07-20 22:23 ` Andrew Chew
2011-07-20 22:57 ` Andrew Chew
2011-07-20 22:52 ` Andrew Chew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74CDBE0F657A3D45AFBB94109FB122FF049EBDEF4E@HQMAIL01.nvidia.com \
--to=swarren@nvidia.com \
--cc=AChew@nvidia.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dwillemsen@nvidia.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rklein@nvidia.com \
--cc=vmoganty@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®