From: Stephen Warren <swarren@nvidia.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>, Colin Cross <ccross@android.com>,
Erik Gilling <konkers@android.com>,
Olof Johansson <olof@lixom.net>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] ARM: tegra: Fix <mach/gpio.h> to have necessary #includes
Date: Thu, 11 Aug 2011 12:49:47 -0700 [thread overview]
Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF04AEA24CD0@HQMAIL01.nvidia.com> (raw)
Russell King wrote at Thursday, August 11, 2011 1:36 PM:
> On Thu, Aug 11, 2011 at 12:05:52PM -0600, Stephen Warren wrote:
> > Without this, EINVAL isn't defined, and type bool isn't declared.
> > This leads to compilation failures.
>
> An alternative approach would be to convert tegra to be able to use
> the gpiolib __gpio_to_irq() for the on-SoC stuff, and eliminate
> irq_to_gpio().
>
> Would it be possible to do that instead?
That should work too.
I posted a couple patches last Friday to remove irq_to_gpio:
https://lkml.org/lkml/2011/8/5/343
https://lkml.org/lkml/2011/8/5/342
Later in the thread, you said you would merge them into your branch to
avoid merge conflicts with the other GPIO work you were doing.
For gpio_to_irq, yes, I believe we get rid of it pretty easily; we'd
just need to implement gpio-tegra.c's gpio_chip.to_irq function. Should
I cook up a patch based on top of linux-next plus the two patches above
to do that instead?
Thanks.
--
nvpublic
next reply other threads:[~2011-08-11 19:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 19:49 Stephen Warren [this message]
2011-08-11 20:02 ` Russell King - ARM Linux
-- strict thread matches above, loose matches on Subject: below --
2011-08-11 18:05 Stephen Warren
2011-08-11 19:36 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74CDBE0F657A3D45AFBB94109FB122FF04AEA24CD0@HQMAIL01.nvidia.com \
--to=swarren@nvidia.com \
--cc=arnd@arndb.de \
--cc=ccross@android.com \
--cc=konkers@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®