From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754475Ab1HOPr5 (ORCPT ); Mon, 15 Aug 2011 11:47:57 -0400 Received: from hqemgate03.nvidia.com ([216.228.121.140]:14224 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752438Ab1HOPry (ORCPT ); Mon, 15 Aug 2011 11:47:54 -0400 X-PGP-Universal: processed; by hqnvupgp05.nvidia.com on Mon, 15 Aug 2011 08:47:30 -0700 From: Stephen Warren To: Belisko Marek CC: Grant Likely , Colin Cross , Erik Gilling , Olof Johansson , Russell King , Arnd Bergmann , "devicetree-discuss@lists.ozlabs.org" , "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Date: Mon, 15 Aug 2011 08:47:27 -0700 Subject: RE: [RFC PATCH 08/12] gpio/tegra: Add device tree support Thread-Topic: [RFC PATCH 08/12] gpio/tegra: Add device tree support Thread-Index: AcxZnkYdJ8oj3aXGRPevQyYPr2/8kgBxCspg Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF04AEA25048@HQMAIL01.nvidia.com> References: <1313189697-21287-1-git-send-email-swarren@nvidia.com> <1313189697-21287-9-git-send-email-swarren@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id p7FFm4L3024747 Belisko Marek wrote at Saturday, August 13, 2011 3:49 AM: > On Sat, Aug 13, 2011 at 12:54 AM, Stephen Warren wrote: > > Signed-off-by: Stephen Warren > > --- > >  drivers/gpio/gpio-tegra.c |   31 +++++++++++++++++++++++++++++++ > >  1 files changed, 31 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c ... > > +static void __init tegra_gpio_probe_dt(struct platform_device *pdev) > > +{ > > +       const __be32 *gpios; > > +       u32 gpioslen; > > +       int i; > > + > > +       gpios = of_get_property(pdev->dev.of_node, "nvidia,gpios", &gpioslen); > > +       if (gpios == NULL) > > +               return; > > + > > +       gpioslen /= sizeof(*gpios); > > +       for (i = 0; i < gpioslen; i++, gpios++) { > > +               u32 gpio = be32_to_cpup(gpios); > > +               dev_err(&pdev->dev, "Enabling GPIO %d\n", gpio); > > Is really necessary to print all enabled gpio's to console? Also seen > same in pinmux probe. Oops, that's certainly not necessary. That was debugging code, and I meant to convert to dev_dbg before posting. -- nvpublic {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I