From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752302Ab1HOQHk (ORCPT ); Mon, 15 Aug 2011 12:07:40 -0400 Received: from hqemgate04.nvidia.com ([216.228.121.35]:7472 "EHLO hqemgate04.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751758Ab1HOQHj convert rfc822-to-8bit (ORCPT ); Mon, 15 Aug 2011 12:07:39 -0400 X-PGP-Universal: processed; by hqnvupgp05.nvidia.com on Mon, 15 Aug 2011 09:07:19 -0700 From: Stephen Warren To: Shawn Guo CC: Grant Likely , Colin Cross , Erik Gilling , Olof Johansson , Russell King , "devicetree-discuss@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Date: Mon, 15 Aug 2011 09:07:16 -0700 Subject: RE: [RFC PATCH 00/12] arm/tegra: Initialize GPIO & pinmux from DT Thread-Topic: [RFC PATCH 00/12] arm/tegra: Initialize GPIO & pinmux from DT Thread-Index: AcxZuRJ7/1iIMqBLS/GG4F9j282JdgBrAhcg Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF04AEA25054@HQMAIL01.nvidia.com> References: <1313189697-21287-1-git-send-email-swarren@nvidia.com> <20110813130858.GC7244@S2100-06.ap.freescale.net> In-Reply-To: <20110813130858.GC7244@S2100-06.ap.freescale.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Shawn Guo wrote at Saturday, August 13, 2011 7:09 AM: > On Fri, Aug 12, 2011 at 04:54:45PM -0600, Stephen Warren wrote: > > This patch modifies Tegra's device tree support to remove the dependency > > on harmony_pinmux_init(), thus making it completely board-independent. > > > > Some notes: > > ... > > * tegra_pinmux_probe_dt() enumerates all legal pingroup names, and searches > > for a pinmux controller subnode of that name, then processes each one > > that is found. An alternative that some may prefer would be to enumerate > > each child node of the pinmux controller, and have each node contain an > > explicit pingroup name property instead. Does anyone have any preference > > here? I suppose the latter option would obviate the need to add > > of_find_child_node_by_name(). > > I agree with Jamie that the latter option seems better/simper. OK, I'll flip the iteration around. ... > > arch/arm/boot/dts/tegra-harmony.dts | 479 ++++++++++++++++++++++++++ > > arch/arm/boot/dts/tegra-seaboard.dts | 409 ++++++++++++++++++++++ > > arch/arm/boot/dts/tegra20.dtsi | 5 + > > arch/arm/mach-tegra/Makefile | 1 - > > arch/arm/mach-tegra/board-dt.c | 12 +- > > arch/arm/mach-tegra/board-harmony-pinmux.c | 8 + > > arch/arm/mach-tegra/board-paz00-pinmux.c | 8 + > > arch/arm/mach-tegra/board-seaboard-pinmux.c | 9 +- > > arch/arm/mach-tegra/board-trimslice-pinmux.c | 7 + > > arch/arm/mach-tegra/devices.c | 10 + > > arch/arm/mach-tegra/devices.h | 2 + > > arch/arm/mach-tegra/pinmux.c | 136 ++++++++ > > drivers/gpio/gpio-tegra.c | 56 +++- > > drivers/of/base.c | 18 + > > include/linux/of.h | 2 + > > 15 files changed, 1138 insertions(+), 24 deletions(-) > > > Generally, you need to document the bindings you come with in > Documentation/devicetree/bindings/ Uggh. I must have run format-patch on the wrong commit ID; the last thing I did was to add a couple commits containing the documentation:-( I really shouldn't try to post patch series last thing on Friday... -- nvpublic