From: Stephen Warren <swarren@nvidia.com>
To: Peter De Schrijver <pdeschrijver@nvidia.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Colin Cross <ccross@android.com>,
Erik Gilling <konkers@android.com>,
Olof Johansson <olof@lixom.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: RE: [PATCH v5 3/3] arm/tegra: device tree support for ventana board
Date: Thu, 29 Sep 2011 10:04:15 -0700 [thread overview]
Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF173A2C6717@HQMAIL01.nvidia.com> (raw)
In-Reply-To: <1317248978-10829-4-git-send-email-pdeschrijver@nvidia.com>
Peter De Schrijver wrote at Wednesday, September 28, 2011 4:30 PM:
...
> diff --git a/arch/arm/mach-tegra/board-dt.c b/arch/arm/mach-tegra/board-dt.c
...
> @@ -80,9 +80,19 @@ static struct of_device_id tegra_dt_gic_match[] __initdata = {
> {}
> };
>
> +static struct {
> + char *machine;
> + void (*init)(void);
> +} pinmux_configs[] = {
> + { "nvidia,harmony", harmony_pinmux_init() },
> + { "nvidia,seaboard", seaboard_pinmux_init() },
> + { "nvidia,ventana", ventana_pinmux_init() },
> +};
Do you want the brackets after the function names there? Locally, they
cause the following syntax errors during compilation:
arch/arm/mach-tegra/board-dt.c:85: error: initializer element is not constant
arch/arm/mach-tegra/board-dt.c:85: error: (near initialization for 'pinmux_configs[0].init')
arch/arm/mach-tegra/board-dt.c:86: error: initializer element is not constant
arch/arm/mach-tegra/board-dt.c:86: error: (near initialization for 'pinmux_configs[1].init')
arch/arm/mach-tegra/board-dt.c:87: error: initializer element is not constant
arch/arm/mach-tegra/board-dt.c:87: error: (near initialization for 'pinmux_configs[2].init')
(using gcc version 4.4.3 (gcc-4.4.3_cos_gg_51096))
--
nvpublic
next prev parent reply other threads:[~2011-09-29 17:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 22:29 [PATCH v5 0/3] Add support for tegra2 based " Peter De Schrijver
2011-09-28 22:29 ` [PATCH v5 1/3] arm/tegra: prepare Seaboard pinmux code for derived boards Peter De Schrijver
2011-09-28 22:29 ` [PATCH v5 2/3] arm/tegra: add support for ventana pinmuxing Peter De Schrijver
2011-09-29 9:29 ` Russell King - ARM Linux
2011-09-29 15:27 ` Peter De Schrijver
2011-09-29 15:47 ` Olof Johansson
2011-09-28 22:29 ` [PATCH v5 3/3] arm/tegra: device tree support for ventana board Peter De Schrijver
2011-09-29 17:04 ` Stephen Warren [this message]
2011-09-29 18:55 ` Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74CDBE0F657A3D45AFBB94109FB122FF173A2C6717@HQMAIL01.nvidia.com \
--to=swarren@nvidia.com \
--cc=ccross@android.com \
--cc=konkers@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=pdeschrijver@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®